Reported by Oracle Parfait 16.2 static analyzer:
Error: Memory leak
Memory leak [memory-leak]:
Memory leak of pointer crtcPriv allocated with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
at line 652 of driver/xf86-video-siliconmotion/src/smi501_crtc.c in function 'SMI501_CrtcPreInit'.
calloc called at line 35 of xserver/os/alloc.c in function 'XNFcallocarray'
Allocated value returned to caller at line 39
XNFcallocarray called at line 238 of driver/xf86-video-siliconmotion/src/smi_crtc.c in function 'SMI_CrtcFuncsInit_base'
crtcPriv allocated at line 633 of driver/xf86-video-siliconmotion/src/smi501_crtc.c in function 'SMI501_CrtcPreInit' with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
Memory leak [memory-leak]:
Memory leak of pointer crtcPriv allocated with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
at line 672 of driver/xf86-video-siliconmotion/src/smi501_crtc.c in function 'SMI501_CrtcPreInit'.
calloc called at line 35 of xserver/os/alloc.c in function 'XNFcallocarray'
Allocated value returned to caller at line 39
XNFcallocarray called at line 238 of driver/xf86-video-siliconmotion/src/smi_crtc.c in function 'SMI_CrtcFuncsInit_base'
crtcPriv allocated at line 657 of driver/xf86-video-siliconmotion/src/smi501_crtc.c in function 'SMI501_CrtcPreInit' with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
Error: Memory leak
Memory leak [memory-leak]:
Memory leak of pointer crtcPriv allocated with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
at line 946 of driver/xf86-video-siliconmotion/src/smilynx_crtc.c in function 'SMILynx_CrtcPreInit'.
calloc called at line 35 of xserver/os/alloc.c in function 'XNFcallocarray'
Allocated value returned to caller at line 39
XNFcallocarray called at line 238 of driver/xf86-video-siliconmotion/src/smi_crtc.c in function 'SMI_CrtcFuncsInit_base'
crtcPriv allocated at line 923 of driver/xf86-video-siliconmotion/src/smilynx_crtc.c in function 'SMILynx_CrtcPreInit' with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
Memory leak [memory-leak]:
Memory leak of pointer crtcPriv allocated with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
at line 983 of driver/xf86-video-siliconmotion/src/smilynx_crtc.c in function 'SMILynx_CrtcPreInit'.
calloc called at line 35 of xserver/os/alloc.c in function 'XNFcallocarray'
Allocated value returned to caller at line 39
XNFcallocarray called at line 238 of driver/xf86-video-siliconmotion/src/smi_crtc.c in function 'SMI_CrtcFuncsInit_base'
crtcPriv allocated at line 952 of driver/xf86-video-siliconmotion/src/smilynx_crtc.c in function 'SMILynx_CrtcPreInit' with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
Memory leak [memory-leak]:
Memory leak of pointer crtcPriv allocated with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
at line 997 of driver/xf86-video-siliconmotion/src/smilynx_crtc.c in function 'SMILynx_CrtcPreInit'.
calloc called at line 35 of xserver/os/alloc.c in function 'XNFcallocarray'
Allocated value returned to caller at line 39
XNFcallocarray called at line 238 of driver/xf86-video-siliconmotion/src/smi_crtc.c in function 'SMI_CrtcFuncsInit_base'
crtcPriv allocated at line 988 of driver/xf86-video-siliconmotion/src/smilynx_crtc.c in function 'SMILynx_CrtcPreInit' with SMI_CrtcFuncsInit_base(&crtcFuncs, &crtcPriv)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-siliconmotion/-/merge_requests/12>
The module directory has changed to a per ABI folder in the xlibre-xserver.
Now the default value of `xorg-module-dir` will be detected from the `moduledir` variable in xorg-server.pc.
Signed-off-by: b-aaz <b-aazbsd.proton.me>
This pipeline builds the driver against the latest Xserver stable
release as well as current master.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Add the following forms for issue creation:
* Bug report
* Feature request
* Code change
* Documentation update
* Organizational task
* add issue type selection page on "New Issue" call
* mention Github Discussions and the mailing list where appropriate
Part-of: X11Libre/misc#156
Signed-off-by: callmetango <callmetango@users.noreply.github.com>
On glibc, the _GNU_SOURCE symbol needs to be defined in order to get
asprintf() defined.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Reported by clang 19.1.7:
smi_video.c:1836:14: warning: signed shift result (0x80000000) sets the
sign bit of the shift expression's type ('int') and becomes negative
[-Wshift-sign-overflow]
1836 | csc = (1 << 31) | (1 << 25);
| ~ ^ ~~
smi_video.c:1897:35: warning: signed shift result (0x80000000) sets the
sign bit of the shift expression's type ('int') and becomes negative
[-Wshift-sign-overflow]
1897 | while (READ_DPR(pSmi, 0xfc) & (1 << 31))
| ~ ^ ~~
smi_video.c:1901:35: warning: signed shift result (0x80000000) sets the
sign bit of the shift expression's type ('int') and becomes negative
[-Wshift-sign-overflow]
1901 | while (READ_DPR(pSmi, 0xfc) & (1 << 31))
| ~ ^ ~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-siliconmotion/-/merge_requests/9>
Reported by clang 19.1.7:
smi_video.c:1629:5: warning: variable 'crtc' may be uninitialized when
used here [-Wconditional-uninitialized]
1629 | if(crtc == crtcConf->crtc[0])
| ^~~~
smi_video.c:1493:21: note: initialize the variable 'crtc' to silence this
warning
1493 | xf86CrtcPtr crtc;
| ^
| = NULL
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-siliconmotion/-/merge_requests/9>
smi_video.c: In function ‘SetAttrSAA7111’:
smi_video.c:802:33: warning: suggest braces around empty body
in an ‘if’ statement [-Wempty-body]
if ((j&7) == 7) DEBUG("\n");
^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
