XLibre/xf86-video-siliconmotion
1
0
Fork 0
mirror of https://github.com/X11Libre/xf86-video-siliconmotion.git synced 2026-03-24 01:25:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

SMI_DisplayVideo0501_CSC: Handle -Wshift-sign-overflow warnings

Browse Source 
Reported by clang 19.1.7:

smi_video.c:1836:14: warning: signed shift result (0x80000000) sets the
 sign bit of the shift expression's type ('int') and becomes negative
 [-Wshift-sign-overflow]
 1836 |     csc = (1 << 31) | (1 << 25);
      |            ~ ^  ~~

smi_video.c:1897:35: warning: signed shift result (0x80000000) sets the
 sign bit of the shift expression's type ('int') and becomes negative
 [-Wshift-sign-overflow]
 1897 |         while (READ_DPR(pSmi, 0xfc) & (1 << 31))
      |                                        ~ ^  ~~

smi_video.c:1901:35: warning: signed shift result (0x80000000) sets the
 sign bit of the shift expression's type ('int') and becomes negative
 [-Wshift-sign-overflow]
 1901 |         while (READ_DPR(pSmi, 0xfc) & (1 << 31))
      |                                        ~ ^  ~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-siliconmotion/-/merge_requests/9>
This commit is contained in:
Alan Coopersmith
2025-04-12 17:53:19 -07:00
parent b0846c0d8f
commit 70ac2f1c41
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/smi_video.c
View File

@@ -1812,7 +1812,8 @@ SMI_DisplayVideo0501_CSC(ScrnInfoPtr pScrn, int id, int offset,
SMIPtr pSmi = SMIPTR(pScrn);
BoxPtr pbox = REGION_RECTS(clipboxes);
int i, nbox = REGION_NUM_RECTS(clipboxes);
int32_t rect_x, rect_y, rect_w, rect_h, csc;
int32_t rect_x, rect_y, rect_w, rect_h;
uint32_t csc;
float Hscale, Vscale;
ENTER();
@@ -1835,23 +1836,23 @@ SMI_DisplayVideo0501_CSC(ScrnInfoPtr pScrn, int id, int offset,
/* Use start of framebuffer as base offset */
WRITE_DPR(pSmi, 0xf8, 0);
csc = (1 << 31) | (1 << 25);
csc = (1U << 31) | (1U << 25);
if (pSmi->Bpp > 2)
csc |= 1 << 26;
csc |= 1U << 26;
switch (id) {
case FOURCC_YV12:
SrcUVPitch = SrcYPitch / 2;
SrcVBase = SrcYBase + SrcYPitch * height;
SrcUBase = SrcVBase + SrcUVPitch * height / 2;
csc |= 2 << 28;
csc |= 2U << 28;
break;
case FOURCC_I420:
SrcUVPitch = SrcYPitch / 2;
SrcUBase = SrcYBase + SrcYPitch * height;
SrcVBase = SrcUBase + SrcUVPitch * height / 2;
csc |= 2 << 28;
csc |= 2U << 28;
break;
case FOURCC_YUY2:
@@ -1896,11 +1897,11 @@ SMI_DisplayVideo0501_CSC(ScrnInfoPtr pScrn, int id, int offset,
WRITE_DPR(pSmi, 0xEC, (rect_w << 16) | rect_h);
WRITE_DPR(pSmi, 0xF0, ((DestPitch >> 4) << 16) | rect_h);
while (READ_DPR(pSmi, 0xfc) & (1 << 31))
while (READ_DPR(pSmi, 0xfc) & (1U << 31))
;
WRITE_DPR(pSmi, 0xfc, csc);
/* CSC stop */
while (READ_DPR(pSmi, 0xfc) & (1 << 31))
while (READ_DPR(pSmi, 0xfc) & (1U << 31))
;
}