53876f1ef1
Mixed up reply vs request. Obviously, the size substracted from reply struct's one has to be the one of the generic reply, not generic requst :o Background: the meaning of the length field isn't entirely intuitive. a) the size is in 4-byte units, instead of bytes (therefore passing through bytes_to_int32() call) b) it's not the total packet size, but only the *extra* payload size, ergo: how much is the packet longer than a xGenericReply = 8 units = 32 bytes. (min. packet size is 32 bytes -> length = 0) In order to prevent those kind of coding errors ever happening again, it might be a good idea putting that into a generic macro. Fixes:c6f1b8a735Fixes:0ca5aaba50Issue: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1797 Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1845>
X Server
The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.
Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.
For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server
All questions regarding this software should be directed at the Xorg mailing list:
https://lists.freedesktop.org/mailman/listinfo/xorg
The primary development code repository can be found at:
https://gitlab.freedesktop.org/xorg/xserver
For patch submission instructions, see:
https://www.x.org/wiki/Development/Documentation/SubmittingPatches
As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc: