39e141eac0
We must not modify the contents of a client pixmap. If there's an available window buffer, we re-use that for the window pixmap. Otherwise we just allocate a new one. This also avoids Present client hangs due to xwl_present_buffer_release not getting called for the buffer release event. v2: * Use xwl_pixmap_get_buffer_release_cb instead of keeping track of the flip pixmap in xwl_window. * Dispose of xwl_window_buffer in xwl_window_swap_pixmap called from damage_report. v3: * Use xwl_window->surface_pixmap in damage_report. v4: * Don't re-use client pixmaps as window buffers. * Clear xwl_window_buffer->pixmap before calling xwl_window_buffer_maybe_dispose in xwl_window_swap_pixmap, to prevent it from clearing the buffer release callback. v5: * Keep using xwl_window_buffers_get_pixmap in xwl_window_attach_buffer. * Always keep a reference to the old window pixmap in _swap_pixmap, drop it in damage_report. Fixes:6779ec5bf6("xwayland: Use window pixmap as a window buffer") Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1633 Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1644 Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314> (cherry picked from commit6b290fa5d9)
X Server
The X server accepts requests from client applications to create windows, which are (normally rectangular) "virtual screens" that the client program can draw into.
Windows are then composed on the actual screen by the X server (or by a separate composite manager) as directed by the window manager, which usually communicates with the user via graphical controls such as buttons and draggable titlebars and borders.
For a comprehensive overview of X Server and X Window System, consult the following article: https://en.wikipedia.org/wiki/X_server
All questions regarding this software should be directed at the Xorg mailing list:
https://lists.freedesktop.org/mailman/listinfo/xorg
The primary development code repository can be found at:
https://gitlab.freedesktop.org/xorg/xserver
For patch submission instructions, see:
https://www.x.org/wiki/Development/Documentation/SubmittingPatches
As with other projects hosted on freedesktop.org, X.Org follows its Code of Conduct, based on the Contributor Covenant. Please conduct yourself in a respectful and civilized manner when using the above mailing lists, bug trackers, etc: