Enrico Weigelt, metux IT consult
f5fe8a6379
os: log: drop unused variables
...
Drop some unneeded variabes, whose values can be computed at compile-time.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691 >
2025-02-06 23:35:26 +00:00
Enrico Weigelt, metux IT consult
a33639f975
xvmc: move over protocol version defines into xvmc.c
...
These are exclusively used in one source file, so no need to keep them
in a global header.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1693 >
2025-02-06 23:29:10 +00:00
Enrico Weigelt, metux IT consult
171db3b01b
meson: drop defining BIGREQS
...
This symbol isn't used for decades, so no need to define it at all.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1700 >
2025-02-06 23:22:31 +00:00
Enrico Weigelt, metux IT consult
4235d2375a
xfree86: vgahw: drop obsolete vgaHWSaveScreenWeak()
...
No callers left, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
be9b89ef0f
xfree86: vgahw: drop obsolete vgaHWDisable()
...
No callers left, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
bb0295b397
xfree86: vgahw: drop obsolete vgaHWSetRegCounts
...
No callers left, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
515d19806c
xfree86: vgahw: make vgaHWSaveColormap() static
...
No external callers anymore, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
79522220a6
xfree86: vgahw: make vgaHWSaveMode() static
...
No external callers left, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
f004998b78
xfree86: vgaha: make vgaHWRestoreColormap() static
...
No external callers left, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
30380cb207
xfree86: vgahw: make vgaHWRestoreMode() static
...
No external callers anymore, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:39 +00:00
Enrico Weigelt, metux IT consult
cd2457412f
xfree86: vgahw: drop obsolete vgaHWBlankScreenWeak()
...
Not used anymore, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:39 +00:00
Enrico Weigelt, metux IT consult
a415e6ed37
xfree86: vgahw: drop obsolete vgaHWProtectWeak()
...
Not used anymore, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:39 +00:00
Enrico Weigelt, metux IT consult
00f69564c5
xfree86: common: unexport UnloadModule() and UnloadSubModule()
...
Not used by any driver/module, so no need to keep it exported.
Also making them type-safe.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1722 >
2025-02-06 23:09:02 +00:00
Enrico Weigelt, metux IT consult
b0452ecff4
xfree86: drop obsolete macro INITARGS
...
This macro isn't used anymore for 12 years now, see commit:
5079db78ae
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1722 >
2025-02-06 23:09:02 +00:00
Enrico Weigelt, metux IT consult
f3887956ec
xfree86: loader: drop unused LoaderGetABIVersion()
...
This function isn't called anywhere, neither in xserver nor modules, thus no
need to keep it around.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1722 >
2025-02-06 23:09:02 +00:00
Enrico Weigelt, metux IT consult
d8c47a3db6
xfree86: loader: drop unused LoaderShouldIgnoreABI()
...
This function isn't called anywhere, neither in xserver nor modules, thus no
need to keep it around.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1722 >
2025-02-06 23:09:02 +00:00
Enrico Weigelt, metux IT consult
24d693c5ae
dix: make dixDestroyPixmap() NULL-proof
...
Make dixDestroyPixmap() check for NULL pointer, so callers don't need to
do it anymore. Returning TRUE on NULL pointer - but most callers won't
even look at the retval anyways.
Together with subsequent commits, which will make use of that function,
instead of calling raw ScreenRec->DestroyPixmap vectors, this gives us some
more freedom for architectural changes, eg. get rid of the extremely
complicated and fragile wrapping chains.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1709 >
2025-02-06 23:02:06 +00:00
Enrico Weigelt, metux IT consult
ef62929f58
treewide: NULL-protect ScreenRec->DestroyPixmap() calls
...
Right now, we're assuming that even when deep nesting involved, the proc
vector is always set to a valid function. One the one hand it requires
extra dummy procs in some cases, OTOH it's making upcoming refactoring
of the code flow unnecessarily complex.
The big plot (of subsequent commits) is splitting out the extension's
(and possibly subsystem's) special logic out of the wrapping chain and
let them be executed independently from the DDX/drivers - when applicable
even only when the pixmap is really destroyed (not just unref'ed).
(At some later point, it might even become be actually a valid situation
that DestroyPixmap vector really being NULL.)
See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1754
See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1755
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1709 >
2025-02-06 23:02:06 +00:00
Enrico Weigelt, metux IT consult
af2d3e9487
xnest: drop obsolete mi.h include
...
Since moving to mi_priv.h, we don't need to include mi.h here.
Fixes: 94451181c2
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1725 >
2025-02-06 22:53:43 +00:00
Enrico Weigelt, metux IT consult
f8fc46cbbf
include: drop now empty xkbfile.h
...
This (public) file isn't used by anybody outside Xserver tree
and doesn't contain anything useful anymore, so lets drop it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1729 >
2025-02-06 22:45:25 +00:00
Enrico Weigelt, metux IT consult
3f8a5475c9
xkb: unexport remaining internal declarations
...
These are only used inside xkb/*, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1729 >
2025-02-06 22:45:25 +00:00
Enrico Weigelt, metux IT consult
660657a2c3
xkb: unexport functions from xkbout.c
...
These are only used inside xkb/*, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1729 >
2025-02-06 22:45:25 +00:00
Enrico Weigelt, metux IT consult
5d98664ec1
xkb: unexport functions from xkbfmisc.c
...
These are only used inside xkb/*, so no need to keep them exported.
Also replacing some macros by inline functions in order to improve
type-safety and debugging, and adding documentation.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1729 >
2025-02-06 22:45:25 +00:00
Enrico Weigelt, metux IT consult
114c1c84b1
xkb: move XkbConvertGetByNameComponents and make it static
...
This function has only one caller in xkb.c, so no need to keep it exported,
can be moved over into xkb.c and made static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1729 >
2025-02-06 22:45:25 +00:00
Enrico Weigelt, metux IT consult
cd52a8f8a4
xfree86: common: dont install xf86MatchDrivers.h
...
xf86MatchDrivers.h doesn't export any symbols, thus doesn't need to
be installed.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1738 >
2025-02-07 00:39:00 +02:00
Enrico Weigelt, metux IT consult
0b123a0413
xfree86: unexport xf86PlatformMatchDriver()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1738 >
2025-02-07 00:38:58 +02:00
Enrico Weigelt, metux IT consult
16ca87703c
xfree86: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
190346663b
Xi: drop now obsolete swap procs
...
Lots of SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
dc9a998b96
Xext: xv: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
753e6c44ba
Xext: xtest: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
0c87f9b1da
Xext: xcmisc: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
9a3daf908c
Xext: vidmode: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
3bb15b3e04
Xext: sync: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
c8c42490b7
Xext: shm: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
a7bdfdb3b5
Xext: shape: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
07131dccc5
Xext: saver: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
515992b046
Xext: panoramiX: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
98dbd817f6
Xext: dpms: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
0da419246e
randr: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
851ce5c6a8
dbe: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
4c3ff75772
dix: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Also dropping now obsolete SProcNoOperation().
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
643f91266e
xwin: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
4cb141307c
xwayland: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
65224a2f9a
xquartz: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
7e5c342be1
xfree86: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
4d053f22f3
Xi: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
54d4dd619c
Xext: xv: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
69982abf7b
Xext: xtest: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
8a5d2a1335
Xext: selinux: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
8b57516414
Xext: xres: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00