Commit Graph

21817 Commits

Author SHA1 Message Date
Enrico Weigelt, metux IT consult
cb85ceae2d glx: use DeleteCallbackList() for callback list destruction
We already have a function for callback list deletion, so use this one
instead of doing it manually.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 10:53:27 +02:00
Enrico Weigelt, metux IT consult
21fb27735a os: unexport XNFreallocarray()
Not used by any drivers, no no need to keep it in public SDK.
Since it's not used by drivers, it's effectively not an ABI change,
so can be done within ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 10:53:15 +02:00
Enrico Weigelt, metux IT consult
8cd201d89a dix: unexport ResourceStateCallback (not used by drivers)
Only used by Xselinux extension, not by any drivers, so no need to
keep it exported.

Since it's never been used by drivers at all, it's effectively no ABI change,
so can safely be done within ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 10:34:35 +02:00
Enrico Weigelt, metux IT consult
f29fb6bb62 present: unexport symbols not used by drivers
these symbols aren't used by any external drivers (not even proprietary
Nvidia), so no need to keep them exported any longer:

 * present_check_flips
 * present_register_complete_notify
 * present_can_window_flip
 * uint32_t FakeScreenFps

Since it's not any *effective* ABI change, can go into current ABI-25 line.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 17:09:43 +02:00
Enrico Weigelt, metux IT consult
0e723d3b1e xfree86: xv: fix missed hooking of WindowDestroy
Forgot to register window destroy hook - that's leading to crash:

    https://github.com/X11Libre/xserver/issues/959

Fixes: b60581e393
Bug: https://github.com/X11Libre/xserver/issues/959
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 17:04:56 +02:00
Enrico Weigelt, metux IT consult
1439fc7aa1 render: fix missing include in glyphstr.h
Need to include renderproto.h

Closes: https://github.com/X11Libre/xserver/issues/700
Reported-By: Kevin Kofler <kevin@tigcc.ticalc.org>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 16:45:16 +02:00
Enrico Weigelt, metux IT consult
f333cac5c2 Xext: namespace: fix NULL derefence on client close
Removing the namespace assignment of killed clients in ClientState-hook
is too early - we still need it later. Using the new ClientDestroyCallback
instead.

Closes: https://github.com/X11Libre/xserver/issues/486
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 16:28:17 +02:00
stefan11111
2c3d96e3ca composite: add a comment
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
2025-09-26 16:06:14 +02:00
stefan11111
2ab2454151 composite: Only copy bits from the parent pixmap when absolutely necessary
Since 1e728c3e88 ,
Whenever we allocate a composite pixmap, we perform an expensive CopyArea call from the parent pixmap.

This leads to very bad performance when not using a framebuffer driver without shadowfb.

My guess is that this call ends up reading memory from the framebuffer memory directly, which is very slow.

Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1814

Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
2025-09-26 16:06:14 +02:00
Enrico Weigelt, metux IT consult
74e3f18204 os: unexport inSignalContext
Only used inside OS layer and xfree86 os-support, so no need to keep
it in public SDK.

Since never used by any drivers, it's not an actual ABI change, so
we can safely do it within ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:58:04 +02:00
Enrico Weigelt, metux IT consult
caa3e1685a xfree86: dga: drop unnecessary swapped request handler
The request handler already refusing non-local access, so no need
for any extra swapped handler.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:57:13 +02:00
Enrico Weigelt, metux IT consult
9d1f0a555d xfree86: dri: drop unnecessary swapped request handler
The request handler already refusing non-local access, so no need
for any extra swapped handler.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:57:01 +02:00
Enrico Weigelt, metux IT consult
995398ecde os: rename audit.h to audit_priv.h
Our convention is naming private (non-SDK) headers w/ _priv.h suffix.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:56:47 +02:00
Enrico Weigelt, metux IT consult
b6945455bf render: consolidate byte-swapping in ProcRenderFreeGlyphs()
No need for extra functions and call tables for the few trivial lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:56:34 +02:00
Enrico Weigelt, metux IT consult
7afa753652 Xext: drop PanoramiXGCKey and PanoramiXScreenKey macros
We can directly use the actual fields, no need for these extra macros.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:38:07 +02:00
Enrico Weigelt, metux IT consult
6d00346893 Xext: xv: drop XvScreenKey macro
We can easily use &XvScreenKeyRec directly.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:35:25 +02:00
Enrico Weigelt, metux IT consult
da42cb968c os: move LogPrintMarkers() declaration into private header
Not exported, not used by any external modules, so no need to have
that declaration in a public SDK header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:50:59 +02:00
sesankm
79d092cfb9 glx: glxcmds: use rpcbuf to build xGLXGetDrawableAttributesReply payload
Signed-off-by: sesankm <26676400+sesankm@users.noreply.github.com>
2025-09-26 11:50:39 +02:00
sesankm
9d6094442a dix: rpcbuf: export x_rpcbuf_write_CARD32s for glx
Signed-off-by: sesankm <26676400+sesankm@users.noreply.github.com>
2025-09-26 11:50:39 +02:00
Enrico Weigelt, metux IT consult
da1509c364 render: consolidate byte-swapping in ProcRenderAddGlyphs()
No need for extra functions and call tables for the few trivial lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:49:18 +02:00
Enrico Weigelt, metux IT consult
56830521c1 render: consolidate byte-swapping in ProcRenderSetPictureClipRectangle()
No need for extra functions and call tables for the few trivial lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:49:10 +02:00
Enrico Weigelt, metux IT consult
3f5fdfc615 Xi: inline SProcXGrabDeviceKey()
No need to have a hole bunch of extra functions, if we can just easily
inline the few relevant lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:49:06 +02:00
Enrico Weigelt, metux IT consult
0c40403eb7 Xi: inline SProcXChangeDeviceDontPropagateList()
No need to have a hole bunch of extra functions, if we can just easily
inline the few relevant lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:48:27 +02:00
Enrico Weigelt, metux IT consult
71133d6502 Xi: inline SProcXSendExtensionEvent()
No need to have a hole bunch of extra functions, if we can just easily
inline the few relevant lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:48:16 +02:00
Enrico Weigelt, metux IT consult
3ddf48f3c6 dbe: replace dbeScreenPrivKey and dbeWindowPrivKey macros
No need for the extra macros, we can just use the corresponding
structs directly.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:47:28 +02:00
Enrico Weigelt, metux IT consult
16c0f1dfb8 dix: move struct _WorkQueue definition into dixutil.c
It's only used inside dixutil.c, nowhere else, especially not drivers,
so no need to keep it in public SDK. Safe for ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:47:15 +02:00
Enrico Weigelt, metux IT consult
6cb3338c0b xkb: inline SProcXkbUseExtension()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:47:04 +02:00
Enrico Weigelt, metux IT consult
8daa5bc8b9 xkb: inline SProcXkbBell()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:46:50 +02:00
Enrico Weigelt, metux IT consult
8d100100af xkb: inline SProcXkbGetControls()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:46:38 +02:00
Enrico Weigelt, metux IT consult
9879290e2f xkb: inline SProcXkbGetMap()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:46:26 +02:00
Enrico Weigelt, metux IT consult
39f9bbd827 xkb: inline SProcXkbGetIndicatorState()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:46:13 +02:00
Enrico Weigelt, metux IT consult
3d787e4c48 xkb: inline SProcXkbGetNamedIndicator()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:46:01 +02:00
Enrico Weigelt, metux IT consult
68e134de44 xkb: inline SProcXkbGetNames() and SProcXkbSetNames()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:45:49 +02:00
Enrico Weigelt, metux IT consult
1b719f8710 randr: xinerama: inline byte-swapping into actual request handlers
No need to have whole extra functions for just a few LoC, and in the
future the whole thing will become more simplified by generic macros.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:45:38 +02:00
Enrico Weigelt, metux IT consult
1cddcc087f xkb: inline SProcXkbGetCompatMap()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:45:25 +02:00
Enrico Weigelt, metux IT consult
8c545a6528 xkb: inline SProcXkbGetDeviceInfo()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:45:12 +02:00
Enrico Weigelt, metux IT consult
9eba2365c9 xkb: inline SProcXkbListComponents()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:44:59 +02:00
Enrico Weigelt, metux IT consult
25adcbfd5a xkb: inline SProcXkbSetGeometry()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:44:47 +02:00
Enrico Weigelt, metux IT consult
4ae70b0a09 os: Xtranssock: fix warning on strncpy() call
> ../os/Xtranssock.c:494:5: warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-truncation]
>  494 |     strncpy(addr->sa_data, port, portlen);
>      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../os/Xtranssock.c:446:15: note: length computed here
>  446 |     portlen = strlen(port) + 1; // include space for trailing null
>      |               ^~~~~~~~~~~~

Since we already know the string length, we can just use memcpy()

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 16:40:43 +02:00
Enrico Weigelt, metux IT consult
62174b33c3 include: move CharInfoPtr definition to gcstruct.h
Move it to where it's really needed.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 15:34:50 +02:00
Enrico Weigelt, metux IT consult
f2ce732ef5 treewide: replace PictFormatShort by pixman_format_code_t
Try not to use old compat macros anymore, use the real ones instead.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 14:28:06 +02:00
Enrico Weigelt, metux IT consult
dcaaa4a355 xfree86: drop XF86XvScreenKey field
Not used by any drivers anymore, so no need to keep it around any longer.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 14:27:53 +02:00
Enrico Weigelt, metux IT consult
6168868906 dix: replace XACE_SERVER_ACCESS by direct callback
Move the callbacks directly into DIX, since it's actually core infrastructure.
Also simplifying the whole machinery, by just using a simpel CallbackListPtr.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 14:27:41 +02:00
Enrico Weigelt, metux IT consult
bd41233e47 vfb: fix missing includes of extinit.h
Don't rely on this file just being included indirectly by somebody else
just by accident.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 13:49:14 +02:00
Enrico Weigelt, metux IT consult
2112cbb876 xwin: fix missing includes of extinit.h
Don't rely on this file just being included indirectly by somebody else
just by accident.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 13:49:05 +02:00
Enrico Weigelt, metux IT consult
c9437b5467 Xi: fix missing includes of extinit.h
Don't rely on this file just being included indirectly by somebody else
just by accident.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 13:48:53 +02:00
Enrico Weigelt, metux IT consult
0ade4aef80 mi: fix missing includes of extinit.h
Don't rely on this file just being included indirectly by somebody else
just by accident.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 13:48:41 +02:00
Enrico Weigelt, metux IT consult
45af32a981 render: fix missing includes of extinit.h
Don't rely on this file just being included indirectly by somebody else
just by accident.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 13:48:32 +02:00
Enrico Weigelt, metux IT consult
8cf54c5f6c randr: fix missing includes of extinit.h
Don't rely on this file just being included indirectly by somebody else
just by accident.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 13:48:21 +02:00
Enrico Weigelt, metux IT consult
8e2c1ad714 glx: fix missing includes of extinit.h
Don't rely on this file just being included indirectly by somebody else
just by accident.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-25 13:48:08 +02:00