Enrico Weigelt, metux IT consult
7e22c033d0
xnest: fix naming of xnestCursorScreenKeyRec
...
It's naming is a bit unprecise: it actually is used for storing
xnestCursorFuncPtr inside a Screen. Thus rename it to
xnestScreenCursorFuncKeyRec to make it bit more clear.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1342 >
2024-03-12 15:24:35 +00:00
Enrico Weigelt, metux IT consult
22306f16b6
xnest: drop superfluous xnestCursorScreenKey define
...
We can just write &xnestCursorScreenKeyRec instead, which makes the code
a bit more clear.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1342 >
2024-03-12 15:24:35 +00:00
Enrico Weigelt, metux IT consult
7f13fc7d2f
dix: unexport callback manager init / teardown functions
...
Those are only needed inside DIX, thus no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1346 >
2024-03-12 15:18:17 +00:00
Enrico Weigelt, metux IT consult
8f2894c4d0
include: unexport xserver_poll.h
...
It doesn't seem to have any exported functions, so doesn't need to be
exported to the public module API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1352 >
2024-03-12 15:01:35 +00:00
Enrico Weigelt, metux IT consult
738edd3501
dix: unexport eventconvert.h functions
...
This header isn't installed, so no external modules could use the
functions declared there. Thus we can unexport it all.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1358 >
2024-03-11 12:26:44 +01:00
Enrico Weigelt, metux IT consult
2a5e754275
dix: unexport SetAccelerationProfile()
...
Not used by any module, just locally within one source file, thus
unexport and make it static
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1347 >
2024-03-09 18:01:52 +00:00
Enrico Weigelt, metux IT consult
1b983d7e82
dix: unexport FreeVelocityData()
...
Only used within one source, not used by external modules, thus unexport
and make it static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1347 >
2024-03-09 18:01:52 +00:00
Enrico Weigelt, metux IT consult
9d3766080b
dix: unexport BasicComputeAcceleration()
...
only used locally within one source file, so unexport and make it static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1347 >
2024-03-09 18:01:52 +00:00
Enrico Weigelt, metux IT consult
a09f2540d2
dix: unexport ProcessVelocityData2D()
...
Only used with on source file, so unexport and make it static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1347 >
2024-03-09 18:01:52 +00:00
Enrico Weigelt, metux IT consult
b598727f1c
dix: unexport InitTrackers()
...
Not used by any modules, thus no need to export it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1347 >
2024-03-09 18:01:52 +00:00
Enrico Weigelt, metux IT consult
4db1f3f760
dix: unexport InitVelocityData()
...
Not used by any modules, not even outside the source file, thus
no need to export it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1347 >
2024-03-09 18:01:52 +00:00
Enrico Weigelt, metux IT consult
a3ebe4fa41
dix: move non-exported ptrveloc functions to separate header
...
unclutter ptrveloc.h by moving non-exported declarations into their own
private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1347 >
2024-03-09 18:01:52 +00:00
Enrico Weigelt, metux IT consult
c66eaf431c
include: dont install glx_extinit.h
...
This header isn't included by any (known) driver/module and doesn't export
any functions, thus no need to install it anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1361 >
2024-03-09 17:57:25 +00:00
Enrico Weigelt, metux IT consult
02ba47f09d
os: move out Format*() functions
...
Move out the Format*() functions to separate source and header.
These aren't exported, thus no module API change.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1312 >
2024-03-09 17:34:51 +00:00
Enrico Weigelt, metux IT consult
040e41c7e9
dix: unexport global variables
...
Those aren't used by drivers, so no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1375 >
2024-03-09 17:23:43 +00:00
Enrico Weigelt, metux IT consult
30b403b0f0
os: unexport Fopen(), Fclose(), Popen(), Pclose(), System()
...
These functions are just used for reading auth file or calling xkbcomp while
dropping privileges, in case the Xserver is started as unprivileged user
with suid-root. Thus, shouldn't be used (and aren't used) by drivers.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1370 >
2024-03-09 17:18:46 +00:00
Enrico Weigelt, metux IT consult
15d3c1a6f1
os: move os_move_fd() out of public API
...
This function isn't used by any driver and doesn't seem to be useful for them,
thus move it out of the public module API, in order to tidy it up a bit.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1366 >
2024-03-09 17:12:46 +00:00
Enrico Weigelt, metux IT consult
1bdbe1cb3f
os: fix missing X11/Xdefs.h include in os/osdep.h
...
osdep.h needs Bool type, which is defined X11/Xdefs.h.
For now it works, since Xdefs usually is already included somewhere
else, but that's an unreliable programming styles which quickly hits
us when changing include order.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1366 >
2024-03-09 17:12:46 +00:00
Enrico Weigelt, metux IT consult
159bb1c33d
mi: drop some dead code
...
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1363 >
2024-03-09 17:07:28 +00:00
Enrico Weigelt, metux IT consult
934b771f7a
os: unexport AutoResetServer()
...
This is an internal function, not used and not supposed to be used by
any drivers, so shouldn't have been exported in the first place.
Fixes: 49f77fff14
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1372 >
2024-03-07 23:10:17 +00:00
Enrico Weigelt, metux IT consult
b1ce5543f1
dix: unexport workqueue functions
...
These aren't used by drivers, so no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1376 >
2024-03-07 22:57:53 +00:00
Michel Dänzer
64341c479c
xwayland/present: Handle clearing damage after flip in xwl_present_execute
...
Due to DamageReportNonEmpty, damage_report doesn't get called if the
damage region was already non-empty before the flip. In which case it
didn't get called before the first draw after the flip either.
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1627
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314 >
2024-03-06 17:33:54 +01:00
Michel Dänzer
6b290fa5d9
xwayland: Replace window pixmap as needed for drawing operation
...
We must not modify the contents of a client pixmap.
If there's an available window buffer, we re-use that for the window
pixmap. Otherwise we just allocate a new one.
This also avoids Present client hangs due to xwl_present_buffer_release
not getting called for the buffer release event.
v2:
* Use xwl_pixmap_get_buffer_release_cb instead of keeping track of the
flip pixmap in xwl_window.
* Dispose of xwl_window_buffer in xwl_window_swap_pixmap called from
damage_report.
v3:
* Use xwl_window->surface_pixmap in damage_report.
v4:
* Don't re-use client pixmaps as window buffers.
* Clear xwl_window_buffer->pixmap before calling
xwl_window_buffer_maybe_dispose in xwl_window_swap_pixmap, to prevent
it from clearing the buffer release callback.
v5:
* Keep using xwl_window_buffers_get_pixmap in xwl_window_attach_buffer.
* Always keep a reference to the old window pixmap in _swap_pixmap,
drop it in damage_report.
Fixes: 6779ec5bf6 ("xwayland: Use window pixmap as a window buffer")
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1633
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1644
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314 >
2024-03-06 17:12:54 +01:00
Michel Dänzer
0e29cccf36
xwayland: Re-use xwl_window_realloc_pixmap in xwl_window_swap_pixmap
...
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314 >
2024-03-06 17:09:22 +01:00
Michel Dänzer
44527c2549
xwayland: Refactor xwl_window_swap_pixmap out of _buffers_get_pixmap
...
There will be another caller in a later commit.
v2:
* Bump xwl_window_buffer->refcnt in xwl_window_swap_pixmap, to prevent
xwl_window_set_pixmap from disposing of it.
v3:
* Go back to bumping xwl_window_buffer->refcnt in
xwl_window_buffers_get_pixmap. xwl_window_set_pixmap should no longer
dispose of it now that xwl_glamor_gbm_create_pixmap_for_window is
fixed, and xwl_window_swap_pixmap forgot to bump it if
xwl_window_buffer_get_available returned NULL.
v4:
* Unlink xwl_window_buffer from xwl_window->window_buffers_available
before calling xwl_window_set_pixmap in xwl_window_swap_pixmap, or
that might dispose of it.
v5:
* xwl_window_swap_pixmap does everything xwl_window_buffer_get_available
did before, except for just using the window pixmap if
!xwl_glamor_needs_n_buffering.
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314 >
2024-03-06 16:58:17 +01:00
Michel Dänzer
af4b64d227
xwayland: Rename xwl_window_recycle_pixmap to xwl_window_realloc_pixmap
...
It doesn't recycle anything but allocates a new pixmap from scratch.
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314 >
2024-03-06 16:55:13 +01:00
Michel Dänzer
716805e3ad
xwayland: Call xwl_window_buffer_add_damage_region from damage_report
...
Before clearing the damage region. Otherwise the damage region from a
Present flip may be ignored when replacing the window pixmap.
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314 >
2024-03-06 16:55:13 +01:00
Michel Dänzer
c1c5bf382e
xwayland: Do not plumb damage region through function parameters
...
Each function can get the damage region from the xwl_window instead.
Add xwl_window_get_damage_region helper for this.
v2:
* Use xwl_window_get_damage_region in xwl_window_attach_buffer as well
(Olivier Fourdan)
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314 >
2024-03-06 16:55:13 +01:00
Michel Dänzer
913631071e
xwayland: Use border width in xwl_glamor_gbm_create_pixmap_for_window
...
Otherwise the pixmap is too small for a window with non-0 border width.
Fixes: 9730fb64ea ("xwayland: Add create_pixmap_for_window() to GBM backend")
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1314 >
2024-03-06 16:55:13 +01:00
Enrico Weigelt, metux IT consult
53a0442b87
drop remains of DMX
...
DMX has long gone, but there's still some fallout from it's removal
yet to be cleaned up.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1362 >
2024-03-05 16:57:52 +01:00
Olivier Fourdan
a692ded3d9
build: Xwayland with GLAMOR requires libxshmfence
...
Without libxshmfence, Xwayland cannot build with GLAMOR support.
Make sure to catch that requirement in meson rather than failing the
build later.
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com >
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1626
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1253 >
2024-03-03 23:29:40 +00:00
Olivier Fourdan
2ebde20eef
build: Use a variable for the xshmfence version
...
No functional change.
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1253 >
2024-03-03 23:29:40 +00:00
Enrico Weigelt, metux IT consult
6999bc49d3
dix: unexport AttachOffloadGPU() and DetachOffloadGPU()
...
These aren't externally used, thus no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1349 >
2024-03-03 23:24:29 +00:00
Enrico Weigelt, metux IT consult
1277bb7143
dix: unexport AttachOutputGPU() and DetachOutputGPU()
...
These aren't externally used, thus no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1349 >
2024-03-03 23:24:28 +00:00
Enrico Weigelt, metux IT consult
71b81a7473
dix: unexport AttachUnboundGPU() and DetachUnboundGPU()
...
These aren't externally used, thus no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1349 >
2024-03-03 23:24:28 +00:00
Enrico Weigelt, metux IT consult
55dc4a8bdc
dix: unexport RemoveGPUScreen()
...
This function isn't used by any modules/drivers, so no need to export it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1349 >
2024-03-03 23:24:28 +00:00
Enrico Weigelt, metux IT consult
27b83c4cd0
dix: unexport AddScreen() and AddGPUScreen()
...
These aren't used by any drivers/modules, just DDX'es, so no need to export.
Note: tigervnc does use it, but it has it's own DDX, therefore directly
linked in, just like the in-tree DDX'es which doesn't need exporting.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1349 >
2024-03-03 23:24:28 +00:00
Enrico Weigelt, metux IT consult
dc84331f5d
include: drop obsolete registry.h
...
Now that there's no actual consumer of it left, it can be dropped.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1348 >
2024-03-03 23:20:06 +00:00
Enrico Weigelt, metux IT consult
17ad53c803
include: unexport registry.h
...
This file isn't included by any known modules, so no need to keep it
around in the public api.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1348 >
2024-03-03 23:20:06 +00:00
Enrico Weigelt, metux IT consult
5f5d55be88
dix: unexport XREGISTRY_UNKNOWN define
...
It's not used by external modules, thus no need to have it in the
public API.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1348 >
2024-03-03 23:20:06 +00:00
Enrico Weigelt, metux IT consult
4ebb02cdda
dix: unexport extension registry functions
...
These aren't used by (known) external modules, thus no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1348 >
2024-03-03 23:20:06 +00:00
Enrico Weigelt, metux IT consult
1f5ab6ec28
dix: unexport RegisterResourceName() and LookupResourceName()
...
These aren't used by external modules, thus no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1348 >
2024-03-03 23:20:06 +00:00
Enrico Weigelt, metux IT consult
36e2cf64c8
dix: unexport registry setup/teardown functions
...
these aren't to be called by modules, thus no need to export them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1348 >
2024-03-03 23:20:06 +00:00
Enrico Weigelt, metux IT consult
c3255fbc1c
os: drop unneeded DDXOSVERRORF conditional
...
This conditional practically only controls whether we have an pointer,
where DDX can plug in it's own VErrorF() handler (currently only xwin
doing that). The cost of having it even when DDX doesn't use it, is
really negligible: it's just one pointer and an extra non-null check
on it per VErrorF() call - a very cold path. Strangely, xwin has extra
Getting rid of this unnecessary complexity that really hasn't any
practical gain.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1329 >
2024-03-03 23:15:14 +00:00
Enrico Weigelt, metux IT consult
40c5d39c55
include: move xsha1.h to os/
...
This header is never exported and belongs to OS layer, thus no need to have it
in include/ directory, where all the public ones are - better off under os/.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1350 >
2024-03-03 23:11:05 +00:00
Enrico Weigelt, metux IT consult
ebabca56a4
consolidate MITSHM and HAS_SHM symbols
...
Both symbols are set on exactly the same condition (build_mitshm),
so can be consolidated into one: MITSHM
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1296 >
2024-03-03 23:07:18 +00:00
Enrico Weigelt, metux IT consult
77f9792911
os: simplify win32 uname()
...
Just define struct utsname and a tiny uname() function instead of
cluttering the code with ifdef's.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1295 >
2024-03-03 23:02:54 +00:00
Enrico Weigelt, metux IT consult
02b5696e2b
xwin: winsock.h needs to be included earlier
...
[374/383] Compiling C object hw/xwin/Xming.exe.p/winmultiwindowicons.c.obj
791In file included from /usr/i686-w64-mingw32/include/X11/Xwinsock.h:57,
792 from /usr/i686-w64-mingw32/include/xcb/xcb_windefs.h:34,
793 from /usr/i686-w64-mingw32/include/xcb/xcb.h:41,
794 from ../hw/xwin/winmultiwindowicons.c:43:
795/usr/share/mingw-w64/include/winsock2.h:15:2: warning: #warning Please include winsock2.h before windows.h [-Wcpp]
796 15 | #warning Please include winsock2.h before windows.h
797 | ^~~~~~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1295 >
2024-03-03 23:02:54 +00:00
Enrico Weigelt, metux IT consult
7bd19a9580
xwin: replace ZeroMemory()
...
replace Windows specific ZeroMemory (macro just calling memset())
by static initialization, calloc() and memset().
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1295 >
2024-03-03 23:02:54 +00:00
Enrico Weigelt, metux IT consult
c444223da3
xwin: fix missing prototype for winValidateArgs()
...
[378/383] Compiling C object hw/xwin/Xming.exe.p/winvalargs.c.obj
811../hw/xwin/winvalargs.c:57:1: warning: no previous prototype for ‘winValidateArgs’ [-Wmissing-prototypes]
812 57 | winValidateArgs(void)
813 | ^~~~~~~~~~~~~~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1295 >
2024-03-03 23:02:54 +00:00