Check for rpcbuf error and return BadAlloc then, otherwise return Success.
This way, callers don't need to check their rpcbuf for error on their own
anymore, but can just do return X_SEND_REPLY_WITH_RPCBUF(...).
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Use x_rpcbuf_t for reply payload assembly, and sending out the whole
thing via X_SEND_REPLY_WITH_RPCBUF().
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
It is patch 1/7 of a series that provides a convenient way to specify
IgnoreABI and module search paths on a per-driver basis.
It adds #ifdef CONFIG_LEGACY_NVIDIA_PADDING wherever it should be but
is missed.
Signed-off-by: Oleh Nykyforchyn <oleh.nyk@gmail.com>
Since we're already statically initializing the reply header anyways,
use the default case values here and overwrite them only when requested
version is lower than server's one.
That code path is so cold (at max only called once per client), we really
don't need to care whether there's any chance for saving a few cycles.
So not trying to be clever, but instead focus on readability.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
The keyboard input driver that will be added to kdrive
only works with old SIGIO code, and doesn't work with
the new threaded input that kdrive uses.
All the code is behind #if's that are never satisfied,
so this commit has no functional changes.
In preparation for adding the Xfbdev X11 kdrive server.
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
The keyboard input driver that will be added to kdrive
only works with old SIGIO code, and doesn't work with
the new threaded input that kdrive uses.
All the code is behind #if's that are never satisfied,
so this commit has no functional changes.
In preparation for adding the Xfbdev X11 kdrive server.
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
All the code if behind #if's that are never satisfied,
so this commit has no functional changes.
In preparation for adding the Xfbdev X11 kdrive server.
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
Add definitions for the forward declarations from the previous commit
In preparation for adding the Xfbdev X11 kdrive server
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
There are some forward declarations with no definitions in kdrive.h
This doesn't cause a problem right now and makes it easier
to break up the large Xfbdev pr.
In preparation for adding the Xfbdev X11 kdrive server
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
In preparation for adding the Xfbdev X11 kdrive server
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
and new versions of the proprietary nvidia DDX driver
The 470 driver expects older abi, while the 570 driver
uses different code at runtime depending of the abi version.
This commit tells the new nvdia driver to use the older
abi that the 470 driver expects.
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
Commit 3cb3024fea removed pScratchPixmap field
in ScreenRec, which broke legacy Nvidia (proprietary) drivers (470.x), thus
we should add an empty/dummy field here, to ensure correct padding. But this
would break ABI again - can't do that within minor release line.
As compromise, adding a *build time* option CONFIG_LEGACY_NVIDIA_PADDING for
this, so operators/packagers can opt-in to this change.
As it breaks ABI, the option is disabled by default until the next major release
and intended for EXPERTS ONLY who need nvidia390 or nvidia470 drivers.
Note that ALL DRIVERS should be rebuild if it is applied!
This compile-time option, along with the hacks needed to support it
in a non-abi-breaking way, should be droppen in the next major release.
Co-authored-by: Oleh Nykyforchyn <oleh.nyk@gmail.com>
Signed-off-by: Oleh Nykyforchyn <oleh.nyk@gmail.com>
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
