Enrico Weigelt, metux IT consult
6789b911c4
render: picturestr.h: re-add compat macros for intel driver
...
The ancient pict_f_vector and pixman_f_vector macros have been a fallout
from long ago transition to pixman and had been removed quite a while ago.
Unfortunately, Intel driver (which is not under our reign) hasn't been
kept up to date yet. So re-adding the compat macro, until Intel driver
team had a chance to keep up.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1778 >
2025-02-11 09:53:59 +01:00
Aki Sakurai
3562298068
xquartz: fix inverted tablet pen Y tilt on macOS
...
On macOS, the y tilt behavior is inverted; an increase in the tilt
value corresponds to tilting the device away from the user.
see https://chromium-review.googlesource.com/c/chromium/src/+/2348544
see 0f128fd7c5/src/plugins/platforms/cocoa/qnsview_tablet.mm (L63)
Fixes #792
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1779 >
2025-02-10 22:02:16 +08:00
Aki Sakurai
da0de21b72
xquartz: fix compilation
...
Fixes #1788
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1777 >
2025-02-10 19:37:18 +08:00
Spiky Caterpillar
2631cad85d
No longer leak FDs on VT switch.
...
Modified-by: Povilas Kanapickas <povilas@radix.lt >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/997 >
2025-02-08 17:38:20 +02:00
Randy Palamar
5677de586f
os/osinit: fix build when execinfo.h is missing
...
HAVE_BACKTRACE gets set on systems with libunwind however
execinfo.h may be missing (on *BSD or musl for example).
HAVE_EXECINFO_H has been defined by the build system for a long
time but previously not used.
Signed-off-by: Randy Palamar <randy@rnpnr.xyz >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1207 >
2025-02-08 15:22:29 +00:00
Enrico Weigelt, metux IT consult
143a6a21e1
miext: rootless: fix unused variables
...
Compiling w/ -Werror (which our CI does) breaks compile due a buch of
unused variables.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1703 >
2025-02-08 15:15:57 +00:00
Enrico Weigelt, metux IT consult
6ee163cb94
mi: miexpose: fix FTBS w/ rootless helper
...
FTBS when rootless subsys enabled:
> ../mi/miexpose.c: In function ‘miPaintWindow’:
> ../mi/miexpose.c:411:15: error: unused variable ‘orig_pWin’ [-Werror=unused-variable]
> 411 | WindowPtr orig_pWin = pWin;
> | ^~~~~~~~~
> cc1: all warnings being treated as errors
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1703 >
2025-02-08 15:15:57 +00:00
Enrico Weigelt, metux IT consult
bcbc7479f3
xfree86: common: use LogMessageVerb() instead of xf86Msg()
...
Both are doing same job, so no need to keep using an duplicated implementation.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1681 >
2025-02-07 22:40:06 +00:00
Enrico Weigelt, metux IT consult
5fd918421a
xfree86: fbdevhw: use LogMessageVerb() instead of xf86Msg()
...
Both are doing same job, so no need to keep using an duplicated implementation.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1681 >
2025-02-07 22:40:06 +00:00
Enrico Weigelt, metux IT consult
4ba0cf1f55
xfree86: os-support: use LogMessageVerb() instead of xf86Msg()
...
Both are doing same job, so no need to keep using an duplicated implementation.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1681 >
2025-02-07 22:40:06 +00:00
Enrico Weigelt, metux IT consult
1f93ec5c33
xfree86: i2c: use LogMessageVerb() instead of xf86Msg()
...
Both are doing same job, so no need to keep using an duplicated implementation.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1681 >
2025-02-07 22:40:06 +00:00
Enrico Weigelt, metux IT consult
76874498be
glx: use LogMessageVerb() instead of xf86Msg()
...
Both are doing same job, so no need to keep using an duplicated implementation.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1681 >
2025-02-07 22:40:06 +00:00
Enrico Weigelt, metux IT consult
6fc4f35f62
xfree86: use LogMessageVerb() instead of xf86MsgVerb()
...
Both are doing same job, so no need to keep using an duplicated implementation.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1681 >
2025-02-07 22:40:06 +00:00
Enrico Weigelt, metux IT consult
8e8bf63908
os: move AbortServer() to os/utils.c
...
This function doesn't much to do with logging, except for being
called once by FatalError(). It's better placed in utils.c
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1678 >
2025-02-07 18:45:35 +01:00
Ivaylo Dimitrov
579eb31222
linux: Fix BUS_PLATFORM detection for non-PCI devices
...
Commit 74b7427c41 (linux: Make platform device probe less fragile)
effectively dropped busid detection for non-PCI devices, for example on
OMAP we have "ID_PATH=platform-omapdrm.0". For such devices busid will not
be set, making platform probes (and server mediated fd support) impossible.
Fix that by extending config_udev_odev_setup_attribs() logic to support
platform devices as well.
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1761 >
2025-02-07 15:10:17 +00:00
Doug Johnson
e0588d2110
os: backtrace: Fix -Wincompatible-pointer-types compiler error on 32-bit targets
...
```
../os/backtrace.c: In function ‘print_registers’:
../os/backtrace.c:94:52: error: passing argument 3 of ‘_ULarm_get_reg’ from incompatible pointer type [-Wincompatible-pointer-types]
94 | ret = unw_get_reg(&cursor, regs[i].regnum, &val);
| ^~~~
| |
| uint64_t * {aka long long unsigned int *}
```
Switched to libunwind's un_word_t type and PRIxPTR fprintf fmt specification
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1763 >
2025-02-07 16:58:02 +02:00
Enrico Weigelt, metux IT consult
4f2c6c98b7
xfree86: mark LoaderShouldIgnoreABI() and LoaderGetABIVersion() deprecated
...
These functions are only used by the proprietary NVidia drivers,
so keeping them only for backwards compat. Nobody else should ever
really need them.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1773 >
2025-02-07 14:46:21 +01:00
Enrico Weigelt, metux IT consult
13a16de310
Revert "xfree86: loader: drop unused LoaderShouldIgnoreABI()"
...
This reverts commit d8c47a3db6 .
Proprietary NVidia driver needs it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1773 >
2025-02-07 14:46:21 +01:00
Enrico Weigelt, metux IT consult
ea118d3897
Revert "xfree86: loader: drop unused LoaderGetABIVersion()"
...
This reverts commit f3887956ec .
Proprietary NVidia drivers still needs it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1773 >
2025-02-07 14:46:21 +01:00
Enrico Weigelt, metux IT consult
e3cbde9914
include: unexport no*Extension flags
...
Most of these flags aren't used by any drivers, so no need to keep them
exported. Only three exceptions: composite, Panoramix/Xinerama and Xv.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1519 >
2025-02-07 12:00:58 +01:00
Enrico Weigelt, metux IT consult
356e18dcc6
os: move out extension disable flags to corresponing extensions
...
The OS abstraction isn't really the right place for those flags,
they are're probably better off in their corresponding extensions.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1519 >
2025-02-07 12:00:53 +01:00
Enrico Weigelt, metux IT consult
8539f35818
Revert "xv: unexport XvScreenRec and XvScreenPtr"
...
This reverts commit 58a2fb8b6f .
Needed by xf86-video-intel driver. Didn't get noticed, because we don't
have this driver in our CI yet.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1772 >
2025-02-07 10:08:41 +01:00
Enrico Weigelt, metux IT consult
37dd2897d4
Xext: saver: consolidate (non-)xinerama versions
...
We can make it a bit simpler by doing the request header
checking only once.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591 >
2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
8236ef3b56
Xext: saver: use explicit switch/case for dispatching
...
It's more robust / easier understandable programming style to use explicit
switch statements, case'ing on the constants defined in the protocol header,
instead of implicitly via a some opaque call table. It's also done this
way in the other extensions, so making the code a bit more consistent.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591 >
2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
40469a9d51
Xext: saver: skip unneeded zero init and zero-swapping
...
When using struct initializers, all fields not set explicitly are zero.
Also no need to swap fields that are known to be zero.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591 >
2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
fdb8c8ea41
Xext: saver: fix missing swap in QueryVersion reply
...
The `majorVersion` and `minorVersion` fields are CARD16, thus need to be swapped.
OTOH, the lengths field is zero anyways, so no need to swap it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591 >
2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
1efb2151e3
xfree86: sdksyms.sh: add more headers
...
Add some headers that are still needed by drivers.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
cf03948572
xfree86: move private definitions out of dri.h
...
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
1d3c26446d
xfree86: move private definitions out of dri2.h
...
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
00c2a8fb0a
xfree86: ddc: move private definitions from xf86DDC.h to xf86DDC_priv.h
...
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
d4724009ce
xfree86: parser: move private defs from xf86Parser.h to xf86Parser_priv.h
...
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
ac5e95be49
xfree86: modes: move private definitions out of from xf86RandR12.h
...
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
013eaacdd0
xfree86: common: move private defs out of xf86VGAarbiter.h
...
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
df33e1c51b
xfree86: common: move private defs from xf86Xinput.h to xf86Xinput_priv.h
...
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
a0eea4e0ec
xfree86: int10: move private defs out of xf86int10.h
...
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
50d1a98c6a
xfree86: common: move private defs out of xf86sbusBus.h
...
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290 >
2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
f4eb217f11
os: log: replace VErrorF() by LogVMessageVerb()
...
Since LogVMessageVerb() is now signal safe, we can use this one instead.
Leaving VErrorF() macro for backwards compat with drivers.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691 >
2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
9652bc73e2
xwin: drop duplicate OsVendorVErrorF()
...
It really doesn't seem to be necessary to protect a LogVMessageVerb()
call by extra mutex on windows only, while obviously not needed on
any other platform.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691 >
2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
da22bc9ae0
os: log: replace VErrorFSigSafe() by VErrorF()
...
Since VErrorF() is now signal safe, we can use this one instead.
Leaving VErrorFSigSafe() macro for backwards compat with drivers.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691 >
2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
2d18c353b4
os: log: replace ErrorFSigSafe() by ErrorF()
...
Since ErrorF() is now signal safe, we can use this one instead.
Leaving ErrorFSigSafe() macro for backwards compat with drivers.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691 >
2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
dd37cc4855
os: log: replace LogMessageVerbSigSafe() by LogMessageVerb()
...
Since LogMessageVerb() is now signal safe, we can use this one instead.
Leaving LogMessageVerbSigSafe() macro for backwards compat with drivers.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691 >
2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
5962211612
os: log: make LogVMessageVerb() signal safe
...
We already have our own signal safe vnsprintf() implementation, which is used
for formatting log messages while being in a signal handler, there's no need
to have two separate implementations of all the logging functions.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691 >
2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
71b8953597
os: log: consolidate log formatting functions
...
Simplify log formatting functions and remove redundancies, e.g.:
* common function for line termination
* copy prefix directly instead of *printf'ing it
* now just exactly one LogSWrite() call per message
(good for other log targets like syslog)
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691 >
2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
f5fe8a6379
os: log: drop unused variables
...
Drop some unneeded variabes, whose values can be computed at compile-time.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691 >
2025-02-06 23:35:26 +00:00
Enrico Weigelt, metux IT consult
a33639f975
xvmc: move over protocol version defines into xvmc.c
...
These are exclusively used in one source file, so no need to keep them
in a global header.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1693 >
2025-02-06 23:29:10 +00:00
Enrico Weigelt, metux IT consult
171db3b01b
meson: drop defining BIGREQS
...
This symbol isn't used for decades, so no need to define it at all.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1700 >
2025-02-06 23:22:31 +00:00
Enrico Weigelt, metux IT consult
4235d2375a
xfree86: vgahw: drop obsolete vgaHWSaveScreenWeak()
...
No callers left, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
be9b89ef0f
xfree86: vgahw: drop obsolete vgaHWDisable()
...
No callers left, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
bb0295b397
xfree86: vgahw: drop obsolete vgaHWSetRegCounts
...
No callers left, so no need to keep it around anymore.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
515d19806c
xfree86: vgahw: make vgaHWSaveColormap() static
...
No external callers anymore, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724 >
2025-02-06 23:15:40 +00:00