Commit Graph

21838 Commits

Author SHA1 Message Date
Enrico Weigelt, metux IT consult
5e38615365 randr: inline byte-swapping into actual request handlers
No need to have whole extra functions for just a few LoC, and in the
future the whole thing will become more simplified by generic macros.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 12:35:03 +02:00
Enrico Weigelt, metux IT consult
b2a85f070d xwin: dri: inline byte-swapping
No need for having extra functions and redundant code when it can
be done with just few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 12:34:42 +02:00
Enrico Weigelt, metux IT consult
9a2dc644b7 xquartz: applewm: drop redundant dispatcher for swapped case
There's nothing actually do be done by the swapped dispatcher, the
original already does everything on its own.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:24:43 +02:00
Enrico Weigelt, metux IT consult
9353255c9d xquartz: appledri: inline byte-swapping
No need for having lots of extra functions and redundant dispatcher,
when it can be done by directly inlining those few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:24:28 +02:00
Enrico Weigelt, metux IT consult
8e68c8d514 dix: replace XACE_CLIENT_ACCESS by direct callback
Move the callbacks directly into DIX, since it's actually core infrastructure.
Also simplifying the whole machinery, by just using a simpel CallbackListPtr.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:24:13 +02:00
Enrico Weigelt, metux IT consult
3851c97247 xv: drop forgotten SProcXvDispatch() prototype
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:23:48 +02:00
Enrico Weigelt, metux IT consult
8a5ac961ca Xvmc: inline SProcXvMCDispatch()
No need for an extra function for a one-liner.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:23:36 +02:00
Enrico Weigelt, metux IT consult
3bec112cf1 dix: drop obsolete SProcSimpleReq()
This function is really doing nothing except of calling into the
actual request handler, so not needed at all.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:23:21 +02:00
Enrico Weigelt, metux IT consult
6731d7643a render: consolidate byte-swapping in ProcRenderFreePicture()
No need for extra functions and call tables for the few trivial lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:22:15 +02:00
Enrico Weigelt, metux IT consult
07ac2c2c99 Xi: inline SProcXGrabDeviceButton()
No need to have a hole bunch of extra functions, if we can just easily
inline the few relevant lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:22:03 +02:00
Enrico Weigelt, metux IT consult
2c657eb932 xkb: inline SProcXkbPerClientFlags()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:21:50 +02:00
Enrico Weigelt, metux IT consult
6df2a9a01a xkb: inline SProcXkbSetDebuggingFlags()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:21:35 +02:00
Enrico Weigelt, metux IT consult
d497375eaa xkb: inline SProcXkbGetState()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:21:19 +02:00
Enrico Weigelt, metux IT consult
25bd1d3b69 xkb: inline SProcXkbSetControls()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:20:02 +02:00
Enrico Weigelt, metux IT consult
3e9c40015f xkb: inline SProcXkbSetNamedIndicator()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:19:47 +02:00
Enrico Weigelt, metux IT consult
a5796a80f8 xkb: inline SProcXkbGetIndicatorMap()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:19:33 +02:00
Enrico Weigelt, metux IT consult
175dbe3661 Xi: inline SProcXIQueryDevice()
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:19:10 +02:00
Enrico Weigelt, metux IT consult
829595da02 Xi: inline SProcXIGetFocus() and SProcXISetFocus()
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:17:57 +02:00
Enrico Weigelt, metux IT consult
338f8c0b06 xquartz: prepare DarwinAdjustScreenOrigins() for new screen iterators
* the pScreenInfo isn't needed: we're always getting global screenInfo
  passed in here (there's only one, globally, anyways)
* use the common iterator variable names
* handle first and auxillary screens all in the same loop
  (we can just branch by idx)

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:10:01 +02:00
Enrico Weigelt, metux IT consult
4a75fb14b7 os: unexport ReplyCallback
It's only used by record extension, not used by any drivers at all
(neither FOSS nor proprietary), so it shouldn't be in the public SDK.

Since it's never been used by any driver, it's effectively no ABI change,
so we can safely do this within ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:05:27 +02:00
Enrico Weigelt, metux IT consult
ca484055c7 dix: unexport screen saver parameters
Not used by any external drivers, so no need to keep them in public
SDK headers. Since they're never used by drivers, it's effectively
not an ABI change, so can safely be done within ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 11:01:21 +02:00
Enrico Weigelt, metux IT consult
cb85ceae2d glx: use DeleteCallbackList() for callback list destruction
We already have a function for callback list deletion, so use this one
instead of doing it manually.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 10:53:27 +02:00
Enrico Weigelt, metux IT consult
21fb27735a os: unexport XNFreallocarray()
Not used by any drivers, no no need to keep it in public SDK.
Since it's not used by drivers, it's effectively not an ABI change,
so can be done within ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 10:53:15 +02:00
Enrico Weigelt, metux IT consult
8cd201d89a dix: unexport ResourceStateCallback (not used by drivers)
Only used by Xselinux extension, not by any drivers, so no need to
keep it exported.

Since it's never been used by drivers at all, it's effectively no ABI change,
so can safely be done within ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-29 10:34:35 +02:00
Enrico Weigelt, metux IT consult
f29fb6bb62 present: unexport symbols not used by drivers
these symbols aren't used by any external drivers (not even proprietary
Nvidia), so no need to keep them exported any longer:

 * present_check_flips
 * present_register_complete_notify
 * present_can_window_flip
 * uint32_t FakeScreenFps

Since it's not any *effective* ABI change, can go into current ABI-25 line.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 17:09:43 +02:00
Enrico Weigelt, metux IT consult
0e723d3b1e xfree86: xv: fix missed hooking of WindowDestroy
Forgot to register window destroy hook - that's leading to crash:

    https://github.com/X11Libre/xserver/issues/959

Fixes: b60581e393
Bug: https://github.com/X11Libre/xserver/issues/959
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 17:04:56 +02:00
Enrico Weigelt, metux IT consult
1439fc7aa1 render: fix missing include in glyphstr.h
Need to include renderproto.h

Closes: https://github.com/X11Libre/xserver/issues/700
Reported-By: Kevin Kofler <kevin@tigcc.ticalc.org>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 16:45:16 +02:00
Enrico Weigelt, metux IT consult
f333cac5c2 Xext: namespace: fix NULL derefence on client close
Removing the namespace assignment of killed clients in ClientState-hook
is too early - we still need it later. Using the new ClientDestroyCallback
instead.

Closes: https://github.com/X11Libre/xserver/issues/486
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 16:28:17 +02:00
stefan11111
2c3d96e3ca composite: add a comment
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
2025-09-26 16:06:14 +02:00
stefan11111
2ab2454151 composite: Only copy bits from the parent pixmap when absolutely necessary
Since 1e728c3e88 ,
Whenever we allocate a composite pixmap, we perform an expensive CopyArea call from the parent pixmap.

This leads to very bad performance when not using a framebuffer driver without shadowfb.

My guess is that this call ends up reading memory from the framebuffer memory directly, which is very slow.

Fixes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1814

Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
2025-09-26 16:06:14 +02:00
Enrico Weigelt, metux IT consult
74e3f18204 os: unexport inSignalContext
Only used inside OS layer and xfree86 os-support, so no need to keep
it in public SDK.

Since never used by any drivers, it's not an actual ABI change, so
we can safely do it within ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:58:04 +02:00
Enrico Weigelt, metux IT consult
caa3e1685a xfree86: dga: drop unnecessary swapped request handler
The request handler already refusing non-local access, so no need
for any extra swapped handler.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:57:13 +02:00
Enrico Weigelt, metux IT consult
9d1f0a555d xfree86: dri: drop unnecessary swapped request handler
The request handler already refusing non-local access, so no need
for any extra swapped handler.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:57:01 +02:00
Enrico Weigelt, metux IT consult
995398ecde os: rename audit.h to audit_priv.h
Our convention is naming private (non-SDK) headers w/ _priv.h suffix.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:56:47 +02:00
Enrico Weigelt, metux IT consult
b6945455bf render: consolidate byte-swapping in ProcRenderFreeGlyphs()
No need for extra functions and call tables for the few trivial lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:56:34 +02:00
Enrico Weigelt, metux IT consult
7afa753652 Xext: drop PanoramiXGCKey and PanoramiXScreenKey macros
We can directly use the actual fields, no need for these extra macros.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:38:07 +02:00
Enrico Weigelt, metux IT consult
6d00346893 Xext: xv: drop XvScreenKey macro
We can easily use &XvScreenKeyRec directly.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 15:35:25 +02:00
Enrico Weigelt, metux IT consult
da42cb968c os: move LogPrintMarkers() declaration into private header
Not exported, not used by any external modules, so no need to have
that declaration in a public SDK header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:50:59 +02:00
sesankm
79d092cfb9 glx: glxcmds: use rpcbuf to build xGLXGetDrawableAttributesReply payload
Signed-off-by: sesankm <26676400+sesankm@users.noreply.github.com>
2025-09-26 11:50:39 +02:00
sesankm
9d6094442a dix: rpcbuf: export x_rpcbuf_write_CARD32s for glx
Signed-off-by: sesankm <26676400+sesankm@users.noreply.github.com>
2025-09-26 11:50:39 +02:00
Enrico Weigelt, metux IT consult
da1509c364 render: consolidate byte-swapping in ProcRenderAddGlyphs()
No need for extra functions and call tables for the few trivial lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:49:18 +02:00
Enrico Weigelt, metux IT consult
56830521c1 render: consolidate byte-swapping in ProcRenderSetPictureClipRectangle()
No need for extra functions and call tables for the few trivial lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:49:10 +02:00
Enrico Weigelt, metux IT consult
3f5fdfc615 Xi: inline SProcXGrabDeviceKey()
No need to have a hole bunch of extra functions, if we can just easily
inline the few relevant lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:49:06 +02:00
Enrico Weigelt, metux IT consult
0c40403eb7 Xi: inline SProcXChangeDeviceDontPropagateList()
No need to have a hole bunch of extra functions, if we can just easily
inline the few relevant lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:48:27 +02:00
Enrico Weigelt, metux IT consult
71133d6502 Xi: inline SProcXSendExtensionEvent()
No need to have a hole bunch of extra functions, if we can just easily
inline the few relevant lines.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:48:16 +02:00
Enrico Weigelt, metux IT consult
3ddf48f3c6 dbe: replace dbeScreenPrivKey and dbeWindowPrivKey macros
No need for the extra macros, we can just use the corresponding
structs directly.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:47:28 +02:00
Enrico Weigelt, metux IT consult
16c0f1dfb8 dix: move struct _WorkQueue definition into dixutil.c
It's only used inside dixutil.c, nowhere else, especially not drivers,
so no need to keep it in public SDK. Safe for ABI-25.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:47:15 +02:00
Enrico Weigelt, metux IT consult
6cb3338c0b xkb: inline SProcXkbUseExtension()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:47:04 +02:00
Enrico Weigelt, metux IT consult
8daa5bc8b9 xkb: inline SProcXkbBell()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:46:50 +02:00
Enrico Weigelt, metux IT consult
8d100100af xkb: inline SProcXkbGetControls()
No need to have whole extra functions for just a few LoC.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-09-26 11:46:38 +02:00