Enrico Weigelt, metux IT consult
2e6f3a632b
meson.build: enable VLA warning
...
variable length arrays can be dangerous, so better don't use
them at all.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1819 >
2025-02-20 17:28:05 +01:00
Enrico Weigelt, metux IT consult
b4f0c1abd5
test: sync: don't use VLA
...
The array size is fixed anyways, so we can use a symbol instead
of variable.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1819 >
2025-02-20 17:28:01 +01:00
Enrico Weigelt, metux IT consult
f894801fa2
xfree86: modesetting: don't use VLA
...
even through this specific case is correct and safe, it's safer to
remove all VLA usages and forbid them completely by compiler flag.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1819 >
2025-02-20 17:26:49 +01:00
Doug Brown
a0834009cf
dri2: Protect against dri2ClientPrivate assertion failures
...
If DRI2ScreenInit hasn't been called yet, DRI2Authenticate and
DRI2CreateDrawable2 cause the X server to crash. This has been observed
to happen on multiple modern Linux distros in various conditions,
including QEMU and VMware VMs. Make these functions more robust in order
to prevent the crash.
This patch was originally provided by Bernhard Übelacker and expanded
upon by Mark Wagner.
Signed-off-by: Doug Brown <doug@schmorgal.com >
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1053
Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1534
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1608 >
2025-02-19 11:25:01 +00:00
Enrico Weigelt, metux IT consult
6c88eb0cc4
misc.h: unexport compare_version()
...
Not used by any external modules, so no need to keep it in public header.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1807 >
2025-02-18 11:17:40 +00:00
Enrico Weigelt, metux IT consult
804b2c081b
os: unexport CloseWellKnownConnections()
...
Not used by any modules, so no need to keep it public.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00
Enrico Weigelt, metux IT consult
0d95b53a20
os: unexport ResetWellKnownSockets()
...
Not used by any modules (and not supposed to be), so should not
be exported at all.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00
Enrico Weigelt, metux IT consult
dd05532b38
os: unexport CreateWellKnownSockets()
...
Not used by any modules (and not supposed to be), so should not
be exported at all.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00
Enrico Weigelt, metux IT consult
59b39ee6ee
os: unexport NotifyParentProcess()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00
Enrico Weigelt, metux IT consult
c9ee4245a2
os: unexport ResetOsBuffers()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00
Enrico Weigelt, metux IT consult
583dbe832d
os: unexport FlushIfCriticalOutputPending()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00
Enrico Weigelt, metux IT consult
be16616715
os: unexport FlushAllOutput()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00
Enrico Weigelt, metux IT consult
c6b223459c
os: unexport ResetCurrentRequest()
...
Not used by any external modules, so no need to keep it in public API.
Since it's used by DRI, still needs the _X_EXPORT flag, as long as DRI
is a dynamically loaded module.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00
Enrico Weigelt, metux IT consult
189a70dfb2
os: unexport InsertFakeRequest()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
ba665948f6
os: unexport WriteFdToClient()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
effe8d66bd
os: unexport ReadRequestFromClient()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
9b0c3c62f2
os: unexport ListenOnOpenFD()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
d637e1d284
os: unexport AddClientOnOpenFD()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
a84ae08526
os: unexport ClientAuthorized()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
c6b8207342
os: unexport AuthorizationIDOfClient()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
1f27d3d653
os: unexport ClientIsLocal()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
6ec89c91f3
ci: update freebsd builder image
...
FreeBSD upstream removed image for 14.0 image, so we need to update.
Also increasing image size, since the new images are too small.
(needs update of ci-templates)
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1784 >
2025-02-18 10:43:28 +01:00
Enrico Weigelt, metux IT consult
80f5d29c84
xfree86: doc: update docs on XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
e88762896e
xfree86: inputtest: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
2a10eff6c5
xfree86: modsetting: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
c8ad9c6567
xfree86: exa: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
c862cf3c3a
xfree86: fbdevhw: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
d87e93bf40
xfree86: xf86int10module: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
f54993a222
xfree86: xfbmodule: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
a2e20304e0
xfree86: vgaHWmodule: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
3066125bec
xfree86: shmodule: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
f0590decb6
xfree86: sfbmodule: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
03becba76b
xfree86: glxmodule: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
7dd8d0627c
xfree86: fbmodule: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:30 +00:00
Enrico Weigelt, metux IT consult
c46e645bad
glamor: use explicit field initializers for XF86ModuleData
...
Even though the order of these fields shouldn't change anytime
soon, it's still better programming style to name'em explicitly.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:29 +00:00
Enrico Weigelt, metux IT consult
1848027892
xfree86: xf86configure: use NULL instead of 0
...
Zero pointers should be initialized w/ NULL instead of raw 0.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1788 >
2025-02-17 19:41:29 +00:00
Enrico Weigelt, metux IT consult
346d5f5c35
os: move BUG_*() macros to own private header
...
These macros aren't used by any external modules, so no need
to keep them public. Moving them into private header.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1804 >
2025-02-17 19:32:48 +00:00
Enrico Weigelt, metux IT consult
a6b2eb3780
misc.h: drop LengthRestB() macro
...
Only used at exactly one place, for trivial size computation, so not worth
having an extra macro in a public header for this.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1805 >
2025-02-17 19:25:14 +00:00
Alan Coopersmith
9af363b046
ci: update XTS to a commit that doesn't require -fcommon workaround
...
xorg/test/xts!10 fixed XTS to build with recent gcc without adding -fcommon
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1786 >
2025-02-17 19:16:04 +00:00
Enrico Weigelt, metux IT consult
f209ac2014
doc: drop removed PaintWindowBackground() and PaintWindowBorder()
...
These have been removed 1.5 decades ago.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1785 >
2025-02-17 19:05:55 +00:00
Enrico Weigelt, metux IT consult
f4d878086e
Xext: selinux: use static reply struct init on declaration
...
Make the code a bit easier to read by using initialization of the reply
structs, at the point of declaration. Most of them aren't written to later,
just passed into WriteReplyToClient(). Also dropping some useless zero
assignments (struct initializers automatically zero-out unmentioned fields).
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1795 >
2025-02-17 18:58:10 +00:00
Enrico Weigelt, metux IT consult
94d942267a
dri: report failed memory allocation
...
ProcXF86DRIGetDrawableInfo() should report failed memory allocation instead
of pretending everything's okay.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1797 >
2025-02-17 18:50:25 +00:00
Enrico Weigelt, metux IT consult
2539ddae50
modsetting: also add libglx to library symbol test
...
Increase test coverage a bit.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1798 >
2025-02-17 18:42:52 +00:00
Enrico Weigelt, metux IT consult
e10283d842
xfree86: os-support: unexport xf86scanpci()
...
Not used by any drivers/modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1800 >
2025-02-17 18:35:43 +00:00
Enrico Weigelt, metux IT consult
b3ec0bf58a
dix: unexport MakePredeclaredAtoms()
...
Should never be called by modules/drivers.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1802 >
2025-02-17 18:13:33 +00:00
Enrico Weigelt, metux IT consult
9dc26f6743
os: no need to defined PATH_MAX
...
All our supported platforms define it, so no need to do
it on our own.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1803 >
2025-02-17 16:55:13 +01:00
Enrico Weigelt, metux IT consult
6c24e53a89
os: drop upstart specific SIGSTOP signaling logic
...
Upstart is long dead, discontinued a decade ago, so there's no
need to keep around a special signaling logic just for it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1791 >
2025-02-14 14:25:28 +01:00
Enrico Weigelt, metux IT consult
6349773d5e
mi: (re)export and document miPointerInitialize()
...
Xrdp project request exporting this function again, because (unlike the
usual xf86-video-* drivers) they need their own custom cursor handling:
RDP is designed to draw cursors on client side.
Also documenting what the function does.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1787 >
2025-02-13 23:53:39 +00:00
Andy Myers
7933cc24d0
xvfb: Add multiple CRTC support
...
Multiple CRTCs can be added on a per-screen basis with the new -crtcs
option. Each CRTC has one associated output. Outputs beyond the first
are disabled by default and can be enabled by setting a mode. Outputs
can be disabled again by setting the associated CRTC's mode and output
to None.
Signed-off-by: Andy Myers <andy.myers@zetier.com >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1749 >
2025-02-13 23:22:49 +00:00
Enrico Weigelt, metux IT consult
b61647f3a1
dix: add in-code docs for dixDestroyPixmap()
...
Give some more explaination for the dixDestroyPixmap() function.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1711 >
2025-02-12 17:48:30 +01:00