XLibre/xserver
1
1
Fork 0
mirror of https://github.com/X11Libre/xserver.git synced 2026-03-24 21:41:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
19,200 Commits 314 Branches 33 Tags
submit/cleanup-shm-dispatch
Commit Graph

19200 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Enrico Weigelt, metux IT consult
75ce7c6be0 Xext: shm: drop duplicate call to SetReqFd 
Not necessary to call it in SProcShmAttachFd(), it's already done
in ProcShmAttach(), which is called by this function anyways.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
 2025-02-07 15:22:55 +01:00
Enrico Weigelt, metux IT consult
a074d3e3f2 Xext: shm: move client local check into procs 
Move extra complexity out of the dispatch functions, so they're
really just switch/case statements calling the actual handler procs.
Preparation for further steps.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
 2025-02-07 15:22:55 +01:00
Enrico Weigelt, metux IT consult
b2fb40edf4 Xext: shm: simplify dispatcher 
These dispatcher functions are much more complex than they're usually are
(just switch/case statement). Bring them in line with the standard scheme
used in the Xserver, so further steps become easier.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
 2025-02-07 15:22:55 +01:00
Enrico Weigelt, metux IT consult
e3cbde9914 include: unexport no*Extension flags 
Most of these flags aren't used by any drivers, so no need to keep them
exported. Only three exceptions: composite, Panoramix/Xinerama and Xv.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1519>
 2025-02-07 12:00:58 +01:00
Enrico Weigelt, metux IT consult
356e18dcc6 os: move out extension disable flags to corresponing extensions 
The OS abstraction isn't really the right place for those flags,
they are're probably better off in their corresponding extensions.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1519>
 2025-02-07 12:00:53 +01:00
Enrico Weigelt, metux IT consult
8539f35818 Revert "xv: unexport XvScreenRec and XvScreenPtr" 
This reverts commit 58a2fb8b6f.

Needed by xf86-video-intel driver. Didn't get noticed, because we don't
have this driver in our CI yet.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1772>
 2025-02-07 10:08:41 +01:00
Enrico Weigelt, metux IT consult
37dd2897d4 Xext: saver: consolidate (non-)xinerama versions 
We can make it a bit simpler by doing the request header
checking only once.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591>
 2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
8236ef3b56 Xext: saver: use explicit switch/case for dispatching 
It's more robust / easier understandable programming style to use explicit
switch statements, case'ing on the constants defined in the protocol header,
instead of implicitly via a some opaque call table. It's also done this
way in the other extensions, so making the code a bit more consistent.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591>
 2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
40469a9d51 Xext: saver: skip unneeded zero init and zero-swapping 
When using struct initializers, all fields not set explicitly are zero.
Also no need to swap fields that are known to be zero.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591>
 2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
fdb8c8ea41 Xext: saver: fix missing swap in QueryVersion reply 
The `majorVersion` and `minorVersion` fields are CARD16, thus need to be swapped.
OTOH, the lengths field is zero anyways, so no need to swap it.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591>
 2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
1efb2151e3 xfree86: sdksyms.sh: add more headers 
Add some headers that are still needed by drivers.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
cf03948572 xfree86: move private definitions out of dri.h 
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
1d3c26446d xfree86: move private definitions out of dri2.h 
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
00c2a8fb0a xfree86: ddc: move private definitions from xf86DDC.h to xf86DDC_priv.h 
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
d4724009ce xfree86: parser: move private defs from xf86Parser.h to xf86Parser_priv.h 
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
ac5e95be49 xfree86: modes: move private definitions out of from xf86RandR12.h 
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
013eaacdd0 xfree86: common: move private defs out of xf86VGAarbiter.h 
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
df33e1c51b xfree86: common: move private defs from xf86Xinput.h to xf86Xinput_priv.h 
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
a0eea4e0ec xfree86: int10: move private defs out of xf86int10.h 
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
50d1a98c6a xfree86: common: move private defs out of xf86sbusBus.h 
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
 2025-02-06 23:51:33 +00:00
Enrico Weigelt, metux IT consult
f4eb217f11 os: log: replace VErrorF() by LogVMessageVerb() 
Since LogVMessageVerb() is now signal safe, we can use this one instead.
Leaving VErrorF() macro for backwards compat with drivers.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691>
 2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
9652bc73e2 xwin: drop duplicate OsVendorVErrorF() 
It really doesn't seem to be necessary to protect a LogVMessageVerb()
call by extra mutex on windows only, while obviously not needed on
any other platform.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691>
 2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
da22bc9ae0 os: log: replace VErrorFSigSafe() by VErrorF() 
Since VErrorF() is now signal safe, we can use this one instead.
Leaving VErrorFSigSafe() macro for backwards compat with drivers.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691>
 2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
2d18c353b4 os: log: replace ErrorFSigSafe() by ErrorF() 
Since ErrorF() is now signal safe, we can use this one instead.
Leaving ErrorFSigSafe() macro for backwards compat with drivers.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691>
 2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
dd37cc4855 os: log: replace LogMessageVerbSigSafe() by LogMessageVerb() 
Since LogMessageVerb() is now signal safe, we can use this one instead.
Leaving LogMessageVerbSigSafe() macro for backwards compat with drivers.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691>
 2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
5962211612 os: log: make LogVMessageVerb() signal safe 
We already have our own signal safe vnsprintf() implementation, which is used
for formatting log messages while being in a signal handler, there's no need
to have two separate implementations of all the logging functions.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691>
 2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
71b8953597 os: log: consolidate log formatting functions 
Simplify log formatting functions and remove redundancies, e.g.:

* common function for line termination
* copy prefix directly instead of *printf'ing it
* now just exactly one LogSWrite() call per message
  (good for other log targets like syslog)

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691>
 2025-02-06 23:35:27 +00:00
Enrico Weigelt, metux IT consult
f5fe8a6379 os: log: drop unused variables 
Drop some unneeded variabes, whose values can be computed at compile-time.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1691>
 2025-02-06 23:35:26 +00:00
Enrico Weigelt, metux IT consult
a33639f975 xvmc: move over protocol version defines into xvmc.c 
These are exclusively used in one source file, so no need to keep them
in a global header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1693>
 2025-02-06 23:29:10 +00:00
Enrico Weigelt, metux IT consult
171db3b01b meson: drop defining BIGREQS 
This symbol isn't used for decades, so no need to define it at all.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1700>
 2025-02-06 23:22:31 +00:00
Enrico Weigelt, metux IT consult
4235d2375a xfree86: vgahw: drop obsolete vgaHWSaveScreenWeak() 
No callers left, so no need to keep it around anymore.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724>
 2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
be9b89ef0f xfree86: vgahw: drop obsolete vgaHWDisable() 
No callers left, so no need to keep it around anymore.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724>
 2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
bb0295b397 xfree86: vgahw: drop obsolete vgaHWSetRegCounts 
No callers left, so no need to keep it around anymore.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724>
 2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
515d19806c xfree86: vgahw: make vgaHWSaveColormap() static 
No external callers anymore, so no need to keep it exported.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724>
 2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
79522220a6 xfree86: vgahw: make vgaHWSaveMode() static 
No external callers left, so no need to keep it exported.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724>
 2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
f004998b78 xfree86: vgaha: make vgaHWRestoreColormap() static 
No external callers left, so no need to keep it exported.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724>
 2025-02-06 23:15:40 +00:00
Enrico Weigelt, metux IT consult
30380cb207 xfree86: vgahw: make vgaHWRestoreMode() static 
No external callers anymore, so no need to keep it exported.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724>
 2025-02-06 23:15:39 +00:00
Enrico Weigelt, metux IT consult
cd2457412f xfree86: vgahw: drop obsolete vgaHWBlankScreenWeak() 
Not used anymore, so no need to keep it around any longer.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724>
 2025-02-06 23:15:39 +00:00
Enrico Weigelt, metux IT consult
a415e6ed37 xfree86: vgahw: drop obsolete vgaHWProtectWeak() 
Not used anymore, so no need to keep it around any longer.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1724>
 2025-02-06 23:15:39 +00:00
Enrico Weigelt, metux IT consult
00f69564c5 xfree86: common: unexport UnloadModule() and UnloadSubModule() 
Not used by any driver/module, so no need to keep it exported.
Also making them type-safe.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1722>
 2025-02-06 23:09:02 +00:00
Enrico Weigelt, metux IT consult
b0452ecff4 xfree86: drop obsolete macro INITARGS 
This macro isn't used anymore for 12 years now, see commit:

    5079db78ae

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1722>
 2025-02-06 23:09:02 +00:00
Enrico Weigelt, metux IT consult
f3887956ec xfree86: loader: drop unused LoaderGetABIVersion() 
This function isn't called anywhere, neither in xserver nor modules, thus no
need to keep it around.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1722>
 2025-02-06 23:09:02 +00:00
Enrico Weigelt, metux IT consult
d8c47a3db6 xfree86: loader: drop unused LoaderShouldIgnoreABI() 
This function isn't called anywhere, neither in xserver nor modules, thus no
need to keep it around.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1722>
 2025-02-06 23:09:02 +00:00
Enrico Weigelt, metux IT consult
24d693c5ae dix: make dixDestroyPixmap() NULL-proof 
Make dixDestroyPixmap() check for NULL pointer, so callers don't need to
do it anymore. Returning TRUE on NULL pointer - but most callers won't
even look at the retval anyways.

Together with subsequent commits, which will make use of that function,
instead of calling raw ScreenRec->DestroyPixmap vectors, this gives us some
more freedom for architectural changes, eg. get rid of the extremely
complicated and fragile wrapping chains.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1709>
 2025-02-06 23:02:06 +00:00
Enrico Weigelt, metux IT consult
ef62929f58 treewide: NULL-protect ScreenRec->DestroyPixmap() calls 
Right now, we're assuming that even when deep nesting involved, the proc
vector is always set to a valid function. One the one hand it requires
extra dummy procs in some cases, OTOH it's making upcoming refactoring
of the code flow unnecessarily complex.

The big plot (of subsequent commits) is splitting out the extension's
(and possibly subsystem's) special logic out of the wrapping chain and
let them be executed independently from the DDX/drivers - when applicable
even only when the pixmap is really destroyed (not just unref'ed).
(At some later point, it might even become be actually a valid situation
that DestroyPixmap vector really being NULL.)

See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1754
See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1755

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1709>
 2025-02-06 23:02:06 +00:00
Enrico Weigelt, metux IT consult
af2d3e9487 xnest: drop obsolete mi.h include 
Since moving to mi_priv.h, we don't need to include mi.h here.

Fixes: 94451181c2
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1725>
 2025-02-06 22:53:43 +00:00
Enrico Weigelt, metux IT consult
f8fc46cbbf include: drop now empty xkbfile.h 
This (public) file isn't used by anybody outside Xserver tree
and doesn't contain anything useful anymore, so lets drop it.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1729>
 2025-02-06 22:45:25 +00:00
Enrico Weigelt, metux IT consult
3f8a5475c9 xkb: unexport remaining internal declarations 
These are only used inside xkb/*, so no need to keep them exported.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1729>
 2025-02-06 22:45:25 +00:00
Enrico Weigelt, metux IT consult
660657a2c3 xkb: unexport functions from xkbout.c 
These are only used inside xkb/*, so no need to keep them exported.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1729>
 2025-02-06 22:45:25 +00:00
Enrico Weigelt, metux IT consult
5d98664ec1 xkb: unexport functions from xkbfmisc.c 
These are only used inside xkb/*, so no need to keep them exported.

Also replacing some macros by inline functions in order to improve
type-safety and debugging, and adding documentation.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1729>
 2025-02-06 22:45:25 +00:00