XLibre/xserver
1
1
Fork 0
mirror of https://github.com/X11Libre/xserver.git synced 2026-03-24 08:04:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Xext: xv: ProcXvQueryPortAttributes(): use x_rpcbuf_t for payload assembly

Browse Source 
Using x_rpcbuf_t for assembling any byte-swapping the reply payload.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This commit is contained in:
Enrico Weigelt, metux IT consult
2025-07-17 22:55:01 +02:00
committed by Enrico Weigelt
parent 7368f6f605
commit 29963d878f
1 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
Xext/xvdisp.c
View File

@@ -563,7 +563,7 @@ ProcXvQueryBestSize(ClientPtr client)
static int
ProcXvQueryPortAttributes(ClientPtr client)
{
int size, i;
int i;
XvPortPtr pPort;
XvAttributePtr pAtt;
@@ -572,6 +572,8 @@ ProcXvQueryPortAttributes(ClientPtr client)
VALIDATE_XV_PORT(stuff->port, pPort, DixGetAttrAccess);
x_rpcbuf_t rpcbuf = { .swapped = client->swapped, .err_clear = TRUE };
size_t textSize = 0;
for (i = 0, pAtt = pPort->pAdaptor->pAttributes;
i < pPort->pAdaptor->nAttributes; i++, pAtt++) {
@@ -594,29 +596,20 @@ ProcXvQueryPortAttributes(ClientPtr client)
swapl(&rep.text_size);
}
WriteToClient(client, sz_xvQueryPortAttributesReply, &rep);
for (i = 0, pAtt = pPort->pAdaptor->pAttributes;
i < pPort->pAdaptor->nAttributes; i++, pAtt++) {
size = strlen(pAtt->name) + 1; /* pass the NULL */
xvAttributeInfo Info = {
.flags = pAtt->flags,
.min = pAtt->min_value,
.max = pAtt->max_value,
.size = pad_to_int32(size)
};
if (client->swapped) {
swapl(&Info.flags);
swapl(&Info.size);
swapl(&Info.min);
swapl(&Info.max);
}
WriteToClient(client, sz_xvAttributeInfo, &Info);
WriteToClient(client, size, pAtt->name);
x_rpcbuf_write_CARD32(&rpcbuf, pAtt->flags);
x_rpcbuf_write_CARD32(&rpcbuf, pAtt->min_value);
x_rpcbuf_write_CARD32(&rpcbuf, pAtt->max_value);
x_rpcbuf_write_CARD32(&rpcbuf, pad_to_int32(strlen(pAtt->name)+1)); /* pass the NULL */
x_rpcbuf_write_string_n_pad(&rpcbuf, pAtt->name);
}
if (rpcbuf.error)
return BadAlloc;
WriteToClient(client, sizeof(rep), &rep);
WriteRpcbufToClient(client, &rpcbuf);
return Success;
}