XLibre/xf86-video-nv
1
0
Fork 0
mirror of https://github.com/X11Libre/xf86-video-nv.git synced 2026-03-24 01:24:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

riva_hw.c: Ensure ABS macro expands correctly

Browse Source 
Handles warning from Oracle Parfait static analyser:

Error: Misleading macro
   Misleading macro [misleading-macro]:
      misleading evaluation of unary '-' operator in expansion of macro ABS due to missing parentheses
        at line 104 of src/riva_hw.c.
        binary '+' operator has lower precedence than unary '-' operator inside macro body at line 298
        if (ABS(ainfo->vburst_size) + (ABS(ainfo->wcvlwm + 32) & ~0xf)  - tmp> VFIFO_SIZE)
        low precedence binary '+' operator is hidden by expansion of macro argument a at line 104
	#define	ABS(a)	(a>0?a:-a)

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
This commit is contained in:
Alan Coopersmith
2024-01-26 09:27:20 -08:00
parent eff27e0d6a
commit c8ab8f7868
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/riva_hw.c
View File

@@ -101,7 +101,7 @@ static int ShowHideCursor
#define GFIFO_SIZE_128 256
#define MFIFO_SIZE 120
#define VFIFO_SIZE 256
#define ABS(a) (a>0?a:-a)
#define ABS(a) ((a) > 0 ? (a) : -(a))
typedef struct {
int gdrain_rate;
int vdrain_rate;