Traditionally they've been defined in Xorg server headers, but since this
driver seems to be the only consumer, it makes sense moving them here.
(and later drop them from xorg headers)
Explicitly guarding it, so it also works with xorg headers version still
carrying those symbols.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-chips/-/merge_requests/6>
The Xorg headers provide their own versions of strlcat, strlcpy, and
timingsafe_memcmp for platforms that don't have them in libc yet, but
rely on configure to set HAVE_* defines to determine if they should be
defined in the headers.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
../common/scoasm.h didn't even exist, so this would have broken the
build if it was ever set
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
ct_driver.c: In function ‘chipsPreInitHiQV’:
ct_driver.c:1928:21: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
1928 | if ((pMon = xf86PrintEDID(xf86DoEDID_DDC2(XF86_SCRN_ARG(pScrn),
| ^~
ct_driver.c:1931:24: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
1931 | xf86SetDDCproperties(pScrn,pMon);
| ^~~~~~~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Clears autoconf warning:
configure.ac:107: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
./lib/autoconf/lang.m4:199: AC_LANG_CONFTEST is expanded from...
./lib/autoconf/general.m4:2892: _AC_LINK_IFELSE is expanded from...
./lib/autoconf/general.m4:2909: AC_LINK_IFELSE is expanded from...
configure.ac:107: the top level
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008,
so it's time to rely on it.
Clears autoconf warnings:
configure.ac:44: warning: The macro 'AC_PROG_LIBTOOL' is obsolete.
configure.ac:44: You should run autoupdate.
aclocal.m4:3515: AC_PROG_LIBTOOL is expanded from...
configure.ac:44: the top level
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Bug fix release to address non-HiQVideo Chips & Technologies device
initialization code crashing the X Server.
Signed-off-by: Kevin Brace <kevinbrace@gmx.com>
Unfortunately, commit 989cf4f1fb
missed inserting a call to vgaHWSetStdFuncs prior to calling
vgaHWGetIOBase for non-HiQ Video devices, so this will cause a crash
with the X Server. The code has three different chipsPreInit* to
handle some aspects of a PreInit callback, but only chipsPreInitHiQV
function has the correct code. Added the call to vgaHWSetStdFuncs
for chipsPreInit655xx and chipsPreInitWingine functions. This bug
was observed on Chips & Technologies 65548.
Signed-off-by: Kevin Brace <kevinbrace@gmx.com>
Was missed when it was created in commit c421f2477c, since
"make distcheck" passes due to configure determining it can't
build the utils without the header and moving on.
Reported-by: Andreas Radke <a.radke@arcor.de>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
