mirror of
https://github.com/X11Libre/xf86-video-ati.git
synced 2026-03-24 01:24:43 +00:00
0058fd2ebf4c900b12f129984e98886a7ac84b2f
radeon_do_pageflip() indexed the flipdata->fb[] array
indexing over config->num_crtc, but the flip completion
routines, e.g., drmmode_flip_handler(), index that array
via the crtc hw id from drmmode_get_crtc_id(crtc).
This is mismatched and causes indexing into the wrong
array slot at flip completion -> Server crash.
Always use drmmode_get_crtc_id(crtc) for indexing into
the array to fix this.
Tested on a dual-X-Screen setup with one video output
assigned to each X-Screen, page-flipping an OpenGL app
on either of both X-Screens. This used to crash when
flipping on X-Screen 1, now it doesn't anymore.
Fixes: 740f0850f1 "Store FB for each CRTC in drmmode_flipdata_rec"
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
xf86-video-ati - ATI/AMD Radeon video driver for the Xorg X server
Patches and questions regarding this software should be directed at the amd-gfx mailing list:
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Please submit bug reports to the Xorg bugzilla:
https://bugs.freedesktop.org/enter_bug.cgi?product=xorg&component=Driver/Radeon
The master development code repository can be found at:
https://gitlab.freedesktop.org/xorg/driver/xf86-video-ati
For patch submission instructions, see:
https://www.x.org/wiki/Development/Documentation/SubmittingPatches
Description
Languages
C
99.3%
M4
0.3%
Makefile
0.2%
Perl
0.1%