Commit Graph

174 Commits

Author SHA1 Message Date
Enrico Weigelt, metux IT consult
2d163a5f00 configure.ac: tiny cleanup
move up the substitution of "moduledir" to right after it was defined.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-12-09 15:33:21 +01:00
Enrico Weigelt, metux IT consult
3b59929ae9 configure.ac: drop obsolete xserver extension checks
No need to checks whose result aren't looked at.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-12-09 15:31:37 +01:00
Enrico Weigelt, metux IT consult
680fc8bfee configure.ac: fix package name
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-12-09 15:29:05 +01:00
Enrico Weigelt, metux IT consult
bbf3ea5b36 configure.ac: fix bug tracker URL
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-12-09 15:28:21 +01:00
Enrico Weigelt, metux IT consult
c1068ffc32 .github: enable -Werror on driver build
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-12-09 15:16:26 +01:00
Enrico Weigelt, metux IT consult
26d1297871 MMCTestSingle2_AST2150(): drop unused function
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-12-09 15:14:25 +01:00
Enrico Weigelt, metux IT consult
68a41e6d1e I2CDelay(): drop unused variable
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-12-09 15:13:47 +01:00
Enrico Weigelt, metux IT consult
5751b5cf36 bSetAST1180CRTCReg(): drop unused variables
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-12-09 15:11:51 +01:00
Alan Coopersmith
aa568ffe19 headers: add header guards to files that don't have them yet
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 15:04:53 +01:00
Alan Coopersmith
1be66031a8 ASTSetMode: Handle -Wmaybe-uninitialized warnings
In function ‘vSetStdReg’,
    inlined from ‘ASTSetMode’ at ast_mode.c:522:9:
ast_mode.c:724:10: warning: ‘vgamodeinfo.pStdTableEntry’ may be used
 uninitialized [-Wmaybe-uninitialized]
  724 |     jReg = pStdModePtr->MISC;
      |     ~~~~~^~~~~~~~~~~~~~~~~~~
ast_mode.c: In function ‘ASTSetMode’:
ast_mode.c:496:21: note: ‘vgamodeinfo.pStdTableEntry’ was declared here
  496 |     VBIOS_MODE_INFO vgamodeinfo;
      |                     ^~~~~~~~~~~
In function ‘vSetCRTCReg’,
    inlined from ‘ASTSetMode’ at ast_mode.c:523:9:
ast_mode.c:780:70: warning: ‘vgamodeinfo.pEnhTableEntry’ may be used
 uninitialized [-Wmaybe-uninitialized]
  780 |     if ((pAST->jChipType == AST2500) && (pVGAModeInfo->pEnhTableEntry->Flags & AST2500PreCatchCRT))
      |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
ast_mode.c: In function ‘ASTSetMode’:
ast_mode.c:496:21: note: ‘vgamodeinfo.pEnhTableEntry’ was declared here
  496 |     VBIOS_MODE_INFO vgamodeinfo;
      |                     ^~~~~~~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 15:04:53 +01:00
Alan Coopersmith
daab9776fd ASTDoDDC: Handle 25 -Wmaybe-uninitialized warnings
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 15:04:53 +01:00
Alan Coopersmith
4337e65465 bGetAST1000VGAModeInfo: Fix misleading indentation
ast_mode.c: In function ‘bGetAST1000VGAModeInfo’:
ast_mode.c:647:9: warning: this ‘if’ clause does not guard...
 [-Wmisleading-indentation]
  647 |         if (loop->ulRefreshRate <= ulRefreshRate
      |         ^~
ast_mode.c:650:25: note: ...this statement, but the latter is
 misleadingly indented as if it were guarded by the ‘if’
  650 |                         loop++;
      |                         ^~~~

Fixes: 77e7ac3 ("use same search mode criteria with ast drm driver")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 15:04:53 +01:00
Alan Coopersmith
53c78493f6 ASTProbe: stop leaking memory returned by xf86GetEntityInfo()
Fixes: 7ce3a2b ("Initial code release from ASPEED Technology Inc.")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 15:04:02 +01:00
Alan Coopersmith
284ce0321f CBRTest*: drop unused variable mmiobase
ast_vgatool.c: In function ‘CBRTest_AST2150’:
ast_vgatool.c:1273:10: warning: variable ‘mmiobase’ set but not used
 [-Wunused-but-set-variable]
 1273 |   UCHAR *mmiobase;
      |          ^~~~~~~~
ast_vgatool.c: In function ‘CBRTest’:
ast_vgatool.c:1755:10: warning: variable ‘mmiobase’ set but not used
 [-Wunused-but-set-variable]
 1755 |   UCHAR *mmiobase;
      |          ^~~~~~~~
ast_vgatool.c: In function ‘CBRTest2’:
ast_vgatool.c:1803:10: warning: variable ‘mmiobase’ set but not used
 [-Wunused-but-set-variable]
 1803 |   UCHAR *mmiobase;
      |          ^~~~~~~~

Fixes: 666abcb ("xf86-video-ast-0.93.09")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 14:48:44 +01:00
Alan Coopersmith
a486313172 ASTStopVideo: drop unused variable pAST
ast_driver.c: In function ‘ASTStopVideo’:
ast_driver.c:1800:12: warning: unused variable ‘pAST’ [-Wunused-variable]
 1800 |     ASTPtr pAST = ASTPTR(pScrn);
      |            ^~~~

Fixes: b4466da ("xf86-video-ast-0.92.02")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 14:48:44 +01:00
Alan Coopersmith
70ec6553a3 vInitAST2300DRAMReg: drop unused variable i
ast_vgatool.c: In function ‘vInitAST2300DRAMReg’:
ast_vgatool.c:2887:11: warning: unused variable ‘i’ [-Wunused-variable]
 2887 |     ULONG i, ulTemp;
      |           ^

Fixes: b4466da ("xf86-video-ast-0.92.02")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 14:48:44 +01:00
Alan Coopersmith
f5a67a76da CBRDLL2: drop unused variable data2
ast_vgatool.c: In function 'CBRDLL2':
ast_vgatool.c:2076:43: warning: unused variable ‘data2’ [-Wunused-variable]
 2076 |   ULONG dllmin[2], dllmax[2], dlli, data, data2, passcnt, retry=0;
      |                                           ^~~~~

Fixes: 1e3dbbd ("Modify for DRAM Initial Settings")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 14:48:44 +01:00
Alan Coopersmith
0977fdfd91 finetuneDQSI: drop unused variable cnt
ast_vgatool.c: In function 'finetuneDQSI':
ast_vgatool.c:1974:30: warning: unused variable ‘cnt’ [-Wunused-variable]
 1974 |   ULONG dlli, dqsip, dqidly, cnt;
      |                              ^~~

Fixes: 1e3dbbd ("Modify for DRAM Initial Settings")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 14:48:44 +01:00
Alan Coopersmith
3077cc171d vInitChrontelReg: drop unused variable pEnhModePtr
ast_mode.c: In function 'vInitChrontelReg':
ast_mode.c:1287:28: warning: unused variable 'pEnhModePtr' [-Wunused-variable]
 1287 |     PVBIOS_ENHTABLE_STRUCT pEnhModePtr = pVGAModeInfo->pEnhTableEntry;
      |                            ^~~~~~~~~~~

Fixes: 9e8d848992
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 14:48:44 +01:00
Alan Coopersmith
e4728353b5 ASTSaveScreen: Fix build on SPARC
ast_driver.c: In function ‘ASTSaveScreen’:
ast_driver.c:1257:1: error: no return statement in function returning
 non-void [-Werror=return-type]
 1257 | }
      | ^

Fixes: dc971ee ("fix segmentation fault issue if enable XEN")
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/15>
2025-12-09 14:48:44 +01:00
b-aaz
5c471f61d8 configure: Automatically detect the default xorg-module-dir.
The module directory has changed to a per ABI folder in the xlibre-xserver.
Now the default value of `xorg-module-dir` will be detected from the `moduledir` variable in xorg-server.pc.

Signed-off-by: b-aaz <b-aazbsd.proton.me>
xlibre-xf86-video-ast-1.2.0.1
2025-07-24 20:32:43 +02:00
Enrico Weigelt, metux IT consult
597f318ac2 .github: add CI pipeline
This pipeline builds the driver against the latest Xserver stable
release as well as current master.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-07-24 20:31:45 +02:00
callmetango
e0c4bfcfa3 .github: Add issue forms
Add the following forms for issue creation:

* Bug report
* Feature request
* Code change
* Documentation update
* Organizational task

* add issue type selection page on "New Issue" call
* mention Github Discussions and the mailing list where appropriate

Part-of: X11Libre/misc#156
Signed-off-by: callmetango <callmetango@users.noreply.github.com>
2025-07-07 17:03:02 +02:00
Alan Coopersmith
e86afcc2d1 xf86-video-ast 1.2.0
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
xf86-video-ast-1.2.0
2025-01-05 11:08:08 -08:00
Semenov Herman
426c80e9be Fixed disabled RAMDAC for A1 reg
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/12>
2024-10-06 19:09:16 +03:00
Enrico Weigelt, metux IT consult
db56de34bd drop compat with ancient xservers
We're relying on 1.18 now, so drop compat with older ones.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/11>
2024-05-28 10:30:46 +02:00
Enrico Weigelt, metux IT consult
309e8bf6ca drop obsolete check for REGION_NULL
Our minimal version is known to have it, so no check needed anymore.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/11>
2024-05-22 21:00:06 +02:00
Alan Coopersmith
9f932c7d5e Raise minimum supported Xserver version to 1.18 (ABI_VIDEODRV_VERSION 20.0)
Already effectively required by use of XNFcallocarray() introduced in
xorg/xserver@b96dc999 - xserver-1.18.0, released in Nov. 2015.

Allows dropping remnants of code for XAA and pre-pciaccess X servers

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/9>
2024-05-12 15:55:24 -07:00
Enrico Weigelt, metux IT consult
4b72faa322 use XNFcallocarray() instead of xnfcalloc macro
xnfcalloc is just an alias for XNFcallocarray() that doesn't seem to serve
any practical purpose, so it can go away once all drivers stopped using it.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-video-ast/-/merge_requests/8>
2024-05-08 14:32:06 +02:00
Alan Coopersmith
55a72385a4 Handle a -Wformat warning
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-01-05 18:56:25 -08:00
Alan Coopersmith
2352780cd7 Handle 2 -Wdeclaration-after-statement warnings
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-01-05 18:53:48 -08:00
Alan Coopersmith
70582d8282 Handle 12 -Wmissing-prototypes warnings
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-01-05 18:47:48 -08:00
Alan Coopersmith
338ec0a217 Add X.Org's standard C warning flags to AM_CFLAGS
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-01-05 18:45:12 -08:00
Alan Coopersmith
3262c6e82f configure: Use LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOL
AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008,
so it's time to rely on it.

Clears autoconf warnings:
configure.ac:44: warning: The macro 'AC_PROG_LIBTOOL' is obsolete.
configure.ac:44: You should run autoupdate.
aclocal.m4:3515: AC_PROG_LIBTOOL is expanded from...
configure.ac:44: the top level

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2024-01-05 18:42:31 -08:00
Alan Coopersmith
6558ea686d gitlab CI: ensure libtool is installed in build container
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2023-10-01 12:35:27 -07:00
Alan Coopersmith
7b8c415f42 xf86-video-ast 1.1.6
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
xf86-video-ast-1.1.6
2022-12-08 16:13:56 -08:00
Elyes HAOUAS
4bcb826087 Res1280x800Table: Fix a typo on hexa value.
Replace "... AST2500PreCatchCRT), 60, 2, 35 }"
with "... AST2500PreCatchCRT), 60, 2, 0x35 }"
2022-11-18 15:21:09 -08:00
Daniel O'Connor
0e0fd56d9f Do not hang if P2A is disabled, using sensible defaults instead.
Based on Linux DRM https://patchwork.kernel.org/patch/9578793/
2022-11-10 16:43:54 -08:00
Alan Coopersmith
773f703d92 ast_vgatool: Fix indentation in ASTGetScratchOptions()
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-17 10:53:55 -07:00
Alan Coopersmith
19cf45e2a4 ast_vgatool: Fix -Wold-style-declaration warning
ast_vgatool.c:3400:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
 void static vGetDefaultSettings(ScrnInfoPtr pScrn)
 ^~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-17 10:53:55 -07:00
Alan Coopersmith
065ed43c44 ast_mode: Eliminate unused DAC_TEXT & DAC_EGA arrays
At top level:
ast_mode.c:389:23: warning: ‘DAC_EGA’ defined but not used [-Wunused-variable]
 static VBIOS_DAC_INFO DAC_EGA[] = {
                       ^~~~~~~
ast_mode.c:370:23: warning: ‘DAC_TEXT’ defined but not used [-Wunused-variable]
 static VBIOS_DAC_INFO DAC_TEXT[] = {
                       ^~~~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-17 10:53:55 -07:00
Alan Coopersmith
f9dcbd53e7 WriteAST1180SOC: Add _X_UNUSED attribute to temp variable
Clears 67 out of 84 warnings of the form:

In file included from ast_cursor.c:53:0:
ast_cursor.c: In function ‘ASTLoadCursorImage’:
ast_vgatool.h:149:15: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable]
         ULONG temp; \
               ^
ast_cursor.c:293:9: note: in expansion of macro ‘WriteAST1180SOC’
         WriteAST1180SOC(AST1180_GFX_BASE+AST1180_HWC1_PATTERNADDR, ulPatternAddr);
         ^~~~~~~~~~~~~~~

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-17 10:53:55 -07:00
Alan Coopersmith
8026dbf57d gitlab CI: stop requiring Signed-off-by in commits
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-10-17 10:53:55 -07:00
Alan Coopersmith
7916e2a65c gitlab CI: add a basic build test
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-01-17 15:25:47 -08:00
Alan Coopersmith
b90cfb94d6 Fix spelling/wording issues
Found by using:
    codespell --builtin clear,rare,usage,informal,code,names

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-01-17 15:25:05 -08:00
Alan Coopersmith
0b9cdc9594 Build xz tarballs instead of bzip2
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2022-01-17 15:19:50 -08:00
Alan Coopersmith
72e3f2e3e8 Update configure.ac bug URL for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-25 13:06:17 -08:00
Alan Coopersmith
a87ba3607d Update README for gitlab migration
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2018-11-18 12:14:44 -08:00
Mihail Konev
1dba6ba5a7 autogen: add default patch prefix
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
2017-01-26 14:00:22 +10:00
Emil Velikov
df8a9c009c autogen.sh: use quoted string variables
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2017-01-26 11:26:28 +10:00