The vendor ID 0x06cb is used by HID devices from Synaptics.
Match it to MODEL_SYNAPTICS.
Tested on a Panasonic CF-SV equipped with "Synaptics TM3136-020"
touchpad, which previously uses MODEL_UNKNOWN to calculate edge width
and the result is too narrow.
Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-input-synaptics/-/merge_requests/22>
Recent xserver master moved out the BUG_*() macros from os.h,
causing FTBS on xf86-input-synaptics:
> synaptics.c: In function 'clickpad_guess_clickfingers':
> synaptics.c:2638:5: error: implicit declaration of function 'BUG_RETURN_VAL' [-Werror=implicit-function-declaration]
> 2638 | BUG_RETURN_VAL(hw->num_mt_mask > sizeof(close_point) * 8, 0);
Since that macro is only used once, and that particular case deserves some
more expressive error message anyways, it's trivial doing an explicit
error printout here, instead of having to support the BUG_* macros as
official module API on xserver side forever.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Reported-By: Peter Hutterer <peter.hutterer@who-t.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-input-synaptics/-/merge_requests/12>
eventcomm.c: In function 'EventAutoDevProbe':
eventcomm.c:1045:32: warning: '%s' directive writing up to 255 bytes into a region of size 53 [-Wformat-overflow=]
1045 | sprintf(fname, "%s/%s", DEV_INPUT_EVENT, namelist[i]->d_name);
| ^~
eventcomm.c:1045:13: note: 'sprintf' output between 12 and 267 bytes into a destination of size 64
1045 | sprintf(fname, "%s/%s", DEV_INPUT_EVENT, namelist[i]->d_name);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/driver/xf86-input-synaptics/-/merge_requests/15>
linux-2.6.30 was released 15 years ago - doesn't seem to be necessary
to still support such ancient kernels.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Drops support for ABI_XINPUT_VERSION < 20, including removing support
for driver-side coordinate scaling, since the X server handles it now.
Xserver 1.15 was released in Dec. 2013.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
synclient.c:196:1: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
196 | dp_init()
| ^~~~~~~
synclient.c: In function ‘dp_init’:
synclient.c:196:1: warning: old-style function definition [-Wold-style-definition]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Clears autoconf warnings:
configure.ac:38: warning: The macro 'AC_PROG_LIBTOOL' is obsolete.
configure.ac:38: You should run autoupdate.
aclocal.m4:3515: AC_PROG_LIBTOOL is expanded from...
configure.ac:38: the top level
configure.ac:68: warning: The macro 'AC_HELP_STRING' is obsolete.
configure.ac:68: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:68: the top level
configure.ac:78: warning: The macro 'AC_HELP_STRING' is obsolete.
configure.ac:78: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:78: the top level
libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac,
libtoolize: and rerunning libtoolize and aclocal.
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Most were already converted. Fixes error raised by FlawFinder in CI:
Error: encoding error in ./src/synaptics.c
'utf-8' codec can't decode byte 0xa9 in position 16: invalid start byte
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Otherwise poll() keeps on triggering on our fd until udev gets around to
notifying the server that the device is in some state of deadness. Meanwhile,
the input thread is busy filling the log up with "Read error" messages. Great
way to test file systems and their capacity to handle out of space scenarios
but otherwise a bit pointless. Those FS developers should write their own
tests instead of relying on the synaptics driver!
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Adam Jackson <ajax@redhat.com>
hw.x and the motion history are integers so our deltas are always integers.
It's a bit pointless to split them into the fractional and integral part.
obsolete since defc1d008e or so
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
If opening the fd fails we still need to fail the device. This is particularly
the case when a device disappears before we can open it - the current code
wouldn't exit but instead switch to auto-probe touchpad devices on the system.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
When ignoring modifiers, ensure the touchpad is enabled once a modifier
key is pressed disregarding any previous key press that caused the
touchpad to be disabled.
Signed-off-by: Anton Lindqvist <anton.lindqvist@gmail.com>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Bump up the synaptics driver to 70, so it get's preferred over libinput, which
was dropped down to 60. The synaptics driver is more of a leaf package
than libinput (which covers a multitude of device types) and can be removed by
default. When specifically installed by the user, the synaptics driver should
override the system default.
Similar to what was done for wacom configuration file.
https://bugzilla.suse.com/show_bug.cgi?id=979554
Signed-off-by: Stefan Dirsch <sndirsch@suse.de>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
