XLibre/xf86-input-synaptics
1
0
Fork 0
mirror of https://github.com/X11Libre/xf86-input-synaptics.git synced 2026-03-26 02:38:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove un-used DeviceOn/Off hooks.

Browse Source 
And allow for them to be NULL without crashing the server.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer
2009-04-21 17:07:02 +10:00
parent c09a3d50e9
commit efbc3e98be
5 changed files with 12 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/alpscomm.c
View File

@@ -86,16 +86,6 @@ ALPS_initialize(int fd)
ALPS_sync(fd);
}
static void
ALPSDeviceOnHook(LocalDevicePtr local, SynapticsParameters *para)
{
}
static void
ALPSDeviceOffHook(LocalDevicePtr local)
{
}
static Bool
ALPSQueryHardware(LocalDevicePtr local, struct SynapticsHwInfo *synhw)
{
@@ -260,8 +250,8 @@ ALPSAutoDevProbe(LocalDevicePtr local)
}
struct SynapticsProtocolOperations alps_proto_operations = {
ALPSDeviceOnHook,
ALPSDeviceOffHook,
NULL,
NULL,
ALPSQueryHardware,
ALPSReadHwState,
ALPSAutoDevProbe,

7
src/eventcomm.c
View File

@@ -69,11 +69,6 @@ EventDeviceOnHook(LocalDevicePtr local, SynapticsParameters *para)
}
}
static void
EventDeviceOffHook(LocalDevicePtr local)
{
}
static Bool
event_query_is_touchpad(int fd)
{
@@ -415,7 +410,7 @@ EventAutoDevProbe(LocalDevicePtr local)
struct SynapticsProtocolOperations event_proto_operations = {
EventDeviceOnHook,
EventDeviceOffHook,
NULL,
EventQueryHardware,
EventReadHwState,
EventAutoDevProbe,

8
src/ps2comm.c
View File

@@ -444,12 +444,6 @@ ps2_print_ident(const struct SynapticsHwInfo *synhw)
}
}
static void
PS2DeviceOnHook(LocalDevicePtr local, SynapticsParameters* para)
{
}
static void
PS2DeviceOffHook(LocalDevicePtr local)
{
@@ -756,7 +750,7 @@ PS2AutoDevProbe(LocalDevicePtr local)
}
struct SynapticsProtocolOperations psaux_proto_operations = {
PS2DeviceOnHook,
NULL,
PS2DeviceOffHook,
PS2QueryHardware,
PS2ReadHwState,

14
src/psmcomm.c
View File

@@ -100,16 +100,6 @@ PSMQueryIsSynaptics(LocalDevicePtr local)
}
}
static void
PSMDeviceOnHook(LocalDevicePtr local, SynapticsParameters *para)
{
}
static void
PSMDeviceOffHook(LocalDevicePtr local)
{
}
static void
convert_hw_info(const synapticshw_t *psm_ident, struct SynapticsHwInfo *synhw)
{
@@ -175,8 +165,8 @@ static Bool PSMAutoDevProbe(LocalDevicePtr local)
}
struct SynapticsProtocolOperations psm_proto_operations = {
PSMDeviceOnHook,
PSMDeviceOffHook,
NULL,
NULL,
PSMQueryHardware,
PSMReadHwState,
PSMAutoDevProbe,

9
src/synaptics.c
View File

@@ -700,7 +700,8 @@ DeviceOn(DeviceIntPtr dev)
return !Success;
}
priv->proto_ops->DeviceOnHook(local, &priv->synpara);
if (priv->proto_ops->DeviceOnHook)
priv->proto_ops->DeviceOnHook(local, &priv->synpara);
priv->comm.buffer = XisbNew(local->fd, 64);
if (!priv->comm.buffer) {
@@ -731,7 +732,8 @@ DeviceOff(DeviceIntPtr dev)
TimerFree(priv->timer);
priv->timer = NULL;
xf86RemoveEnabledDevice(local);
priv->proto_ops->DeviceOffHook(local);
if (priv->proto_ops->DeviceOffHook)
priv->proto_ops->DeviceOffHook(local);
if (priv->comm.buffer) {
XisbFree(priv->comm.buffer);
priv->comm.buffer = NULL;
@@ -2191,7 +2193,8 @@ QueryHardware(LocalDevicePtr local)
shm->synhw = priv->synhw;
} else {
xf86Msg(X_PROBED, "%s: no supported touchpad found\n", local->name);
priv->proto_ops->DeviceOffHook(local);
if (priv->proto_ops->DeviceOffHook)
priv->proto_ops->DeviceOffHook(local);
}
return TRUE;