mirror of
https://github.com/X11Libre/xf86-input-evdev.git
synced 2026-03-24 01:34:04 +00:00
evdev: Prevent driver from processing motion events that it has not configured. #21832
The current implementation initializes itself to support relative motion events, or absolute motion events, or neither. But the event-handling code attempts to process all events, no matter what the initialization was. This patch reproduces the flag tests found during init, to skip events that the driver doesn't support. Signed-off-by: Derek Upham <sand@blarg.net> Signed-off-by: Julien Cristau <jcristau@debian.org> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
committed by
Peter Hutterer
parent
dc2191285e
commit
0a3657d2ee
16
src/evdev.c
16
src/evdev.c
@@ -363,6 +363,10 @@ EvdevProcessEvent(InputInfoPtr pInfo, struct input_event *ev)
|
||||
|
||||
switch (ev->type) {
|
||||
case EV_REL:
|
||||
/* Ignore EV_REL events if we never set up for them. */
|
||||
if (!(pEvdev->flags & EVDEV_RELATIVE_EVENTS))
|
||||
break;
|
||||
|
||||
/* Handle mouse wheel emulation */
|
||||
if (EvdevWheelEmuFilterMotion(pInfo, ev))
|
||||
break;
|
||||
@@ -393,6 +397,10 @@ EvdevProcessEvent(InputInfoPtr pInfo, struct input_event *ev)
|
||||
break;
|
||||
|
||||
case EV_ABS:
|
||||
/* Ignore EV_ABS events if we never set up for them. */
|
||||
if (!(pEvdev->flags & EVDEV_ABSOLUTE_EVENTS))
|
||||
break;
|
||||
|
||||
if (ev->code > ABS_MAX)
|
||||
break;
|
||||
pEvdev->vals[pEvdev->axis_map[ev->code]] = value;
|
||||
@@ -1199,9 +1207,13 @@ EvdevInit(DeviceIntPtr device)
|
||||
|
||||
FIXME: somebody volunteer to fix this.
|
||||
*/
|
||||
if (pEvdev->flags & EVDEV_RELATIVE_EVENTS)
|
||||
if (pEvdev->flags & EVDEV_RELATIVE_EVENTS) {
|
||||
EvdevAddRelClass(device);
|
||||
else if (pEvdev->flags & EVDEV_ABSOLUTE_EVENTS)
|
||||
if (pEvdev->flags & EVDEV_ABSOLUTE_EVENTS)
|
||||
xf86Msg(X_INFO,"%s: relative axes found, ignoring absolute "
|
||||
"axes.\n", device->name);
|
||||
pEvdev->flags &= ~EVDEV_ABSOLUTE_EVENTS;
|
||||
} else if (pEvdev->flags & EVDEV_ABSOLUTE_EVENTS)
|
||||
EvdevAddAbsClass(device);
|
||||
|
||||
#ifdef HAVE_PROPERTIES
|
||||
|
||||
Reference in New Issue
Block a user