XLibre/xf86-input-elographics
1
0
Fork 0
mirror of https://github.com/X11Libre/xf86-input-elographics.git synced 2026-03-24 01:34:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bug #9803: Don't allow zero-sized width/height.

Browse Source 
A bad configuration can result in height or width being zero. This potentially
causes a divide-by-zero error in xf86EloConvert().
Detect the bad configuration early on and produce a meaningful error message.

X.Org Bugzilla #9803 <https://bugs.freedesktop.org/show_bug.cgi?id=9803>
This commit is contained in:
Daniel Drake
2007-12-28 16:04:11 +10:30
committed by Peter Hutterer
parent 768c173280
commit e4071358e3
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/xf86Elo.c
View File

@@ -1691,6 +1691,7 @@ xf86EloInit(InputDriverPtr drv,
EloPrivatePtr priv=NULL;
char *str;
int portrait = 0;
int height, width;
local = xf86EloAllocate(drv);
if (!local) {
@@ -1757,11 +1758,21 @@ xf86EloInit(InputDriverPtr drv,
str = "Landscape";
}
xf86Msg(X_CONFIG, "Elographics device will work in %s mode\n", str);
if (priv->max_x - priv->min_x <= 0) {
width = priv->max_x - priv->min_x;
height = priv->max_y - priv->min_y;
if (width == 0) {
xf86Msg(X_ERROR, "Elographics: Cannot configure touchscreen with width 0\n");
return local;
}
else if (width < 0) {
xf86Msg(X_INFO, "Elographics: reverse x mode (minimum x position >= maximum x position)\n");
}
if (priv->max_y - priv->min_y <= 0) {
}
if (height == 0) {
xf86Msg(X_ERROR, "Elographics: Cannot configure touchscreen with height 0\n");
return local;
}
else if (height < 0) {
xf86Msg(X_INFO, "Elographics: reverse y mode (minimum y position >= maximum y position)\n");
}