Olivier Fourdan 57a446c0f9 os: Fix NULL pointer dereference ...

RemoveHost() can be called from DisableLocalHost() with a NULL client,
but doesn't actually check whether the given client pointer is valid on
error and assigns the error value unconditionally, leading to a possible
NULL pointer dereference and a crash of the Xserver.

To avoid the issue, simply check whether the client pointer is not NULL
prior to assign the errorValue.

Closes: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1752
See-also: https://bugzilla.redhat.com/2313799
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1701>

2024-09-23 09:36:52 +02:00

..

.gitignore

…

access.c

os: Fix NULL pointer dereference

2024-09-23 09:36:52 +02:00

alloc.c

os: move alloc functions to separate source file

2024-02-29 10:09:37 +00:00

audit.h

os: unexport audit functions

2024-04-15 19:54:34 +00:00

auth.c

os: drop SUN-DES-1 authentication

2024-06-18 00:52:11 +00:00

auth.h

os: unexport fields from opaque.h not used by modules / drivers

2024-06-23 21:19:27 +00:00

backtrace.c

os: backtrace: use fixed size array instead of vla

2024-08-31 22:14:07 +00:00

busfault.c

include: move busfault.h out of public include dir

2024-04-15 21:10:15 +00:00

busfault.h

os: fix missing include of misc.h in busfault.h

2024-04-16 14:19:59 +02:00

client.c

Return NULL in *cmdname if the client argv or argv[0] is NULL

2024-09-01 22:59:26 +00:00

cmdline.h

os: unexport command line args handling functions

2024-04-15 21:21:40 +00:00

connection.c

treewide: replace xnfreallocarray macro call by XNFreallocarray()

2024-07-26 23:41:33 +00:00

ddx_priv.h

os: unexport ddx callbacks

2024-05-08 09:37:35 +02:00

fmt.c

os: move out Format*() functions

2024-03-09 17:34:51 +00:00

fmt.h

os: move out Format*() functions

2024-03-09 17:34:51 +00:00

inputthread.c

include: move private definitions out of input.h

2024-09-01 17:59:23 +00:00

io.c

Remove remnants of support for SVR4 systems other than Solaris & illumos

2024-09-01 02:14:10 +00:00

log.c

include: move private definitions out of input.h

2024-09-01 17:59:23 +00:00

meson.build

os: move out LockServer logic from util.c to serverlock.c

2024-07-26 22:26:07 +00:00

mitauth.c

os: move mitauth prototypes to separate header

2024-02-22 23:42:52 +00:00

mitauth.h

os: move Auth* function types to separate header

2024-02-22 23:42:53 +00:00

osdep.h

os: unexport CloseDownConnection()

2024-09-02 16:02:39 +00:00

osinit.c

Remove remnants of support for SysV versions before SVR4

2024-09-01 02:14:10 +00:00

ospoll.c

os: move xserver_poll.h into os/ directory

2024-06-21 00:53:39 +00:00

ospoll.h

os: Add ospoll interface [v2]

2016-07-21 15:04:47 -04:00

reallocarray.c

Import reallocarray() from OpenBSD

2015-04-21 16:57:08 -07:00

screensaver.h

os: unexport screen saver timer functions

2024-09-01 20:23:10 +00:00

serverlock.c

os: move -nolock help message printing to serverlock.h

2024-07-26 22:26:07 +00:00

serverlock.h

os: move -nolock help message printing to serverlock.h

2024-07-26 22:26:07 +00:00

strcasecmp.c

Introduce a consistent coding style

2012-03-21 13:54:42 -07:00

strcasestr.c

os: fix mising prototype / include on WIN32 builds

2024-03-03 23:02:54 +00:00

string.c

os: move string functions to separate source file

2024-02-29 10:09:37 +00:00

strlcat.c

Introduce a consistent coding style

2012-03-21 13:54:42 -07:00

strlcpy.c

Introduce a consistent coding style

2012-03-21 13:54:42 -07:00

strndup.c

os: Ensure <dix-config.h> is included in strndup.c

2013-02-14 09:20:46 -08:00

timingsafe_memcmp.c

timingsafe_memcmp: Fix meson build

2017-05-10 10:56:16 -04:00

utils.c

os: utils: drop obsolete REMOVE_ENV_LD conditional

2024-09-01 20:08:30 +00:00

WaitFor.c

os: unexport screen saver timer functions

2024-09-01 20:23:10 +00:00

xdmauth.c

os: unexport authorization management functions

2024-04-15 14:55:22 -07:00

xdmauth.h

os: move Auth* function types to separate header

2024-02-22 23:42:53 +00:00

xdmcp.c

dix: unexport fields from opaque.h not used by modules/drivers

2024-06-23 21:19:27 +00:00

xdmcp.h

Fix build with -Dxdmcp=false

2024-02-25 11:55:56 +01:00

xprintf.c

Remove "All rights reserved" from Oracle copyright notices

2023-02-25 09:40:41 -08:00

xserver_poll.c

os: move xserver_poll.h into os/ directory

2024-06-21 00:53:39 +00:00

xserver_poll.h

os: move xserver_poll.h into os/ directory

2024-06-21 00:53:39 +00:00

xsha1.c

include: move xsha1.h to os/

2024-03-03 23:11:05 +00:00

xsha1.h

include: move xsha1.h to os/

2024-03-03 23:11:05 +00:00

xstrans.c

Clean up a couple of warnings in os/

2013-10-31 16:58:12 -07:00