mirror of
https://github.com/X11Libre/xserver.git
synced 2026-04-14 17:18:09 +00:00
This tests override WriteToClient() with their own custom function to
check for validity. Unfortunately they also papered over bugs - to
compare values we had to swap back thus modifying the original reply.
This doesn't really have an effect on most reply handling but for those
with extra data it may affect how they are processed. Fix this by
copying the reply so any of the fields within that we swap is left
as-is and put some basic sanity checks in for the length we pass in.
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1469>
(cherry picked from commit 11c92ffcf5)
308 lines
9.2 KiB
C
308 lines
9.2 KiB
C
/**
|
|
* Copyright © 2009 Red Hat, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
/* Test relies on assert() */
|
|
#undef NDEBUG
|
|
|
|
#ifdef HAVE_DIX_CONFIG_H
|
|
#include <dix-config.h>
|
|
#endif
|
|
|
|
/*
|
|
* Protocol testing for XIQueryVersion request and reply.
|
|
*
|
|
* Test approach:
|
|
* Wrap WriteToClient to intercept the server's reply.
|
|
* Repeatedly test a client/server version combination, compare version in
|
|
* reply with versions given. Version must be equal to either
|
|
* server version or client version, whichever is smaller.
|
|
* Client version less than 2 must return BadValue.
|
|
*/
|
|
|
|
#include <stdint.h>
|
|
#include <X11/X.h>
|
|
#include <X11/Xproto.h>
|
|
#include <X11/extensions/XI2proto.h>
|
|
#include "inputstr.h"
|
|
#include "extinit.h" /* for XInputExtensionInit */
|
|
#include "scrnintstr.h"
|
|
#include "xiqueryversion.h"
|
|
#include "protocol-common.h"
|
|
#include "exglobals.h"
|
|
|
|
DECLARE_WRAP_FUNCTION(WriteToClient, void, ClientPtr client, int len, void *data);
|
|
|
|
extern XExtensionVersion XIVersion;
|
|
|
|
static struct test_data {
|
|
int major_client;
|
|
int minor_client;
|
|
int major_server;
|
|
int minor_server;
|
|
int major_expected;
|
|
int minor_expected;
|
|
} versions;
|
|
|
|
|
|
extern ClientRec client_window;
|
|
|
|
static void
|
|
reply_XIQueryVersion(ClientPtr client, int len, void *data)
|
|
{
|
|
xXIQueryVersionReply *reply = (xXIQueryVersionReply *) data;
|
|
xXIQueryVersionReply rep = *reply; /* copy so swapping doesn't touch the real reply */
|
|
|
|
unsigned int sver, cver, ver;
|
|
|
|
assert(len < 0xffff); /* suspicious size, swapping bug */
|
|
|
|
if (client->swapped) {
|
|
swapl(&rep.length);
|
|
swaps(&rep.sequenceNumber);
|
|
swaps(&rep.major_version);
|
|
swaps(&rep.minor_version);
|
|
}
|
|
|
|
reply_check_defaults(&rep, len, XIQueryVersion);
|
|
|
|
assert(rep.length == 0);
|
|
|
|
sver = versions.major_server * 1000 + versions.minor_server;
|
|
cver = versions.major_client * 1000 + versions.minor_client;
|
|
ver = rep.major_version * 1000 + rep.minor_version;
|
|
|
|
assert(ver >= 2000);
|
|
assert((sver > cver) ? ver == cver : ver == sver);
|
|
}
|
|
|
|
static void
|
|
reply_XIQueryVersion_multiple(ClientPtr client, int len, void *data)
|
|
{
|
|
xXIQueryVersionReply *reply = (xXIQueryVersionReply *) data;
|
|
xXIQueryVersionReply rep = *reply; /* copy so swapping doesn't touch the real reply */
|
|
|
|
reply_check_defaults(&rep, len, XIQueryVersion);
|
|
assert(rep.length == 0);
|
|
|
|
assert(versions.major_expected == rep.major_version);
|
|
assert(versions.minor_expected == rep.minor_version);
|
|
}
|
|
|
|
/**
|
|
* Run a single test with server version smaj.smin and client
|
|
* version cmaj.cmin. Verify that return code is equal to 'error'.
|
|
*
|
|
* Test is run normal, then for a swapped client.
|
|
*/
|
|
static void
|
|
request_XIQueryVersion(int smaj, int smin, int cmaj, int cmin, int error)
|
|
{
|
|
int rc;
|
|
xXIQueryVersionReq request;
|
|
ClientRec client;
|
|
|
|
request_init(&request, XIQueryVersion);
|
|
client = init_client(request.length, &request);
|
|
|
|
/* Change the server to support smaj.smin */
|
|
XIVersion.major_version = smaj;
|
|
XIVersion.minor_version = smin;
|
|
|
|
/* remember versions we send and expect */
|
|
versions.major_client = cmaj;
|
|
versions.minor_client = cmin;
|
|
versions.major_server = XIVersion.major_version;
|
|
versions.minor_server = XIVersion.minor_version;
|
|
|
|
request.major_version = versions.major_client;
|
|
request.minor_version = versions.minor_client;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == error);
|
|
|
|
client = init_client(request.length, &request);
|
|
client.swapped = TRUE;
|
|
|
|
swaps(&request.length);
|
|
swaps(&request.major_version);
|
|
swaps(&request.minor_version);
|
|
|
|
rc = SProcXIQueryVersion(&client);
|
|
assert(rc == error);
|
|
}
|
|
|
|
/* Client version less than 2.0 must return BadValue, all other combinations
|
|
* Success */
|
|
static void
|
|
test_XIQueryVersion(void)
|
|
{
|
|
init_simple();
|
|
|
|
wrapped_WriteToClient = reply_XIQueryVersion;
|
|
|
|
dbg("Server version 2.0 - client versions [1..3].0\n");
|
|
/* some simple tests to catch common errors quickly */
|
|
request_XIQueryVersion(2, 0, 1, 0, BadValue);
|
|
request_XIQueryVersion(2, 0, 2, 0, Success);
|
|
request_XIQueryVersion(2, 0, 3, 0, Success);
|
|
|
|
dbg("Server version 3.0 - client versions [1..3].0\n");
|
|
request_XIQueryVersion(3, 0, 1, 0, BadValue);
|
|
request_XIQueryVersion(3, 0, 2, 0, Success);
|
|
request_XIQueryVersion(3, 0, 3, 0, Success);
|
|
|
|
dbg("Server version 2.0 - client versions [1..3].[1..3]\n");
|
|
request_XIQueryVersion(2, 0, 1, 1, BadValue);
|
|
request_XIQueryVersion(2, 0, 2, 2, Success);
|
|
request_XIQueryVersion(2, 0, 3, 3, Success);
|
|
|
|
dbg("Server version 2.2 - client versions [1..3].0\n");
|
|
request_XIQueryVersion(2, 2, 1, 0, BadValue);
|
|
request_XIQueryVersion(2, 2, 2, 0, Success);
|
|
request_XIQueryVersion(2, 2, 3, 0, Success);
|
|
|
|
#if 0
|
|
/* this one takes a while */
|
|
unsigned int cmin, cmaj, smin, smaj;
|
|
|
|
dbg("Testing all combinations.\n");
|
|
for (smaj = 2; smaj <= 0xFFFF; smaj++)
|
|
for (smin = 0; smin <= 0xFFFF; smin++)
|
|
for (cmin = 0; cmin <= 0xFFFF; cmin++)
|
|
for (cmaj = 0; cmaj <= 0xFFFF; cmaj++) {
|
|
int error = (cmaj < 2) ? BadValue : Success;
|
|
|
|
request_XIQueryVersion(smaj, smin, cmaj, cmin, error);
|
|
}
|
|
|
|
#endif
|
|
}
|
|
|
|
|
|
static void
|
|
test_XIQueryVersion_multiple(void)
|
|
{
|
|
xXIQueryVersionReq request;
|
|
ClientRec client;
|
|
XIClientPtr pXIClient;
|
|
int rc;
|
|
|
|
init_simple();
|
|
|
|
request_init(&request, XIQueryVersion);
|
|
client = init_client(request.length, &request);
|
|
|
|
/* Change the server to support 2.2 */
|
|
XIVersion.major_version = 2;
|
|
XIVersion.minor_version = 2;
|
|
|
|
wrapped_WriteToClient = reply_XIQueryVersion_multiple;
|
|
|
|
/* run 1 */
|
|
|
|
/* client is lower than server, nonexpected */
|
|
versions.major_expected = request.major_version = 2;
|
|
versions.minor_expected = request.minor_version = 1;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == Success);
|
|
|
|
/* client is higher than server, no change */
|
|
request.major_version = 2;
|
|
request.minor_version = 3;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == Success);
|
|
|
|
/* client tries to set higher version, stays same */
|
|
request.major_version = 2;
|
|
request.minor_version = 2;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == Success);
|
|
|
|
/* client tries to set lower version, no change */
|
|
request.major_version = 2;
|
|
request.minor_version = 0;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == BadValue);
|
|
|
|
/* run 2 */
|
|
client = init_client(request.length, &request);
|
|
XIVersion.major_version = 2;
|
|
XIVersion.minor_version = 3;
|
|
|
|
versions.major_expected = request.major_version = 2;
|
|
versions.minor_expected = request.minor_version = 2;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == Success);
|
|
|
|
/* client bumps version from 2.2 to 2.3 */
|
|
request.major_version = 2;
|
|
versions.minor_expected = request.minor_version = 3;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == Success);
|
|
|
|
/* real version is changed, too! */
|
|
pXIClient = dixLookupPrivate(&client.devPrivates, XIClientPrivateKey);
|
|
assert(pXIClient->minor_version == 3);
|
|
|
|
/* client tries to set lower version, no change */
|
|
request.major_version = 2;
|
|
request.minor_version = 1;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == BadValue);
|
|
|
|
/* run 3 */
|
|
client = init_client(request.length, &request);
|
|
XIVersion.major_version = 2;
|
|
XIVersion.minor_version = 3;
|
|
|
|
versions.major_expected = request.major_version = 2;
|
|
versions.minor_expected = request.minor_version = 3;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == Success);
|
|
|
|
request.major_version = 2;
|
|
versions.minor_expected = request.minor_version = 2;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == Success);
|
|
|
|
/* but real client version must not be lowered */
|
|
pXIClient = dixLookupPrivate(&client.devPrivates, XIClientPrivateKey);
|
|
assert(pXIClient->minor_version == 3);
|
|
|
|
request.major_version = 2;
|
|
request.minor_version = 1;
|
|
rc = ProcXIQueryVersion(&client);
|
|
assert(rc == BadValue);
|
|
}
|
|
|
|
const testfunc_t*
|
|
protocol_xiqueryversion_test(void)
|
|
{
|
|
static const testfunc_t testfuncs[] = {
|
|
test_XIQueryVersion,
|
|
test_XIQueryVersion_multiple,
|
|
NULL,
|
|
};
|
|
|
|
return testfuncs;
|
|
}
|