Tomasz Śniatowski 6883ae43eb os: Fix strtok/free crash in ComputeLocalClient ...

Don't reuse cmd for strtok output to ensure the proper pointer is
freed afterwards.

The code incorrectly assumed the pointer returned by strtok(cmd, ":")
would always point to cmd. However, strtok(str, sep) != str if str
begins with sep. This caused an invalid-free crash when running
a program under X with a name beginning with a colon.

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=104123
Signed-off-by: Tomasz Śniatowski <kailoran@gmail.com>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>

2017-12-13 09:54:14 -05:00

..

.gitignore

dix and os: gitignore dix.O and os.O

2011-09-23 17:14:47 -07:00

access.c

os: Fix strtok/free crash in ComputeLocalClient

2017-12-13 09:54:14 -05:00

auth.c

Use ARRAY_SIZE all over the tree

2017-10-30 13:45:20 -04:00

backtrace.c

Replace 'sun' with '__sun'

2015-11-30 11:51:22 -05:00

busfault.c

os: Fix iteration over busfaults

2017-02-23 09:20:48 +10:00

client.c

DetermineClientCmd: try using /proc/pid/cmdline on Solaris too

2017-02-14 11:33:47 -05:00

connection.c

os: Set oc->fd to -1 when connection is closed

2017-06-13 09:56:44 -04:00

inputthread.c

os: log a bug whenever WriteToClient is called from the input thread

2017-02-27 09:25:08 +10:00

io.c

os: Make sure big requests have sufficient length.

2017-10-09 17:08:33 -07:00

log.c

os: Failure to remove a non-existent log file is not an error

2016-01-06 12:23:31 -05:00

Makefile.am

os,dix: Depend custom libs on libs, not objects

2017-01-02 12:45:28 -05:00

meson.build

meson: Only detect each function once

2017-05-10 15:08:25 -04:00

mitauth.c

os: make MitGenerateCookie() independent of XCSECURITY

2017-08-22 10:59:40 -04:00

oscolor.c

Use ARRAY_SIZE all over the tree

2017-10-30 13:45:20 -04:00

osdep.h

os: Remove mffs()

2017-11-06 17:22:46 -05:00

osinit.c

os: Handle SIGABRT

2017-04-26 16:07:19 -04:00

ospoll.c

meson: Fix epoll detection

2017-08-14 13:34:11 -07:00

ospoll.h

os: Add ospoll interface [v2]

2016-07-21 15:04:47 -04:00

reallocarray.c

Import reallocarray() from OpenBSD

2015-04-21 16:57:08 -07:00

rpcauth.c

auth: remove AuthToIDFunc and associated functions. Not used anymore.

2017-02-28 14:15:19 -05:00

strcasecmp.c

Introduce a consistent coding style

2012-03-21 13:54:42 -07:00

strcasestr.c

Introduce a consistent coding style

2012-03-21 13:54:42 -07:00

strlcat.c

Introduce a consistent coding style

2012-03-21 13:54:42 -07:00

strlcpy.c

Introduce a consistent coding style

2012-03-21 13:54:42 -07:00

strndup.c

os: Ensure <dix-config.h> is included in strndup.c

2013-02-14 09:20:46 -08:00

timingsafe_memcmp.c

timingsafe_memcmp: Fix meson build

2017-05-10 10:56:16 -04:00

utils.c

os: Fix warning in LockServer

2017-08-30 15:53:04 -04:00

WaitFor.c

os: Remove mffs()

2017-11-06 17:22:46 -05:00

xdmauth.c

auth: remove AuthToIDFunc and associated functions. Not used anymore.

2017-02-28 14:15:19 -05:00

xdmcp.c

os/xdmcp: Honour -once when session is dead

2017-11-29 14:50:12 -05:00

xprintf.c

os/xprintf: add Xvscnprintf and Xscnprintf

2012-05-03 14:59:23 +10:00

xserver_poll.c

os: Add poll emulation for mingw [v2]

2016-07-19 11:08:21 -07:00

xsha1.c

os/xsha1.c: Add license and copyright attribution.

2015-01-02 13:39:52 -08:00

xstrans.c

Clean up a couple of warnings in os/

2013-10-31 16:58:12 -07:00