xserver

mirror of https://github.com/X11Libre/xserver.git synced 2026-03-24 08:04:30 +00:00

Files

Enrico Weigelt, metux IT consult 53876f1ef1 randr: fix RRGetCrtcTransform reply length, part 2

Mixed up reply vs request. Obviously, the size substracted from reply
struct's one has to be the one of the generic reply, not generic requst :o

Background: the meaning of the length field isn't entirely intuitive.

a) the size is in 4-byte units, instead of bytes (therefore passing through
   bytes_to_int32() call)
b) it's not the total packet size, but only the *extra* payload size, ergo:
   how much is the packet longer than a xGenericReply = 8 units = 32 bytes.
   (min. packet size is 32 bytes -> length = 0)

In order to prevent those kind of coding errors ever happening again, it might
be a good idea putting that into a generic macro.

Fixes: c6f1b8a735
Fixes: 0ca5aaba50
Issue: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1797
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1845>

2025-02-27 12:18:20 +00:00

meson.build

meson: hide C API if Xorg is disabled (like autotools)

2021-03-11 00:22:36 +00:00

randr.c

randr: RRScreenInit(): drop unnecessary zero'ing

2025-02-24 20:30:26 +00:00

randrstr_priv.h

randr: use explicit case statement instead of SProcRandrVector table

2025-02-24 20:30:26 +00:00

randrstr.h

render: drop obsolete macros pict_f_transform and pict_f_vector