Enrico Weigelt, metux IT consult
bdb5d4867a
Xext: geext: drop unused GEEventFill() macro
...
It's not used anywhere, so no need to keep it around any longer.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1811 >
2025-02-23 17:53:25 +00:00
Enrico Weigelt, metux IT consult
e4e3b69626
Xext: geext: fix regression in SProcGEQueryVersion()
...
Commit 36dd28129b had an ugly typo
(probably broke on rebase - shame on myself) causing SProcGEQueryVersion()
calling itself recursively. Obviously, ProcGEQueryVersion() needs
to be called instead.
Fixes: 36dd28129b
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1817 >
2025-02-23 17:25:29 +00:00
Enrico Weigelt, metux IT consult
c6b223459c
os: unexport ResetCurrentRequest()
...
Not used by any external modules, so no need to keep it in public API.
Since it's used by DRI, still needs the _X_EXPORT flag, as long as DRI
is a dynamically loaded module.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:45 +00:00
Enrico Weigelt, metux IT consult
ba665948f6
os: unexport WriteFdToClient()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
c6b8207342
os: unexport AuthorizationIDOfClient()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
1f27d3d653
os: unexport ClientIsLocal()
...
Not used by any modules, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1790 >
2025-02-18 10:53:44 +00:00
Enrico Weigelt, metux IT consult
346d5f5c35
os: move BUG_*() macros to own private header
...
These macros aren't used by any external modules, so no need
to keep them public. Moving them into private header.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1804 >
2025-02-17 19:32:48 +00:00
Enrico Weigelt, metux IT consult
f4d878086e
Xext: selinux: use static reply struct init on declaration
...
Make the code a bit easier to read by using initialization of the reply
structs, at the point of declaration. Most of them aren't written to later,
just passed into WriteReplyToClient(). Also dropping some useless zero
assignments (struct initializers automatically zero-out unmentioned fields).
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1795 >
2025-02-17 18:58:10 +00:00
Enrico Weigelt, metux IT consult
c0f3b5bcef
Xext: shm: use dixDestroyPixmap() instead of direct driver call
...
Direct calls to ScreenRec->DestroyPixmap() blocks cleaning up the wrapping
jungle, so use the proper dix function instead.
See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1754
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1711 >
2025-02-12 17:48:30 +01:00
Enrico Weigelt, metux IT consult
7ce19233bc
Xext: saver: use dixDestroyPixmap() instead of direct driver call
...
Direct calls to ScreenRec->DestroyPixmap() blocks cleaning up the wrapping
jungle, so use the proper dix function instead.
See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1754
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1711 >
2025-02-12 17:48:30 +01:00
Enrico Weigelt, metux IT consult
356e18dcc6
os: move out extension disable flags to corresponing extensions
...
The OS abstraction isn't really the right place for those flags,
they are're probably better off in their corresponding extensions.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1519 >
2025-02-07 12:00:53 +01:00
Enrico Weigelt, metux IT consult
8539f35818
Revert "xv: unexport XvScreenRec and XvScreenPtr"
...
This reverts commit 58a2fb8b6f .
Needed by xf86-video-intel driver. Didn't get noticed, because we don't
have this driver in our CI yet.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1772 >
2025-02-07 10:08:41 +01:00
Enrico Weigelt, metux IT consult
37dd2897d4
Xext: saver: consolidate (non-)xinerama versions
...
We can make it a bit simpler by doing the request header
checking only once.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591 >
2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
8236ef3b56
Xext: saver: use explicit switch/case for dispatching
...
It's more robust / easier understandable programming style to use explicit
switch statements, case'ing on the constants defined in the protocol header,
instead of implicitly via a some opaque call table. It's also done this
way in the other extensions, so making the code a bit more consistent.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591 >
2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
40469a9d51
Xext: saver: skip unneeded zero init and zero-swapping
...
When using struct initializers, all fields not set explicitly are zero.
Also no need to swap fields that are known to be zero.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591 >
2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
fdb8c8ea41
Xext: saver: fix missing swap in QueryVersion reply
...
The `majorVersion` and `minorVersion` fields are CARD16, thus need to be swapped.
OTOH, the lengths field is zero anyways, so no need to swap it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1591 >
2025-02-06 23:56:51 +00:00
Enrico Weigelt, metux IT consult
a33639f975
xvmc: move over protocol version defines into xvmc.c
...
These are exclusively used in one source file, so no need to keep them
in a global header.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1693 >
2025-02-06 23:29:10 +00:00
Enrico Weigelt, metux IT consult
ef62929f58
treewide: NULL-protect ScreenRec->DestroyPixmap() calls
...
Right now, we're assuming that even when deep nesting involved, the proc
vector is always set to a valid function. One the one hand it requires
extra dummy procs in some cases, OTOH it's making upcoming refactoring
of the code flow unnecessarily complex.
The big plot (of subsequent commits) is splitting out the extension's
(and possibly subsystem's) special logic out of the wrapping chain and
let them be executed independently from the DDX/drivers - when applicable
even only when the pixmap is really destroyed (not just unref'ed).
(At some later point, it might even become be actually a valid situation
that DestroyPixmap vector really being NULL.)
See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1754
See: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1755
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1709 >
2025-02-06 23:02:06 +00:00
Enrico Weigelt, metux IT consult
dc9a998b96
Xext: xv: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
753e6c44ba
Xext: xtest: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
0c87f9b1da
Xext: xcmisc: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
9a3daf908c
Xext: vidmode: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
3bb15b3e04
Xext: sync: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
c8c42490b7
Xext: shm: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
a7bdfdb3b5
Xext: shape: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
07131dccc5
Xext: saver: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:52 +00:00
Enrico Weigelt, metux IT consult
515992b046
Xext: panoramiX: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
98dbd817f6
Xext: dpms: drop now obsolete swap procs
...
Several SProc's have become no-ops, just calling the actual Proc's,
so we can get rid of them entirely.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
54d4dd619c
Xext: xv: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
69982abf7b
Xext: xtest: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:51 +00:00
Enrico Weigelt, metux IT consult
8a5d2a1335
Xext: selinux: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
8b57516414
Xext: xres: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
776efd3cfc
Xext: xf86bigfont: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
405a227c73
Xext: xcmisc: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
65cb5e5575
Xext: vidmode: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
bf6d132df6
Xext: sync: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
75544f1f58
Xext: shm: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
a105c1f7a9
Xext: shape: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
cd413baa4b
Xext: security: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
b52f5f9693
Xext: saver: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
23a8d9be71
Xext: panoramiX: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
fb40f65ee0
Xext: dpms: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:50 +00:00
Enrico Weigelt, metux IT consult
4f56025812
Xext: bigreq: drop swapping request length fields
...
The request struct's length fields aren't used anymore - we have the
client->req_len field instead, which also is bigreq-compatible.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:49 +00:00
Enrico Weigelt, metux IT consult
44c063d93d
Xext: xtest: fix length checking with bigreq
...
The authorative source of the request frame size is client->req_len,
especially with big requests larger than 2^18 bytes.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:48 +00:00
Enrico Weigelt, metux IT consult
c3e1f6fccf
Xext: vidmode: fix length checking with bigreq
...
The authorative source of the request frame size is client->req_len,
especially with big requests larger than 2^18 bytes.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:48 +00:00
Enrico Weigelt, metux IT consult
dab1299745
Xext: shape: fix length checking with bigreq
...
The authorative source of the request frame size is client->req_len,
especially with big requests larger than 2^18 bytes.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:48 +00:00
Enrico Weigelt, metux IT consult
67a3319d73
Xext: security: fix length checking with bigreq
...
The authorative source of the request frame size is client->req_len,
especially with big requests larger than 2^18 bytes.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:48 +00:00
Enrico Weigelt, metux IT consult
bacc4b1477
Xext: saver: fix length checking with bigreq
...
The authorative source of the request frame size is client->req_len,
especially with big requests larger than 2^18 bytes.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1639 >
2025-02-06 22:28:48 +00:00
Enrico Weigelt, metux IT consult
36dd28129b
Xext: geext: simplify dispatcher
...
Most of the complexity here isn't needed at all. It can be really trivial,
since we just have one operation anyways.
It's also much cleaner to use the defines from proto headers instead of
raw numbers.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1596 >
2025-02-06 21:26:32 +00:00
Enrico Weigelt, metux IT consult
6df7ba38ae
Xext: geext: drop unused variable extEntry
...
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1596 >
2025-02-06 21:26:32 +00:00