Enrico Weigelt, metux IT consult
b3de32d072
(submit/cleanup-xf86bigfont) Xext: xf86bigfont: drop some dead code
...
There's some piece ifdef'ed code that doesn't serve any practical purpose.
Instead add a little comment telling why that funny way of dispatching
(based on request size) is necessary.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:06 +02:00
Enrico Weigelt, metux IT consult
3e522533a9
(cleanup/xext-xres) Xext: xres: ProcXResQueryClientIds() collect reply in one stack buffer
...
In order to allow simplifying the reply send path, collect the reply
fragments into one buffer, instead of arbitrary number of WriteToClient()
calls. This also makes it much easier for potentially new purely packet-based
transports which (eg. binder) that would need their own stream parsing logic.
This xres function is an exceptionally hard case, since payload is constructed
step by step, and it's size only known when finished. The current way of the
fragment handling still has lots of room for improvement (eg. using very small
number of allocations), but leaving this for later exercise.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:06 +02:00
Enrico Weigelt, metux IT consult
d2611ed4e8
(cleanup/xext-xres) Xext: xres: ProcXResQueryClientResources() simplify payload write out
...
Collect the few bits in a local array, so one WriteToClient() call is
sufficient. That's also easing further simplifications in upcoming commits.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:06 +02:00
Enrico Weigelt, metux IT consult
e7db8e3302
(cleanup/xext-xres) Xext: xres: ProcXResQueryClientResources(): put temporary int array on stack
...
Simplify allocaton by putting the small temporary int array onto stack.
This also allows further simplifications by upcoming commits.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:06 +02:00
Enrico Weigelt, metux IT consult
e765fe1da9
(cleanup/xext-xres) Xext: xres: ProcXResQueryClients() simplify payload write out
...
Collect the few bits in a local array, so one WriteToClient() call is
sufficient. That's also easing further simplifications in upcoming commits.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:06 +02:00
Enrico Weigelt, metux IT consult
61533fdf1e
(cleanup/xext-xres) Xext: xres: ProcXResQueryClients() put temporary int array on stack
...
Simplify allocaton by putting the small temporary int array onto stack.
This also allows further simplifications by upcoming commits.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:06 +02:00
Enrico Weigelt, metux IT consult
ea5e05f4cb
(cleanup/xext-xres) Xext: xres: sort includes
...
Bring #include's into some logical order.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:06 +02:00
Enrico Weigelt, metux IT consult
2a15c596f8
(cleanup/xext-xres) Xext: xres: use static initialization
...
* use static initialization where applicable
* drop unneeded setting of zero values
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:06 +02:00
Enrico Weigelt, metux IT consult
9523790742
(submit/recv-fds) os: read file descriptors into client struct at once
...
Instead of having the request handler ask for fd's one by one, just read them
all into a little array in ClientRec struct. And also automatically clean up
after request had been handled.
Request handlers need to set the entries to -1 if they shouldn't be closed
automatically.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:06 +02:00
Enrico Weigelt, metux IT consult
b2b4b88c53
(submit/cleanup-xvmc) Xext: xvmc: simplify reply struct initialization
...
* use static initialization and stack allocation where possible
* put the lists into one one block, so they can be written in one pass
* simplify size computations
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:05 +02:00
Enrico Weigelt, metux IT consult
998187a87c
(submit/cleanup-xvmc) Xext: xvmc: simplify dispatcher
...
The dispatcher functions are much more complex than they're usually are
(just switch/case statement). Bring them in line with the standard scheme
used in the Xserver, so further steps become easier.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
2024-08-29 11:35:05 +02:00
Enrico Weigelt, metux IT consult
c4481fc20f
treewide: fix indentions got broke by recent commit
...
Commit f26f17c66a broke some indentions,
fixing them now.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1662 >
2024-08-27 20:08:32 +02:00
Enrico Weigelt, metux IT consult
f26f17c66a
treewide: mark pGC->ops->CopyArea() calls not using result as void
...
We alread have several of these calls, that aren't interested in result value,
explicitly casting to void. Fixing this up for the remaining ones.
This is helpful for the human reader as well as quality analysis tools.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1648 >
2024-08-26 03:44:23 +00:00
Enrico Weigelt, metux IT consult
ed9c48a030
xv: unexport XvPortNotifyRec
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
58a2fb8b6f
xv: unexport XvScreenRec and XvScreenPtr
...
Not used by any drivers, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
a952b93d0d
xv: unexport XvdiGrabPort() and XvdiUngrabPort()
...
Not used by any drivers, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
27a2245da7
xv: unexport XvdiMatchPort()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
043a9c7b03
xv: unexport XvdiStopVideo()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
79189b9e11
xv: unexport XvdiSetPortAttribute() and XvdiGetPortAttribute()
...
Not used by any drivers, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
bb287bb7c6
xv: unexport XvdiGet*()
...
Not used by any drivers, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
6b884b89c5
xv: unexport XvdiPut*()
...
Not used by any drivers, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
12ffbdccc2
xv: unexport notify control functions
...
Not used by any drivers, so no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
00f00e5d42
xv: make XvdiSendPortNotify() static
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
68ea5f855c
xv: unexport XvFillColorKey()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
01de53c815
xv: unexport XvFreeAdaptor()
...
Not used by any drivers, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
f3c3b78907
xv: unexport dispatch functions
...
These aren't supposed to be called by drivers, no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
d746a43a67
xv: unexport remaining public variables
...
These variabls aren't used by any driver, no need to keep them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
d53b5550c1
xv: unexport VALIDATE_XV_PORT and _XvBadPort macros
...
These are only used inside xv extension code, so no need to keep
them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
9bb6d8b169
xv: unexport internal variables and make them static
...
These variables are only used by xvmain.c (no drivers using them),
so make them static.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
354f42b25c
xv: move XvVideoNotifyRec into xvmain.c
...
This struct is only used in xvmain.c, so no need to keep it exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
4d0b5833da
xv: move SCREEN_(PROLOGUE|EPILOGUE) into xvmain.c
...
These macros are only used in xvmain.c, so no need to keep
them exported.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
d7e481f200
xv: drop unused macro _XvBadEncoding
...
Couldn't find a trace where it actually had been used, so there doesn't
seem to be any reason while still keeping it around.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
6b445819dd
xv: drop unused define GLOBAL
...
This symbol isn't used anywhere, for at least 20 years now,
so no need to define it.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
8e32cec204
xv: move noXvExtension to xvmain.c
...
It's more appropriate having those kind of flags in the corresponding
extension.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1512 >
2024-07-26 23:51:13 +00:00
Enrico Weigelt, metux IT consult
37e65497e4
Xext: security: fix missing include of extinit_priv.h
...
Fix a warning on missing prototype due missing include of extinit_priv.h
Fixes: 33350ef8 - include: move private definitions out of extinit.h
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1617 >
2024-07-23 09:17:33 +02:00
Enrico Weigelt, metux IT consult
f94e280896
Xext: fix missing include of <X11/Xmd.h>
...
Including <X11/extensions/securproto.h> depends on <X11/Xmd.h> has been
included before.
Bug: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1719
Fixes: b30edf32 - fix missing includes of <X11/Xfuncproto.h>
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1617 >
2024-07-23 08:55:38 +02:00
Enrico Weigelt, metux IT consult
b30edf326b
fix missing includes of <X11/Xfuncproto.h>
...
Several places using _X_ATTRIBUTE_PRINTF macro from X11/Xfuncproto.h
but missing to include it, so it depends on other headers whether it's
included by mere accident, which quickly causes trouble if include order
changes. Cleaning that up by adding explicit include statements.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1580 >
2024-07-20 17:18:38 +00:00
Enrico Weigelt, metux IT consult
fba3eefcc9
Xext: saver: little bit formatting cleanup
...
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1586 >
2024-07-06 17:29:11 +00:00
Enrico Weigelt, metux IT consult
df38987656
Xext: saver: drop New() macro
...
We can directly use calloc() as all other places do.
If we wanna have an convenient macro for struct allocation, that would be the
job of a separate patch queue and should be done consequently, treewide.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1586 >
2024-07-06 17:29:10 +00:00
Enrico Weigelt, metux IT consult
06b599edb6
dix: unexport fields from opaque.h not used by modules/drivers
...
Lots of fields from opaque.h aren't used by any drivers/modules and thus
don't need to be exported at all.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1351 >
2024-06-23 21:19:27 +00:00
Enrico Weigelt, metux IT consult
facdaae4e8
xace: typesafe hook function for XACE_KEY_AVAIL
...
he generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
Enrico Weigelt, metux IT consult
591d95c79e
xace: typesafe hook function for XACE_AUTH_AVAIL
...
he generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
Enrico Weigelt, metux IT consult
305f2d59d8
xace: typesafe hook function for XACE_SCREENSAVER_ACCESS
...
he generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
Enrico Weigelt, metux IT consult
51d8bcfc0d
xace: typesafe hook function for XACE_SCREEN_ACCESS
...
he generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
Enrico Weigelt, metux IT consult
47d6c3ad75
xace: typesafe hook function for XACE_SERVER_ACCESS
...
he generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
Enrico Weigelt, metux IT consult
0f6bb23bc2
xace: typesafe hook function for XACE_EXT_ACCESS
...
he generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
Enrico Weigelt, metux IT consult
922b7685dc
xace: typesafe hook function for XACE_CLIENT_ACCESS
...
The generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
Enrico Weigelt, metux IT consult
3dfe00d5e0
xace: typesafe hook function for XACE_RECEIVE_ACCESS
...
The generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
Enrico Weigelt, metux IT consult
67e468c8bd
xace: typesafe hook function for XACE_SEND_ACCESS
...
The generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00
Enrico Weigelt, metux IT consult
9524ffee89
xace: typesafe hook function for XACE_DEVICE_ACCESS
...
The generic XaceHook() call isn't typesafe (und unnecessarily slow).
Better add an explicit function, just like we already have for others.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net >
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1556 >
2024-06-23 21:07:48 +00:00