Commit Graph

197 Commits

Author SHA1 Message Date
Enrico Weigelt, metux IT consult
b9c5787ca5 xfree86: ddc: interpret_edid.c: minor whitespace fixes
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-29 19:00:23 +01:00
Enrico Weigelt, metux IT consult
55d317dd50 xfree86: ddc: move some defines into private header
Those aren't used by any external driver, so no need to keep them public.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-29 17:32:21 +01:00
Enrico Weigelt, metux IT consult
f98d467a0c xfree86: ddc: move remaining struct cea_* to private header
Not needed in public SDK headers.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-29 16:51:11 +01:00
Enrico Weigelt, metux IT consult
1a9d075b9a xfree86: ddc: move struct cea_vendor_block(_hdmi) to private header
Not used by any external driver, so no need to keep them in public header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-29 14:32:40 +01:00
Enrico Weigelt, metux IT consult
5a34d6c738 xfree86: ddc: move struct cea_speaker_block into private header
Not used by any external drivers, so no need to keep it in public header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-29 14:08:57 +01:00
Enrico Weigelt, metux IT consult
b6092270e0 xfree86: ddc: move struct cea_data_block into private header
Not used by any external drivers, so no need to keep it in public header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-29 13:18:16 +01:00
Enrico Weigelt, metux IT consult
46741a8645 xfree86: ddc: move CVT_SUPPORTED to private header
Not used by any external driver, so no need to keep it in public header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-29 10:37:10 +01:00
Enrico Weigelt, metux IT consult
88a58ed15c xfree86: ddc: move sync characteristics macros to print_edid.c
Only used there, so no need to keep them in public header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-29 10:36:57 +01:00
Enrico Weigelt, metux IT consult
b584b59f1d xfree86: ddc: move ext tag defines into interpret_edid.c
Not used anywhere outside, so no need to keep them in public header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-29 10:36:44 +01:00
Enrico Weigelt, metux IT consult
bd271ff0b5 xfree86: ddc: move EDID1_LEN into edid_priv.h
Not used by any external drivers, so no need to keep it public.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 20:00:32 +01:00
Enrico Weigelt, metux IT consult
aab09a7b73 xfree86: ddc: move IS_*_STEREO() macros into print_edid.c
Only used there, so no need to keep them in public header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 19:47:35 +01:00
Enrico Weigelt, metux IT consult
e38aaa19b1 xfree86: ddc: move some parsing EDID macros into ddc.c
Only used there, so no need to keep them in public header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 19:25:59 +01:00
Enrico Weigelt, metux IT consult
f4a84dc23c xfree86: ddc: drop obsolete IS_STEREO() macro
It's not actually doing something, so we don't really need it.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 19:22:18 +01:00
Enrico Weigelt, metux IT consult
de61093cad xfree86: ddc: replace SIG_SETUP()
Trivial enough to replace it easily.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 18:44:44 +01:00
Enrico Weigelt, metux IT consult
75177d9b72 xfree86: ddc: move EDID parser specific macros out of public header
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 18:21:06 +01:00
Enrico Weigelt, metux IT consult
2fe8f72029 xfree86: ddc: replace NEXT_DT_MD_SECTION() macro
trivial enough to be replaced easily.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 17:53:04 +01:00
Enrico Weigelt, metux IT consult
d0c2641715 xfree86: ddc: move input voltage level defines into print_edid.c
Only used in print_edid.c, so no need to keep them in global header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 17:48:35 +01:00
Enrico Weigelt, metux IT consult
5b81bcb5b4 xfree86: ddc: drop unused VENDOR_SUPPORT_* defines
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 11:09:25 +01:00
Enrico Weigelt, metux IT consult
bfe6712c35 xfree86: ddc: move DPMS_*() macros into print_edid.c
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-28 11:09:08 +01:00
Enrico Weigelt, metux IT consult
1649eb38d5 xfree86: ddc: move STD_COLOR_SPACE() and GFT_SUPPORTED() macros
These are only used in print_edid.c, so no need to keep them
in a global header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-27 19:35:08 +01:00
Enrico Weigelt, metux IT consult
ebe91d83d3 xfree86: ddc: drop obsolete IS_RIGHT_ON_SYNC() and IS_LEFT_STEREO()
Not used anymore, so no need to keep them around any longer.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-27 19:10:38 +01:00
Enrico Weigelt, metux IT consult
7c59856e8b xfree86: ddc: move DISP_* defines into print_edid.c
Only used in one source file, so no need to keep them in global header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-27 18:56:39 +01:00
Enrico Weigelt, metux IT consult
769616256f xfree86: ddc: drop unused IS_INTERLACED() macro
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-27 18:55:11 +01:00
Enrico Weigelt, metux IT consult
41b2c02f63 xfree86: ddc: drop obsolete DEFAULT_GTF() macro
Not used anywhere.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-27 17:41:52 +01:00
Enrico Weigelt, metux IT consult
fa09ad5a61 xfree86: ddc: move struct cea_ext_body into interpret_edid.c
It's only used there, so no need to keep it in public header.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-27 17:28:04 +01:00
Enrico Weigelt, metux IT consult
ac141cd1cc xfree86: ddc: drop unused RANGE_LIMITS_ONLY() macro
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-27 17:22:31 +01:00
Enrico Weigelt, metux IT consult
78953e5965 xfree86: ddc: drop obsolete DFP1() macro
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-27 15:44:51 +01:00
Enrico Weigelt, metux IT consult
1cb42729a4 xfree86: ddc: replace several internal macros that aren't really needed
Just replace them by their actual definition right where they're called.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-27 11:31:17 +01:00
Enrico Weigelt, metux IT consult
43232e4f09 xfree86: edid.h: drop Uint typedef
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-22 13:03:12 +01:00
Enrico Weigelt, metux IT consult
8ab6539d0b xfree86: replace Uchar by C standard uint8_t
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2026-01-22 11:14:23 +01:00
Enrico Weigelt, metux IT consult
ec277d2c0b xfree86: use dixAddAtom()
Use the new helper for creating atoms.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-07-23 12:24:27 +02:00
Enrico Weigelt, metux IT consult
7f5ff374b6 xfree86: xf86Priv.h: unexport xf86Initialising field
Not used by any external drivers.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 17:21:47 +02:00
Enrico Weigelt, metux IT consult
d8e6511b1b xfree86: use calloc() instead of malloc()
Using calloc() instead of malloc() as preventive measure, so there
never can be any hidden bugs or leaks due uninitialized memory.

The extra cost of using this compiler intrinsic should be practically
impossible to measure - in many cases a good compiler can even deduce
if certain areas really don't need to be zero'd (because they're written
to right after allocation) and create more efficient machine code.

The code pathes in question are pretty cold anyways, so it's probably
not worth even thinking about potential extra runtime costs.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:49:57 +02:00
Enrico Weigelt, metux IT consult
567898f17d xfree86: ddc: safety check for NULL pointer
Even though it *should* never be actually hit, it's still safer
to check for NULL instead of letting us crash with segfault.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:33:47 +02:00
Enrico Weigelt, metux IT consult
c25368e091 xfree86: ddc: make DMTModes[] static
Only used inside xf86EdidModes.c, so can be made static.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:22:27 +02:00
Enrico Weigelt, metux IT consult
b60303c16e xfree86: ddc: make FindDMTMode() static
Only used inside xf86EdidModes.c, so can be made static.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:22:24 +02:00
Enrico Weigelt, metux IT consult
3f4579ebad xfree86: ddc: unexport gtf_supported()
Not used by any external drivers, so no need to keep it exported.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:22:21 +02:00
Enrico Weigelt, metux IT consult
c6429560c6 xfree86: ddc: drop unused xf86MonitorIsHDMI()
Not used anywhere, so no need to keep it anymore.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:22:17 +02:00
Enrico Weigelt, metux IT consult
791401f8d2 xfree86: ddc: unexport xf86EdidMonitorSet()
Not used by any external drivers, so no need to keep it exported.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:22:13 +02:00
Enrico Weigelt, metux IT consult
95f802e3f6 dix: unexport RootWindowFinalizeCallback field
Not used by any external drivers, so no need to keep it exported.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
2025-06-12 16:18:54 +02:00
Enrico Weigelt, metux IT consult
bcbc7479f3 xfree86: common: use LogMessageVerb() instead of xf86Msg()
Both are doing same job, so no need to keep using an duplicated implementation.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1681>
2025-02-07 22:40:06 +00:00
Enrico Weigelt, metux IT consult
00c2a8fb0a xfree86: ddc: move private definitions from xf86DDC.h to xf86DDC_priv.h
public server module API headers shouldn't be clobbered with non-exported
definitions, so move them out to private header file.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1290>
2025-02-06 23:51:34 +00:00
Enrico Weigelt, metux IT consult
f446235b71 treewide: replace xnfcalloc() calls by XNFcallocarray()
This has been nothing but an alias for two decades now (somewhere in R6.6),
so there doesn't seem to be any practical need for this indirection.

The macro still needs to remain, as long as (external) drivers still using it.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1529>
2024-07-26 23:41:33 +00:00
Enrico Weigelt, metux IT consult
c55ddd072b treewide: replace xnfalloc() calls to XNFalloc()
This has been nothing but an alias for two decades now (somewhere in R6.6),
so there doesn't seem to be any practical need for this indirection.

The macro still needs to remain, as long as (external) drivers still using it.

Fixes: ded6147bfb
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1529>
2024-07-26 23:41:33 +00:00
Alan Coopersmith
522f469fe9 Move sizeof to second argument in calloc calls
Clears -Wcalloc-transposed-args warnings from gcc 14.1, such as:

../dix/main.c:165:42: warning: ‘calloc’ sizes specified with ‘sizeof’ in the
 earlier argument and not in the later argument [-Wcalloc-transposed-args]
  165 |             serverClient = calloc(sizeof(ClientRec), 1);
      |                                          ^~~~~~~~~
../dix/main.c:165:42: note: earlier argument should specify number of
 elements, later size of each element

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1606>
2024-07-19 23:45:21 +00:00
Enrico Weigelt, metux IT consult
be4c8444eb os: unexport Os*() functions
These aren't called (and suited for being called) by drivers,
thus drop them from the public module API.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1381>
2024-04-16 14:20:30 +02:00
Jeremy Huddleston Sequoia
199b8c0853 print_edid: Fix a format string error
../hw/xfree86/ddc/print_edid.c:511:20: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat]
                   det_mon->type - DS_VENDOR);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
2022-06-26 09:16:42 +00:00
Povilas Kanapickas
c97397dc47 Remove autotools support
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
2021-10-27 13:15:40 +03:00
Pascal VITOUX
34e2a64ce0 xfree86: fix gtf support detection for EDID 1.4
According to the "VESA Enhanced EDID Standard", all GTF compliant
displays are continuous frequency.

The GTF support flags in 'Display Range Limits Descriptor' cannot be
used if the display is a non-continuous frequency multi-mode display.

Closes #1105
Signed-off-by: Pascal VITOUX <vitoux.pascal@gmail.com>
Fixes: 6a79a737 ("xfree86: add drm modes on non-GTF panels")
Reviewed-by: Aaron Ma aaron.ma@canonical.com
2021-04-06 11:25:42 +00:00
Alan Coopersmith
23e83724df Fix spelling/wording issues
Most (but not all) of these were found by using
  codespell --builtin clear,rare,usage,informal,code,names
but not everything reported by that was fixed.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
2020-07-05 13:07:33 -07:00