From f763f0ec44ce3b1cb4cfde7c4f2bf5ac785dc44a Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Tue, 22 Apr 2025 20:22:27 +0200 Subject: [PATCH] glx: fix missing include of dix-config.h This header needs to be included first, otherwise things can easily get really messed up. The current code only works by accident, because some other header already including it early enough - but a subtle change in include order can easy break it. Thus, always make sure the header is really included first. Signed-off-by: Enrico Weigelt, metux IT consult --- glx/extension_string.c | 3 ++- glx/indirect_size_get.c | 2 +- glx/vndext.c | 1 + glx/vndservermapping.c | 1 + glx/vndservervendor.c | 1 + 5 files changed, 6 insertions(+), 2 deletions(-) diff --git a/glx/extension_string.c b/glx/extension_string.c index a5b8c747e6..e5ba590289 100644 --- a/glx/extension_string.c +++ b/glx/extension_string.c @@ -31,7 +31,8 @@ * \author Ian Romanick */ -#include "dix-config.h" +#include + #include "extension_string.h" #include "opaque.h" diff --git a/glx/indirect_size_get.c b/glx/indirect_size_get.c index ab04e1a514..d00f9f1ffd 100644 --- a/glx/indirect_size_get.c +++ b/glx/indirect_size_get.c @@ -22,7 +22,7 @@ * OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ - +#include #include #include diff --git a/glx/vndext.c b/glx/vndext.c index 1065269135..513e317bd5 100644 --- a/glx/vndext.c +++ b/glx/vndext.c @@ -26,6 +26,7 @@ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE * MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS. */ +#include #include "vndserver_priv.h" diff --git a/glx/vndservermapping.c b/glx/vndservermapping.c index 1a76e52a8b..b55a5f32eb 100644 --- a/glx/vndservermapping.c +++ b/glx/vndservermapping.c @@ -26,6 +26,7 @@ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE * MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS. */ +#include #include "vndserver_priv.h" diff --git a/glx/vndservervendor.c b/glx/vndservervendor.c index bd86c67f73..e2e7d194ee 100644 --- a/glx/vndservervendor.c +++ b/glx/vndservervendor.c @@ -26,6 +26,7 @@ * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE * MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS. */ +#include #include "vndservervendor.h"