From e352fdecfef57ddc553c3e2461fbea17f7484141 Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Sun, 26 Oct 2025 16:53:22 +0200 Subject: [PATCH] dix: handle allocation failure in DeviceFocusEvent() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reported in https://gitlab.freedesktop.org/xorg/xserver/-/issues/1817: xwayland-24.1.6/redhat-linux-build/../dix/enterleave.c:786:5: warning[-Wanalyzer-possible-null-dereference]: dereference of possibly-NULL ‘xi2event’ Fixes: https://github.com/X11Libre/xserver/commit/3f37923a727d5fc4b1880a53dac1145884ba7140 ("Xi: send XI2 focus events." in Xorg 1.10.0) Signed-off-by: Alan Coopersmith Part-of: --- dix/enterleave.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dix/enterleave.c b/dix/enterleave.c index 7959b30f77..ece1606d40 100644 --- a/dix/enterleave.c +++ b/dix/enterleave.c @@ -774,8 +774,7 @@ DeviceFocusEvent(DeviceIntPtr dev, int type, int mode, int detail, len = sizeof(xXIFocusInEvent) + btlen * 4; xXIFocusInEvent *xi2event = calloc(1, len); - if (!xi2event) - return; + BUG_RETURN(xi2event == NULL); xi2event->type = GenericEvent; xi2event->extension = EXTENSION_MAJOR_XINPUT;