XLibre/xserver
1
1
Fork 0
mirror of https://github.com/X11Libre/xserver.git synced 2026-03-24 03:44:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

present: revert 8ed09861dc

Browse Source 
Part of fixing https://github.com/X11Libre/xserver/issues/1812

Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
This commit is contained in:
stefan11111
2026-01-27 01:49:34 +02:00
committed by Enrico Weigelt
parent 0343cad62a
commit dba40b75c4
1 changed files with 25 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
present/present_scmd.c
View File

@@ -58,29 +58,6 @@ present_flip_pending_pixmap(ScreenPtr screen)
return screen_priv->flip_pending->pixmap; return screen_priv->flip_pending->pixmap;
} }
static inline Bool
present_check_driver_flip(RRCrtcPtr crtc,
WindowPtr window,
PixmapPtr pixmap,
Bool sync_flip,
present_screen_priv_ptr screen_priv,
PresentFlipReason *reason)
{
if (screen_priv->info->version >= 1 && screen_priv->info->check_flip2) {
if (!(*screen_priv->info->check_flip2) (crtc, window, pixmap, sync_flip, reason)) {
DebugPresent(("\td %08" PRIx32 " -> %08" PRIx32 "\n", window->drawable.id, pixmap ? pixmap->drawable.id : 0));
return FALSE;
}
} else if (screen_priv->info->check_flip) {
if (!(*screen_priv->info->check_flip) (crtc, window, pixmap, sync_flip)) {
DebugPresent(("\td %08" PRIx32 " -> %08" PRIx32 "\n", window->drawable.id, pixmap ? pixmap->drawable.id : 0));
return FALSE;
}
}
return TRUE;
}
static Bool static Bool
present_check_flip(RRCrtcPtr crtc, present_check_flip(RRCrtcPtr crtc,
WindowPtr window, WindowPtr window,
@@ -95,6 +72,7 @@ present_check_flip(RRCrtcPtr crtc,
PixmapPtr window_pixmap; PixmapPtr window_pixmap;
WindowPtr root = screen->root; WindowPtr root = screen->root;
present_screen_priv_ptr screen_priv = present_screen_priv(screen); present_screen_priv_ptr screen_priv = present_screen_priv(screen);
PresentFlipReason tmp_reason = PRESENT_FLIP_REASON_UNKNOWN;
if (crtc) { if (crtc) {
screen_priv = present_screen_priv(crtc->pScreen); screen_priv = present_screen_priv(crtc->pScreen);
@@ -115,6 +93,27 @@ present_check_flip(RRCrtcPtr crtc,
if (!screen_priv->info->flip) if (!screen_priv->info->flip)
return FALSE; return FALSE;
/* Ask the driver for permission. Do this now to see if there's TearFree. */
if (screen_priv->info->version >= 1 && screen_priv->info->check_flip2) {
if (!(*screen_priv->info->check_flip2) (crtc, window, pixmap, sync_flip, &tmp_reason)) {
DebugPresent(("\td %08" PRIx32 " -> %08" PRIx32 "\n", window->drawable.id, pixmap ? pixmap->drawable.id : 0));
/* It's fine to return now unless the page flip failure reason is
* PRESENT_FLIP_REASON_BUFFER_FORMAT; we must only output that
* reason if all the other checks pass.
*/
if (!reason || tmp_reason != PRESENT_FLIP_REASON_BUFFER_FORMAT) {
if (reason)
*reason = tmp_reason;
return FALSE;
}
}
} else if (screen_priv->info->check_flip) {
if (!(*screen_priv->info->check_flip) (crtc, window, pixmap, sync_flip)) {
DebugPresent(("\td %08" PRIx32 " -> %08" PRIx32 "\n", window->drawable.id, pixmap ? pixmap->drawable.id : 0));
return FALSE;
}
}
/* Make sure the window hasn't been redirected with Composite */ /* Make sure the window hasn't been redirected with Composite */
window_pixmap = screen->GetWindowPixmap(window); window_pixmap = screen->GetWindowPixmap(window);
if (window_pixmap != screen->GetScreenPixmap(screen) && if (window_pixmap != screen->GetScreenPixmap(screen) &&
@@ -145,13 +144,9 @@ present_check_flip(RRCrtcPtr crtc,
return FALSE; return FALSE;
} }
/** if (tmp_reason == PRESENT_FLIP_REASON_BUFFER_FORMAT) {
* Ask the driver for permission if (reason)
* *reason = tmp_reason;
* We need to call the driver check flip after the full-screen window check.
* See: https://github.com/X11Libre/xserver/issues/1754
*/
if (!present_check_driver_flip(crtc, window, pixmap, sync_flip, screen_priv, reason)) {
return FALSE; return FALSE;
} }