XLibre/xserver
1
1
Fork 0
mirror of https://github.com/X11Libre/xserver.git synced 2026-03-24 08:04:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

dix: dixutils: make workQueue pointer dix-private

Browse Source 
The workQueue pointer is currently declared extern, so that WaitForSomething()
can check wether we've got something in the queue and call ProcessWorkQueue()
then.

But that's trivial to simplify: just let ProcessWorkQueue() return early if
workQueue == NULL. Gives us a better isolation of internal stuff as well as
ProcessWorkQueue() protecting itself from possible segfault.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Part-of: <https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1310>
This commit is contained in:
Enrico Weigelt, metux IT consult
2024-02-19 12:52:25 +01:00
committed by Marge Bot
parent 834acc88fb
commit af9f70013a
4 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
doc/Xserver-spec.xml
View File

@@ -657,14 +657,11 @@ make the server suspend until one or more of the following occurs:
<para>
Before WaitForSomething() computes the masks to pass to select, poll or
similar operating system interface, it needs to
see if there is anything to do on the work queue; if so, it must call a DIX
routine called ProcessWorkQueue.
see if there is anything to do on the work queue; it must call a DIX
routine called ProcessWorkQueue().
<blockquote>
<programlisting>
extern WorkQueuePtr workQueue;
if (workQueue)
ProcessWorkQueue ();
ProcessWorkQueue ();
</programlisting>
</blockquote>
</para>