From 9a920b8fc50c476d179696989227b948b6dfc2be Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Tue, 16 Sep 2025 13:35:40 +0200 Subject: [PATCH] dix: make ProcBadRequest() static Nobody outside tables.c is actually using it, so can be static. The function used to be _X_EXPORT'ed, but there's no indication that any external driver (not even proprietary NVidia) ever using it, so we can get away w/o ABI version bump. Signed-off-by: Enrico Weigelt, metux IT consult --- dix/dispatch.c | 6 ------ dix/tables.c | 6 ++++++ include/dixstruct.h | 3 --- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/dix/dispatch.c b/dix/dispatch.c index 0a7fc948c8..2b01e26da8 100644 --- a/dix/dispatch.c +++ b/dix/dispatch.c @@ -716,12 +716,6 @@ CreateConnectionBlock(void) return TRUE; } -int -ProcBadRequest(ClientPtr client) -{ - return BadRequest; -} - int ProcCreateWindow(ClientPtr client) { diff --git a/dix/tables.c b/dix/tables.c index 2c096c3173..50494d18a9 100644 --- a/dix/tables.c +++ b/dix/tables.c @@ -59,6 +59,12 @@ SOFTWARE. #include "swaprep.h" #include "swapreq.h" +static int +ProcBadRequest(ClientPtr client) +{ + return BadRequest; +} + int (*InitialVector[3]) (ClientPtr /* client */) = { 0, ProcInitialConnection, diff --git a/include/dixstruct.h b/include/dixstruct.h index 06a5c1b2c7..4d112b4887 100644 --- a/include/dixstruct.h +++ b/include/dixstruct.h @@ -156,7 +156,4 @@ extern _X_EXPORT int (*SwappedProcVector[256]) (ClientPtr /*client */ ); /* fixme: still needed by (public) dix.h */ extern ReplySwapPtr ReplySwapVector[256]; -extern _X_EXPORT int -ProcBadRequest(ClientPtr /*client */ ); - #endif /* DIXSTRUCT_H */