From 4a313ffbd716f18acb0dff1a365aca97d5deff46 Mon Sep 17 00:00:00 2001
From: "Enrico Weigelt, metux IT consult" <info@metux.net>
Date: Fri, 4 Oct 2024 20:44:12 +0200
Subject: [PATCH] (!1714) xv: use CloseScreen hook

Wrapping ScreenRec's function pointers is problematic for many reasons, so
use the new screen close notify hook instead.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 Xext/xvdix.h  |  1 -
 Xext/xvmain.c | 12 ++++--------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/Xext/xvdix.h b/Xext/xvdix.h
index 38b5995831..e1f33e1b49 100644
--- a/Xext/xvdix.h
+++ b/Xext/xvdix.h
@@ -174,7 +174,6 @@ typedef struct {
     int nAdaptors;
     XvAdaptorPtr pAdaptors;
     DestroyPixmapProcPtr DestroyPixmap;
-    CloseScreenProcPtr CloseScreen;
 } XvScreenRec, *XvScreenPtr;
 
 extern _X_EXPORT int XvScreenInit(ScreenPtr);
diff --git a/Xext/xvmain.c b/Xext/xvmain.c
index 023cc01d4e..ee29ca0514 100644
--- a/Xext/xvmain.c
+++ b/Xext/xvmain.c
@@ -140,7 +140,7 @@ static void WriteSwappedVideoNotifyEvent(xvEvent *, xvEvent *);
 static void WriteSwappedPortNotifyEvent(xvEvent *, xvEvent *);
 static Bool CreateResourceTypes(void);
 
-static Bool XvCloseScreen(ScreenPtr);
+static void XvScreenClose(ScreenPtr, void *arg);
 static Bool XvDestroyPixmap(PixmapPtr);
 static void XvResetProc(ExtensionEntry *);
 static int XvdiDestroyGrab(void *, XID);
@@ -295,33 +295,29 @@ XvScreenInit(ScreenPtr pScreen)
     dixSetPrivate(&pScreen->devPrivates, XvScreenKey, pxvs);
 
     pxvs->DestroyPixmap = pScreen->DestroyPixmap;
-    pxvs->CloseScreen = pScreen->CloseScreen;
 
     dixScreenHookWindowDestroy(pScreen, XvWindowDestroy, NULL);
+    dixScreenHookClose(pScreen, XvScreenClose, NULL);
 
     pScreen->DestroyPixmap = XvDestroyPixmap;
-    pScreen->CloseScreen = XvCloseScreen;
 
     return Success;
 }
 
-static Bool
-XvCloseScreen(ScreenPtr pScreen)
+static void XvScreenClose(ScreenPtr pScreen, void *arg)
 {
     XvScreenPtr pxvs;
 
     pxvs = (XvScreenPtr) dixLookupPrivate(&pScreen->devPrivates, XvScreenKey);
 
     dixScreenUnhookWindowDestroy(pScreen, XvWindowDestroy, NULL);
+    dixScreenUnhookClose(pScreen, XvScreenClose, NULL);
 
     pScreen->DestroyPixmap = pxvs->DestroyPixmap;
-    pScreen->CloseScreen = pxvs->CloseScreen;
 
     free(pxvs);
 
     dixSetPrivate(&pScreen->devPrivates, XvScreenKey, NULL);
-
-    return (*pScreen->CloseScreen) (pScreen);
 }
 
 static void