diff --git a/hw/xnest/Init.c b/hw/xnest/Init.c index 36e801f30..5a273c67b 100644 --- a/hw/xnest/Init.c +++ b/hw/xnest/Init.c @@ -23,6 +23,7 @@ is" without express or implied warranty. #include "dix/screenint_priv.h" #include "mi/mi_priv.h" #include "os/ddx_priv.h" +#include "os/log_priv.h" #include "os/osdep.h" #include "screenint.h" diff --git a/os/log.c b/os/log.c index f90e4e709..0c3b421e0 100644 --- a/os/log.c +++ b/os/log.c @@ -88,6 +88,10 @@ OR PERFORMANCE OF THIS SOFTWARE. #include #include +#ifdef CONFIG_SYSLOG +#include +#endif + #include "dix/dix_priv.h" #include "dix/input_priv.h" #include "os/audit.h" @@ -110,11 +114,17 @@ OR PERFORMANCE OF THIS SOFTWARE. /* Default logging parameters. */ #define DEFAULT_LOG_VERBOSITY 0 #define DEFAULT_LOG_FILE_VERBOSITY 3 +#define DEFAULT_SYSLOG_VERBOSITY 0 Bool logSync = FALSE; int logVerbosity = DEFAULT_LOG_VERBOSITY; int logFileVerbosity = DEFAULT_LOG_FILE_VERBOSITY; +#ifdef CONFIG_SYSLOG +int xorgSyslogVerbosity = DEFAULT_SYSLOG_VERBOSITY; +const char *xorgSyslogIdent = "X"; +#endif + static int logFileFd = -1; /* Buffer to information logged before the log file is opened. */ @@ -207,6 +217,18 @@ static inline void doLogSync(void) { #endif } +static void initSyslog(void) { +#ifdef CONFIG_SYSLOG + char buffer[4096]; + strcpy(buffer, xorgSyslogIdent); + + snprintf(buffer, sizeof(buffer), "%s :%s", xorgSyslogIdent, (display ? display : "<>")); + + /* initialize syslog */ + openlog(buffer, LOG_PID, LOG_LOCAL1); +#endif +} + /* * LogInit is called to start logging to a file. It is also called (with * NULL arguments) when logging to a file is not wanted. It must always be @@ -264,6 +286,7 @@ LogInit(const char *fname, const char *backup) } needBuffer = FALSE; + initSyslog(); return logFileName; } @@ -295,6 +318,7 @@ LogSetDisplay(void) free(saved_log_fname); free(saved_log_backup); } + initSyslog(); } void @@ -529,6 +553,19 @@ vpnprintf(char *string, int size_in, const char *f, va_list args) return s_idx; } +static void +LogSyslogWrite(int verb, const char *buf, size_t len, Bool end_line) { +#ifdef CONFIG_SYSLOG + if (inSignalContext) // syslog() ins't signal-safe yet :( + return; // shall we try syslog(2) syscall instead ? + + if (verb >= 0 && xorgSyslogVerbosity < verb) + return; + + syslog(LOG_PID, "%.*s", (int)len, buf); +#endif +} + /* This function does the actual log message writes. It must be signal safe. * When attempting to call non-signal-safe functions, guard them with a check * of the inSignalContext global variable. */ @@ -538,6 +575,8 @@ LogSWrite(int verb, const char *buf, size_t len, Bool end_line) static Bool newline = TRUE; int ret; + LogSyslogWrite(verb, buf, len, end_line); + if (verb < 0 || logVerbosity >= verb) ret = write(2, buf, len); diff --git a/os/log_priv.h b/os/log_priv.h index 1c3b56401..87602fa37 100644 --- a/os/log_priv.h +++ b/os/log_priv.h @@ -33,6 +33,23 @@ extern int logVerbosity; */ extern int logFileVerbosity; +/** + * @brief syslog verbosity + * + * The verbosity level of logging to syslog. All messages with + * verbosity level below this one will be sent to local syslog daemon. + */ +extern int xorgSyslogVerbosity; + +/** + * @brief syslog identifier + * + * The identifier prefix used for syslog logging. + * Per default will be filled with basename(argv[0]). DDX'es can override + * this before calling LogInit() + */ +extern const char *xorgSyslogIdent; + /** * @brief initialize logging and open log files * diff --git a/os/meson.build b/os/meson.build index 9906e0fac..e628441f9 100644 --- a/os/meson.build +++ b/os/meson.build @@ -23,6 +23,8 @@ srcs_os = [ 'log.c', ] +conf_data.set('CONFIG_SYSLOG', cc.has_header('syslog.h') ? '1' : false) + # Wrapper code for missing C library functions. Note that conf_data contains either '1' or false. srcs_libc = [] if conf_data.get('HAVE_REALLOCARRAY').to_int() == 0 diff --git a/os/utils.c b/os/utils.c index 6c33806b1..7a0809792 100644 --- a/os/utils.c +++ b/os/utils.c @@ -77,6 +77,8 @@ __stdcall unsigned long GetTickCount(void); #define TRANS_REOPEN #include +#include + #include "input.h" #include "dixfont.h" #include @@ -439,6 +441,12 @@ ProcessCommandLine(int argc, char *argv[]) } SeatId = getenv("XDG_SEAT"); +#ifdef CONFIG_SYSLOG + xorgSyslogIdent = getenv("SYSLOG_IDENT"); + if (!xorgSyslogIdent) + xorgSyslogIdent = strdup(basename(argv[0])); +#endif + for (i = 1; i < argc; i++) { /* call ddx first, so it can peek/override if it wants */ if ((skip = ddxProcessArgument(argc, argv, i))) { @@ -805,6 +813,9 @@ ProcessCommandLine(int argc, char *argv[]) else UseMsg(); } +#ifdef CONFIG_SYSLOG + else if (ProcessCmdLineMultiInt(argc, argv, &i, "-syslogverbose", &xorgSyslogVerbosity)); +#endif else { ErrorF("Unrecognized option: %s\n", argv[i]); UseMsg();