From 24885d90194f13eacde21f2ec578f2c88a4e9f9a Mon Sep 17 00:00:00 2001 From: "Enrico Weigelt, metux IT consult" Date: Mon, 8 Sep 2025 13:25:40 +0200 Subject: [PATCH] render: consolidate byte-swapping in ProcRenderCreateGlyphSet() No need for extra functions and call tables for the few trivial lines. Signed-off-by: Enrico Weigelt, metux IT consult --- render/render.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/render/render.c b/render/render.c index dcdadb9e36..645c77a8b5 100644 --- a/render/render.c +++ b/render/render.c @@ -105,7 +105,6 @@ static int SProcRenderTrapezoids(ClientPtr pClient); static int SProcRenderTriangles(ClientPtr pClient); static int SProcRenderTriStrip(ClientPtr pClient); static int SProcRenderTriFan(ClientPtr pClient); -static int SProcRenderCreateGlyphSet(ClientPtr pClient); static int SProcRenderReferenceGlyphSet(ClientPtr pClient); static int SProcRenderFreeGlyphSet(ClientPtr pClient); static int SProcRenderAddGlyphs(ClientPtr pClient); @@ -181,7 +180,7 @@ int (*SProcRenderVector[RenderNumberRequests]) (ClientPtr) = { _not_implemented, /* SProcRenderColorTrapezoids */ _not_implemented, /* SProcRenderColorTriangles */ _not_implemented, /* SProcRenderTransform */ - SProcRenderCreateGlyphSet, + ProcRenderCreateGlyphSet, SProcRenderReferenceGlyphSet, SProcRenderFreeGlyphSet, SProcRenderAddGlyphs, @@ -832,9 +831,13 @@ ProcRenderCreateGlyphSet(ClientPtr client) int rc, f; REQUEST(xRenderCreateGlyphSetReq); - REQUEST_SIZE_MATCH(xRenderCreateGlyphSetReq); + if (client->swapped) { + swapl(&stuff->gsid); + swapl(&stuff->format); + } + LEGAL_NEW_RESOURCE(stuff->gsid, client); rc = dixLookupResourceByType((void **) &format, stuff->format, PictFormatType, client, DixReadAccess); @@ -2053,16 +2056,6 @@ SProcRenderTriFan(ClientPtr client) return ProcRenderTriFan(client); } -static int _X_COLD -SProcRenderCreateGlyphSet(ClientPtr client) -{ - REQUEST(xRenderCreateGlyphSetReq); - REQUEST_SIZE_MATCH(xRenderCreateGlyphSetReq); - swapl(&stuff->gsid); - swapl(&stuff->format); - return ProcRenderCreateGlyphSet(client); -} - static int _X_COLD SProcRenderReferenceGlyphSet(ClientPtr client) {