From 362a97d43c063809f9d64f9c762f50c382fd4cd3 Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab Date: Fri, 11 Feb 2011 08:58:30 -0200 Subject: [PATCH] Return BadMatch if a Port Attribute is not found Fix a small non-compliance issue: if a port attribute is not known, according with Xv specs, it should return BadMatch, and not BadValue. Signed-off-by: Mauro Carvalho Chehab --- src/v4l.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/v4l.c b/src/v4l.c index 8b3d87e..fbb8bd7 100644 --- a/src/v4l.c +++ b/src/v4l.c @@ -790,6 +790,8 @@ V4lSetPortAttribute(ScrnInfoPtr pScrn, /* not mine -> pass to yuv scaler driver */ if (0 != pPPriv->yuv_format && pPPriv->myfmt->setAttribute) ret = pPPriv->myfmt->setAttribute(pScrn, attribute, value); + else + ret = BadMatch; goto err; } if (pPPriv->XvV4LCtrl[i].qctrl.flags & V4L2_CTRL_FLAG_DISABLED) @@ -839,6 +841,8 @@ V4lGetPortAttribute(ScrnInfoPtr pScrn, /* not mine -> pass to yuv scaler driver */ if (0 != pPPriv->yuv_format && pPPriv->myfmt->getAttribute) ret = pPPriv->myfmt->getAttribute(pScrn, attribute, value); + else + ret = BadMatch; goto err; } if (pPPriv->XvV4LCtrl[i].qctrl.flags & V4L2_CTRL_FLAG_DISABLED)