XLibre/xf86-video-sis
1
0
Fork 0
mirror of https://github.com/X11Libre/xf86-video-sis.git synced 2026-03-24 01:25:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use strdup() instead of malloc(strlen()+1); memcpy() pairs

Browse Source 
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
This commit is contained in:
Alan Coopersmith
2024-03-10 15:32:12 -07:00
parent 4c5ce451f0
commit cc2f4d685f
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sis_opt.c
View File

@@ -949,16 +949,13 @@ SiSOptions(ScrnInfoPtr pScrn)
free(tempstr); free(tempstr);
} }
if((strptr = (char *)xf86GetOptValString(pSiS->Options, OPTION_METAMODES))) { if((strptr = (char *)xf86GetOptValString(pSiS->Options, OPTION_METAMODES))) {
pSiS->MetaModes = malloc(strlen(strptr) + 1); pSiS->MetaModes = strdup(strptr);
if(pSiS->MetaModes) memcpy(pSiS->MetaModes, strptr, strlen(strptr) + 1);
} }
if((strptr = (char *)xf86GetOptValString(pSiS->Options, OPTION_CRT2HSYNC))) { if((strptr = (char *)xf86GetOptValString(pSiS->Options, OPTION_CRT2HSYNC))) {
pSiS->CRT2HSync = malloc(strlen(strptr) + 1); pSiS->CRT2HSync = strdup(strptr);
if(pSiS->CRT2HSync) memcpy(pSiS->CRT2HSync, strptr, strlen(strptr) + 1);
} }
if((strptr = (char *)xf86GetOptValString(pSiS->Options, OPTION_CRT2VREFRESH))) { if((strptr = (char *)xf86GetOptValString(pSiS->Options, OPTION_CRT2VREFRESH))) {
pSiS->CRT2VRefresh = malloc(strlen(strptr) + 1); pSiS->CRT2VRefresh = strdup(strptr);
if(pSiS->CRT2VRefresh) memcpy(pSiS->CRT2VRefresh, strptr, strlen(strptr) + 1);
} }
if((strptr = (char *)xf86GetOptValString(pSiS->Options, OPTION_MERGEDDPI))) { if((strptr = (char *)xf86GetOptValString(pSiS->Options, OPTION_MERGEDDPI))) {
int val1 = 0, val2 = 0; int val1 = 0, val2 = 0;