ast_vgatool.c:3400:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
void static vGetDefaultSettings(ScrnInfoPtr pScrn)
^~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
At top level:
ast_mode.c:389:23: warning: ‘DAC_EGA’ defined but not used [-Wunused-variable]
static VBIOS_DAC_INFO DAC_EGA[] = {
^~~~~~~
ast_mode.c:370:23: warning: ‘DAC_TEXT’ defined but not used [-Wunused-variable]
static VBIOS_DAC_INFO DAC_TEXT[] = {
^~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Clears 67 out of 84 warnings of the form:
In file included from ast_cursor.c:53:0:
ast_cursor.c: In function ‘ASTLoadCursorImage’:
ast_vgatool.h:149:15: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable]
ULONG temp; \
^
ast_cursor.c:293:9: note: in expansion of macro ‘WriteAST1180SOC’
WriteAST1180SOC(AST1180_GFX_BASE+AST1180_HWC1_PATTERNADDR, ulPatternAddr);
^~~~~~~~~~~~~~~
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
xf86UnclaimPciSlot() received a GDevPtr as 2nd argument with
ABI_VIDEODRV_VERSION 13.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
Move inclusion of local headers from ast.h to the individual
files. Include only those headers which are needed.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
- Made sure exported functions have 'AST' in their name.
This avoids name space conflicts with the server or other drivers.
- Placed declaration of exported functions in a header file.
This ensures that changes to the function type or arguments are followed
thru everywhere.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
- Made sure exported functions have 'AST' in their name.
This avoids name space conflicts with the server or other drivers.
- Placed declaration of exported functions in a header file.
This ensures that changes to the function type or arguments are followed
thru everywhere.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
- Make local functions static
This sometimes helps the compiler to optimize.
- Made sure exported functions have 'AST' in their name.
This avoids name space conflicts with the server or other drivers.
- Placed declaration of exported functions in a header file.
This ensures that changes to the function type or arguments are followed
thru everywhere.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
- Make sure exported functions have 'AST' in their name.
This avoids name space conflicts with the server or other drivers.
- Place declaration of exported functions in a header file.
This ensures that changes to the function type or arguments are followed
thru everywhere.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
- Make local functions static
This sometimes helps the compiler to optimize.
- Make sure exported functions have 'AST' in their name.
This avoids name space conflicts with the server or other drivers.
- Place declaration of exported functions in a header file.
This ensures that changes to the function type or arguments are followed
thru everywhere.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
- Make local functions static
This sometimes helps the compiler to optimize.
- Make sure exported functions have 'AST' in their name.
This avoids name space conflicts with the server or other drivers.
- Place declaration of exported functions in a header file.
This ensures that changes to the function type or arguments are followed
thru everywhere.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
An archaeological survey revealed that this ABI change took place
in 2006 already.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
For newer ABI versions IOADDRESS can be replaced by int
which is big enough to hold an PIO offset.
Signed-off-by: Egbert Eich <eich@suse.de>
Acked-by: Y.C. Chen <yc_chen@aspeedtech.com>
Seems some code came from cirrus driver by copy & paste. Fixed
this in error message about device already in use by KMS module.
Signed-off-by: Stefan Dirsch <sndirsch@suse.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
if we find a kernel driver the code leave the pci slot claimed which
stops us falling back. unclaim the pci slot. patch inspired by
correspondant patch for cirrus driver by Dave Airlie.
Signed-off-by: Stefan Dirsch <sndirsch@suse.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
